Implement GetDefaultPrintSettings for pepper

Provides a real implementation of GetDefaultPrintSettings.

This accesses the Chrome printing code to determine the default print settings for the default printer. Ideally we would query these settings every time they are requested, however this cannot be done (see the description in pepper_print_settings_initializer.h). Instead the settings are grabbed once at startup and cached.

BUG=
TEST=Added ppapi test.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=143294

[yzshen1, 2012-06-18 23:54:10]

https://chromiumcodereview.appspot.com/10539171/diff/28002/content/browser/re...
File content/browser/renderer_host/pepper_print_settings_initializer.cc (right):

https://chromiumcodereview.appspot.com/10539171/diff/28002/content/browser/re...
content/browser/renderer_host/pepper_print_settings_initializer.cc:8: #include
"ppapi/c/dev/pp_print_settings_dev.h"
You have included it in .h file.

https://chromiumcodereview.appspot.com/10539171/diff/28002/content/browser/re...
content/browser/renderer_host/pepper_print_settings_initializer.cc:17: #if
defined(ENABLE_PRINTING)
Do we have to put it behind a #if block?

https://chromiumcodereview.appspot.com/10539171/diff/28002/content/browser/re...
content/browser/renderer_host/pepper_print_settings_initializer.cc:79:
printing::PrintingContext* context = printing::PrintingContext::Create("");
Is this leaking?

https://chromiumcodereview.appspot.com/10539171/diff/28002/content/browser/re...
content/browser/renderer_host/pepper_print_settings_initializer.cc:83:
print_settings.page_setup_device_units();
Wrong indent. (the whole method)

https://chromiumcodereview.appspot.com/10539171/diff/28002/content/browser/re...
content/browser/renderer_host/pepper_print_settings_initializer.cc:84: int dupi
= print_settings.device_units_per_inch();
nit: please avoid variable name like this.

https://chromiumcodereview.appspot.com/10539171/diff/28002/content/browser/re...
File content/browser/renderer_host/pepper_print_settings_initializer.h (right):

https://chromiumcodereview.appspot.com/10539171/diff/28002/content/browser/re...
content/browser/renderer_host/pepper_print_settings_initializer.h:15: // they
are requested (because there is a chance they could change) however we
Maybe you could notify this class to update the cached |default_print_settings_|
whenever the settings change?

https://chromiumcodereview.appspot.com/10539171/diff/28002/content/browser/re...
content/browser/renderer_host/pepper_print_settings_initializer.h:24:
content::BrowserThread::ID accessor_thread);
If IO is the only thread that this class will be used on, we could remove
|accessor_thread|.

https://chromiumcodereview.appspot.com/10539171/diff/28002/ppapi/tests/test_p...
File ppapi/tests/test_printing.cc (right):

https://chromiumcodereview.appspot.com/10539171/diff/28002/ppapi/tests/test_p...
ppapi/tests/test_printing.cc:18: uint32_t QuerySupportedPrintOutputFormats() {
return 0; }
This is also vritual.

https://chromiumcodereview.appspot.com/10539171/diff/28002/ppapi/tests/test_p...
ppapi/tests/test_printing.cc:23: uint32_t page_range_count) { return
pp::Resource(); }
- The return value should be a PPB_Buffer resource, right?
- Now that the whole method cannot fit into 1 line, please move the method body
to its own line(s).

https://chromiumcodereview.appspot.com/10539171/diff/28002/ppapi/tests/test_p...
ppapi/tests/test_printing.cc:43: ASSERT_TRUE(print_settings.orientation ==
PP_PRINTORIENTATION_NORMAL);
Please use ASSERT_EQ() for the following lines.

[raymes, 2012-06-19 02:56:21]

https://chromiumcodereview.appspot.com/10539171/diff/28002/content/browser/re...
File content/browser/renderer_host/pepper_print_settings_initializer.cc (right):

https://chromiumcodereview.appspot.com/10539171/diff/28002/content/browser/re...
content/browser/renderer_host/pepper_print_settings_initializer.cc:8: #include
"ppapi/c/dev/pp_print_settings_dev.h"
On 2012/06/18 23:54:11, yzshen1 wrote:
> You have included it in .h file.

Done.

https://chromiumcodereview.appspot.com/10539171/diff/28002/content/browser/re...
content/browser/renderer_host/pepper_print_settings_initializer.cc:17: #if
defined(ENABLE_PRINTING)
On 2012/06/18 23:54:11, yzshen1 wrote:
> Do we have to put it behind a #if block?

Unfortunately yes because if printing is disabled, this function wont be
compiled.

https://chromiumcodereview.appspot.com/10539171/diff/28002/content/browser/re...
content/browser/renderer_host/pepper_print_settings_initializer.cc:79:
printing::PrintingContext* context = printing::PrintingContext::Create("");
On 2012/06/18 23:54:11, yzshen1 wrote:
> Is this leaking?

Yes, thanks.

https://chromiumcodereview.appspot.com/10539171/diff/28002/content/browser/re...
content/browser/renderer_host/pepper_print_settings_initializer.cc:83:
print_settings.page_setup_device_units();
On 2012/06/18 23:54:11, yzshen1 wrote:
> Wrong indent. (the whole method)

Done.

https://chromiumcodereview.appspot.com/10539171/diff/28002/content/browser/re...
content/browser/renderer_host/pepper_print_settings_initializer.cc:84: int dupi
= print_settings.device_units_per_inch();
On 2012/06/18 23:54:11, yzshen1 wrote:
> nit: please avoid variable name like this.

Done.

https://chromiumcodereview.appspot.com/10539171/diff/28002/content/browser/re...
File content/browser/renderer_host/pepper_print_settings_initializer.h (right):

https://chromiumcodereview.appspot.com/10539171/diff/28002/content/browser/re...
content/browser/renderer_host/pepper_print_settings_initializer.h:15: // they
are requested (because there is a chance they could change) however we
On 2012/06/18 23:54:11, yzshen1 wrote:
> Maybe you could notify this class to update the cached
|default_print_settings_|
> whenever the settings change?

I can't see an easy way to do this right now, but that could definitely be an
option.

https://chromiumcodereview.appspot.com/10539171/diff/28002/content/browser/re...
content/browser/renderer_host/pepper_print_settings_initializer.h:24:
content::BrowserThread::ID accessor_thread);
On 2012/06/18 23:54:11, yzshen1 wrote:
> If IO is the only thread that this class will be used on, we could remove
> |accessor_thread|.

Done.

https://chromiumcodereview.appspot.com/10539171/diff/28002/ppapi/tests/test_p...
File ppapi/tests/test_printing.cc (right):

https://chromiumcodereview.appspot.com/10539171/diff/28002/ppapi/tests/test_p...
ppapi/tests/test_printing.cc:18: uint32_t QuerySupportedPrintOutputFormats() {
return 0; }
On 2012/06/18 23:54:11, yzshen1 wrote:
> This is also vritual.

Done.

https://chromiumcodereview.appspot.com/10539171/diff/28002/ppapi/tests/test_p...
ppapi/tests/test_printing.cc:23: uint32_t page_range_count) { return
pp::Resource(); }
On 2012/06/18 23:54:11, yzshen1 wrote:
> - The return value should be a PPB_Buffer resource, right?
> - Now that the whole method cannot fit into 1 line, please move the method
body
> to its own line(s).

Done.

https://chromiumcodereview.appspot.com/10539171/diff/28002/ppapi/tests/test_p...
ppapi/tests/test_printing.cc:43: ASSERT_TRUE(print_settings.orientation ==
PP_PRINTORIENTATION_NORMAL);
On 2012/06/18 23:54:11, yzshen1 wrote:
> Please use ASSERT_EQ() for the following lines.

Done.

[yzshen1, 2012-06-19 05:52:07]

lgtm

[jochen (gone - plz use gerrit), 2012-06-19 13:07:16]

drive-by content review

https://chromiumcodereview.appspot.com/10539171/diff/39015/content/browser/re...
File content/browser/renderer_host/pepper_print_settings_initializer.cc (right):

https://chromiumcodereview.appspot.com/10539171/diff/39015/content/browser/re...
content/browser/renderer_host/pepper_print_settings_initializer.cc:7: #include
"content/public/browser/browser_thread.h"
code in content/ should use browser_thread_impl.h

https://chromiumcodereview.appspot.com/10539171/diff/39015/content/browser/re...
File content/browser/renderer_host/pepper_print_settings_initializer.h (right):

https://chromiumcodereview.appspot.com/10539171/diff/39015/content/browser/re...
content/browser/renderer_host/pepper_print_settings_initializer.h:7: 
#pragma once

https://chromiumcodereview.appspot.com/10539171/diff/39015/content/browser/re...
content/browser/renderer_host/pepper_print_settings_initializer.h:9: #include
"content/public/browser/browser_thread.h"
not required?

https://chromiumcodereview.appspot.com/10539171/diff/39015/content/browser/re...
content/browser/renderer_host/pepper_print_settings_initializer.h:19: class
PepperPrintSettingsInitializer
code in content/ should go into the content namespace

[raymes, 2012-06-19 15:36:35]

Thanks

https://chromiumcodereview.appspot.com/10539171/diff/39015/content/browser/re...
File content/browser/renderer_host/pepper_print_settings_initializer.cc (right):

https://chromiumcodereview.appspot.com/10539171/diff/39015/content/browser/re...
content/browser/renderer_host/pepper_print_settings_initializer.cc:7: #include
"content/public/browser/browser_thread.h"
On 2012/06/19 13:07:16, jochen wrote:
> code in content/ should use browser_thread_impl.h

Done.

https://chromiumcodereview.appspot.com/10539171/diff/39015/content/browser/re...
File content/browser/renderer_host/pepper_print_settings_initializer.h (right):

https://chromiumcodereview.appspot.com/10539171/diff/39015/content/browser/re...
content/browser/renderer_host/pepper_print_settings_initializer.h:7: 
On 2012/06/19 13:07:16, jochen wrote:
> #pragma once

Done.

https://chromiumcodereview.appspot.com/10539171/diff/39015/content/browser/re...
content/browser/renderer_host/pepper_print_settings_initializer.h:9: #include
"content/public/browser/browser_thread.h"
On 2012/06/19 13:07:16, jochen wrote:
> not required?

Done.

https://chromiumcodereview.appspot.com/10539171/diff/39015/content/browser/re...
content/browser/renderer_host/pepper_print_settings_initializer.h:19: class
PepperPrintSettingsInitializer
On 2012/06/19 13:07:16, jochen wrote:
> code in content/ should go into the content namespace

Done.

[raymes, 2012-06-19 15:45:31]

+brettw for content/* approval.

[jochen (gone - plz use gerrit), 2012-06-19 17:50:33]

https://chromiumcodereview.appspot.com/10539171/diff/25004/content/browser/re...
File content/browser/renderer_host/pepper_message_filter.cc (right):

https://chromiumcodereview.appspot.com/10539171/diff/25004/content/browser/re...
content/browser/renderer_host/pepper_message_filter.cc:81:
print_settings_initializer_(new content::PepperPrintSettingsInitializer) {
eventually, PepperMessageFilter will be moved to content as well. To ease this
transition, add "using content::PepperPrinterSettingsInitializer" to the top of
this file and drop the content:: here

https://chromiumcodereview.appspot.com/10539171/diff/25004/content/browser/re...
content/browser/renderer_host/pepper_message_filter.cc:99:
print_settings_initializer_(new content::PepperPrintSettingsInitializer) {
and here

https://chromiumcodereview.appspot.com/10539171/diff/25004/content/browser/re...
File content/browser/renderer_host/pepper_print_settings_initializer.cc (right):

https://chromiumcodereview.appspot.com/10539171/diff/25004/content/browser/re...
content/browser/renderer_host/pepper_print_settings_initializer.cc:12: namespace
{
nit. empty line between the two namespaces

https://chromiumcodereview.appspot.com/10539171/diff/25004/content/browser/re...
content/browser/renderer_host/pepper_print_settings_initializer.cc:15: const
content::BrowserThread::ID kAccessorThread = content::BrowserThread::IO;
you can drop the content::, as you're in content namespace now

https://chromiumcodereview.appspot.com/10539171/diff/25004/content/browser/re...
content/browser/renderer_host/pepper_print_settings_initializer.cc:58:
content::BrowserThread::PostTask(content::BrowserThread::UI, FROM_HERE,
and here

https://chromiumcodereview.appspot.com/10539171/diff/25004/content/browser/re...
content/browser/renderer_host/pepper_print_settings_initializer.cc:64:
DCHECK(content::BrowserThread::CurrentlyOn(kAccessorThread));
and here

https://chromiumcodereview.appspot.com/10539171/diff/25004/content/browser/re...
content/browser/renderer_host/pepper_print_settings_initializer.cc:109:
content::BrowserThread::PostTask(kAccessorThread, FROM_HERE,
and here

https://chromiumcodereview.appspot.com/10539171/diff/25004/content/browser/re...
content/browser/renderer_host/pepper_print_settings_initializer.cc:117:
DCHECK(content::BrowserThread::CurrentlyOn(kAccessorThread));
and here :)

https://chromiumcodereview.appspot.com/10539171/diff/25004/content/browser/re...
content/browser/renderer_host/pepper_print_settings_initializer.cc:122: }  //
namespace
// namespace content

https://chromiumcodereview.appspot.com/10539171/diff/25004/content/browser/re...
File content/browser/renderer_host/pepper_print_settings_initializer.h (right):

https://chromiumcodereview.appspot.com/10539171/diff/25004/content/browser/re...
content/browser/renderer_host/pepper_print_settings_initializer.h:43: }  //
namespace
// namespace content

[raymes, 2012-06-19 17:58:44]

https://chromiumcodereview.appspot.com/10539171/diff/25004/content/browser/re...
File content/browser/renderer_host/pepper_message_filter.cc (right):

https://chromiumcodereview.appspot.com/10539171/diff/25004/content/browser/re...
content/browser/renderer_host/pepper_message_filter.cc:81:
print_settings_initializer_(new content::PepperPrintSettingsInitializer) {
On 2012/06/19 17:50:34, jochen wrote:
> eventually, PepperMessageFilter will be moved to content as well. To ease this
> transition, add "using content::PepperPrinterSettingsInitializer" to the top
of
> this file and drop the content:: here

Done.

https://chromiumcodereview.appspot.com/10539171/diff/25004/content/browser/re...
content/browser/renderer_host/pepper_message_filter.cc:99:
print_settings_initializer_(new content::PepperPrintSettingsInitializer) {
On 2012/06/19 17:50:34, jochen wrote:
> and here

Done.

https://chromiumcodereview.appspot.com/10539171/diff/25004/content/browser/re...
File content/browser/renderer_host/pepper_print_settings_initializer.cc (right):

https://chromiumcodereview.appspot.com/10539171/diff/25004/content/browser/re...
content/browser/renderer_host/pepper_print_settings_initializer.cc:12: namespace
{
On 2012/06/19 17:50:34, jochen wrote:
> nit. empty line between the two namespaces

Done.

https://chromiumcodereview.appspot.com/10539171/diff/25004/content/browser/re...
content/browser/renderer_host/pepper_print_settings_initializer.cc:15: const
content::BrowserThread::ID kAccessorThread = content::BrowserThread::IO;
On 2012/06/19 17:50:34, jochen wrote:
> you can drop the content::, as you're in content namespace now

Done.

https://chromiumcodereview.appspot.com/10539171/diff/25004/content/browser/re...
content/browser/renderer_host/pepper_print_settings_initializer.cc:58:
content::BrowserThread::PostTask(content::BrowserThread::UI, FROM_HERE,
On 2012/06/19 17:50:34, jochen wrote:
> and here

Done.

https://chromiumcodereview.appspot.com/10539171/diff/25004/content/browser/re...
content/browser/renderer_host/pepper_print_settings_initializer.cc:64:
DCHECK(content::BrowserThread::CurrentlyOn(kAccessorThread));
On 2012/06/19 17:50:34, jochen wrote:
> and here

Done.

https://chromiumcodereview.appspot.com/10539171/diff/25004/content/browser/re...
content/browser/renderer_host/pepper_print_settings_initializer.cc:109:
content::BrowserThread::PostTask(kAccessorThread, FROM_HERE,
On 2012/06/19 17:50:34, jochen wrote:
> and here

Done.

https://chromiumcodereview.appspot.com/10539171/diff/25004/content/browser/re...
content/browser/renderer_host/pepper_print_settings_initializer.cc:117:
DCHECK(content::BrowserThread::CurrentlyOn(kAccessorThread));
On 2012/06/19 17:50:34, jochen wrote:
> and here :)

Done.

https://chromiumcodereview.appspot.com/10539171/diff/25004/content/browser/re...
content/browser/renderer_host/pepper_print_settings_initializer.cc:122: }  //
namespace
On 2012/06/19 17:50:34, jochen wrote:
> // namespace content

Done.

https://chromiumcodereview.appspot.com/10539171/diff/25004/content/browser/re...
File content/browser/renderer_host/pepper_print_settings_initializer.h (right):

https://chromiumcodereview.appspot.com/10539171/diff/25004/content/browser/re...
content/browser/renderer_host/pepper_print_settings_initializer.h:43: }  //
namespace
On 2012/06/19 17:50:34, jochen wrote:
> // namespace content

Done.

[jochen (gone - plz use gerrit), 2012-06-19 18:01:45]

content/ lg

[brettw, 2012-06-19 21:41:14]

https://chromiumcodereview.appspot.com/10539171/diff/26015/content/browser/re...
File content/browser/renderer_host/pepper_message_filter.cc (right):

https://chromiumcodereview.appspot.com/10539171/diff/26015/content/browser/re...
content/browser/renderer_host/pepper_message_filter.cc:116: message.type() ==
PpapiHostMsg_PPBFlashDeviceID_Get::ID) {
Can I suggest an alternate design? If you add your message here, the handler
will get called on the UI thread. Then you can just get the print settings
without having the cache thing (since this is called so rarely I'm not worried
about perf). This will handle all of the thread hopping for you.

This will also eliminate the race condition between initialization in the
browser and requesting the settings.

https://chromiumcodereview.appspot.com/10539171/diff/26015/content/browser/re...
File content/browser/renderer_host/pepper_print_settings_initializer.h (right):

https://chromiumcodereview.appspot.com/10539171/diff/26015/content/browser/re...
content/browser/renderer_host/pepper_print_settings_initializer.h:22: : public
base::RefCountedThreadSafe<PepperPrintSettingsInitializer> {
2 more space indent.

https://chromiumcodereview.appspot.com/10539171/diff/26015/content/browser/re...
content/browser/renderer_host/pepper_print_settings_initializer.h:33: virtual
~PepperPrintSettingsInitializer();
I'd normally put a blank after here.

[brettw, 2012-06-19 22:07:21]

Raymes pointed out why I'm wrong.

LGTM

https://chromiumcodereview.appspot.com/10539171/diff/26015/content/browser/re...
File content/browser/renderer_host/pepper_print_settings_initializer.cc (right):

https://chromiumcodereview.appspot.com/10539171/diff/26015/content/browser/re...
content/browser/renderer_host/pepper_print_settings_initializer.cc:78: // This
function should run on the UI thread because |PrintingContext| methods
Can you put a DCHECK here that we're on the UI thread?

[raymes, 2012-06-19 22:23:04]

https://chromiumcodereview.appspot.com/10539171/diff/26015/content/browser/re...
File content/browser/renderer_host/pepper_print_settings_initializer.cc (right):

https://chromiumcodereview.appspot.com/10539171/diff/26015/content/browser/re...
content/browser/renderer_host/pepper_print_settings_initializer.cc:78: // This
function should run on the UI thread because |PrintingContext| methods
On 2012/06/19 22:07:22, brettw wrote:
> Can you put a DCHECK here that we're on the UI thread?

Done.

https://chromiumcodereview.appspot.com/10539171/diff/26015/content/browser/re...
File content/browser/renderer_host/pepper_print_settings_initializer.h (right):

https://chromiumcodereview.appspot.com/10539171/diff/26015/content/browser/re...
content/browser/renderer_host/pepper_print_settings_initializer.h:22: : public
base::RefCountedThreadSafe<PepperPrintSettingsInitializer> {
On 2012/06/19 21:41:15, brettw wrote:
> 2 more space indent.

Done.

https://chromiumcodereview.appspot.com/10539171/diff/26015/content/browser/re...
content/browser/renderer_host/pepper_print_settings_initializer.h:33: virtual
~PepperPrintSettingsInitializer();
On 2012/06/19 21:41:15, brettw wrote:
> I'd normally put a blank after here.

Done.

[commit-bot: I haz the power, 2012-06-19 22:24:30]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/10539171/42001

[commit-bot: I haz the power, 2012-06-19 23:34:31]

Try job failure for 10539171-42001 (retry) on win for step "compile" (clobber
build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number...

[commit-bot: I haz the power, 2012-06-20 22:29:31]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/10539171/40006

[commit-bot: I haz the power, 2012-06-20 23:30:02]

Change committed as 143294