Fixed clipping printing with EMF.

Restore DC before EndPage call to state if was just after StartPage. We need this because EndPage clips page with current clipping region.

BUG=71509
TEST=unittest

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=143119

[Vitaly Buka (NO REVIEWS), 2012-06-15 21:51:55]

Please review.

[Albert Bodenhamer, 2012-06-18 19:08:53]

http://codereview.chromium.org/10557019/diff/3002/printing/emf_win.h
File printing/emf_win.h (right):

http://codereview.chromium.org/10557019/diff/3002/printing/emf_win.h#newcode116
printing/emf_win.h:116: EnumerationContext();
If you're going to add a constructor, make this a class.

The construstor just 0's it out.  Maybe just assign = {0} when you use this
structure?

[Vitaly Buka (NO REVIEWS), 2012-06-18 19:33:06]

http://codereview.chromium.org/10557019/diff/3002/printing/emf_win.h
File printing/emf_win.h (right):

http://codereview.chromium.org/10557019/diff/3002/printing/emf_win.h#newcode116
printing/emf_win.h:116: EnumerationContext();
Actually according out coding style even methods allows in structures. But
"Methods should not provide behavior but should only be used to set up the data
members, e.g., constructor, destructor, Initialize(), Reset(), Validate()."
http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml#Structs_vs._Cl...

There are examples of structs with constructors in chrome code.

I believe struct with constructor is safer here than without, but class is
redundant here because it's just accessors.

On 2012/06/18 19:08:53, Albert Bodenhamer wrote:
> If you're going to add a constructor, make this a class.
> 
> The construstor just 0's it out.  Maybe just assign = {0} when you use this
> structure?

[Albert Bodenhamer, 2012-06-18 19:37:53]

lgtm

On Mon, Jun 18, 2012 at 12:33 PM, <[email protected]> wrote:

>
>
http://codereview.chromium.**org/10557019/diff/3002/**printing/emf_win.h<http...
> File printing/emf_win.h (right):
>
> http://codereview.chromium.**org/10557019/diff/3002/**
>
printing/emf_win.h#newcode116<http://codereview.chromium.org/10557019/diff/3002/printing/emf_win.h#newcode116>
> printing/emf_win.h:116: EnumerationContext();
> Actually according out coding style even methods allows in structures.
> But "Methods should not provide behavior but should only be used to set
> up the data members, e.g., constructor, destructor, Initialize(),
> Reset(), Validate()."
> http://google-styleguide.**googlecode.com/svn/trunk/**
>
cppguide.xml#Structs_vs._**Classes<http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml#Structs_vs._Classes>
>
> There are examples of structs with constructors in chrome code.
>
> I believe struct with constructor is safer here than without, but class
> is redundant here because it's just accessors.


It's a personal thing.  I just think that if an object is complex enough to
need a constructor then explicitly making it a class rather than a struct
makes its behavior more clear.


>
>
> On 2012/06/18 19:08:53, Albert Bodenhamer wrote:
>
>> If you're going to add a constructor, make this a class.
>>
>
>  The construstor just 0's it out.  Maybe just assign = {0} when you use
>>
> this
>
>> structure?
>>
>
>
http://codereview.chromium.**org/10557019/<http://codereview.chromium.org/105...
>



-- 
Albert Bodenhamer | Software Engineer | abodenha@chromium.<[email protected]>
org

[commit-bot: I haz the power, 2012-06-20 00:16:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/10557019/3002

[commit-bot: I haz the power, 2012-06-20 01:57:39]

Change committed as 143119