Issue 10568010: [File Manager] Show better error message when cannot load images/play media from offline GDrive

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10568010: [File Manager] Show better error message when cannot load images/play media from offline GDrive (Closed)

Created:
8 years, 6 months ago by Vladislav Kaznacheev

Modified:
8 years, 6 months ago

Reviewers:
dgozman

CC:
chromium-reviews, mihaip-chromium-reviews_chromium.org, nkostylev+watch_chromium.org, feature-media-reviews_chromium.org, Aaron Boodman, rginda+watch_chromium.org, arv (Not doing code reviews), oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[File Manager] Show better error message when cannot load images/play media from offline GDrive BUG=128524 TEST= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=142741

Patch Set 1 #

Total comments: 1

Patch Set 2 : Addressed comments #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+167 lines, -30 lines)			Patch
M	chrome/browser/chromeos/extensions/file_browser_private_api.cc	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/resources/file_manager/js/image_editor/gallery.js	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/resources/file_manager/js/image_editor/image_view.js	View	1	2 chunks	+12 lines, -1 line	0 comments	Download
M	chrome/browser/resources/file_manager/js/media/audio_player.js	View		20 chunks	+120 lines, -20 lines	0 comments	Download
M	chrome/browser/resources/file_manager/js/media/video_player.js	View		2 chunks	+26 lines, -9 lines	0 comments	Download
M	chrome/browser/resources/file_manager/js/media/video_player_scripts.js	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/resources/file_manager/video_player.html	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

dgozman

8 years, 6 months ago (2012-06-18 15:17:11 UTC) #2

LGTM

https://chromiumcodereview.appspot.com/10568010/diff/1/chrome/browser/resourc...
File chrome/browser/resources/file_manager/js/image_editor/image_view.js
(right):

https://chromiumcodereview.appspot.com/10568010/diff/1/chrome/browser/resourc...
chrome/browser/resources/file_manager/js/image_editor/image_view.js:447: if
(ImageView.LOAD_TYPE_ERROR && !navigator.onLine && metadata.streaming) {
|loadType == ImageView.LOAD_TYPE_ERROR| probably

Expand Messages | Collapse Messages