[Chromoting] ChromotingHost may impose a maximum session duration.

This CL sets a maximum session duration only for Linux Me2Me, and hard-codes it to 12 hours.

A follow-up CL will get the maximum session duration from a
policy.

BUG=132678
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=143767

[simonmorris, 2012-06-22 16:55:10]

ptal

[Jamie, 2012-06-22 17:10:24]

On 2012/06/22 16:55:10, simonmorris wrote:
> ptal

I think we'd been asked to make this default to 20 hours to match various other
time-outs.

[simonmorris, 2012-06-22 17:41:26]

On 2012/06/22 17:10:24, Jamie wrote:
> On 2012/06/22 16:55:10, simonmorris wrote:
> > ptal
> 
> I think we'd been asked to make this default to 20 hours to match various
other
> time-outs.

Done.

[Wez, 2012-06-22 18:52:21]

http://codereview.chromium.org/10629016/diff/4001/remoting/host/chromoting_ho...
File remoting/host/chromoting_host.h (right):

http://codereview.chromium.org/10629016/diff/4001/remoting/host/chromoting_ho...
remoting/host/chromoting_host.h:75: long max_session_duration_seconds);
nit: Use a TimeDelta for this?

http://codereview.chromium.org/10629016/diff/4001/remoting/host/chromoting_ho...
remoting/host/chromoting_host.h:75: long max_session_duration_seconds);
I think this would make more sense as a SetMaximumSessionDuration() API, akin to
SetAuthenticatorFactory(), with no maximum duration by default.

http://codereview.chromium.org/10629016/diff/4001/remoting/host/client_session.h
File remoting/host/client_session.h (right):

http://codereview.chromium.org/10629016/diff/4001/remoting/host/client_sessio...
remoting/host/client_session.h:72: long max_duration_seconds);
nit: Again, I'd move this to a SetMaximumSessionDuration() method, akin to
SetDisableInputs()

http://codereview.chromium.org/10629016/diff/4001/remoting/host/client_sessio...
remoting/host/client_session.h:72: long max_duration_seconds);
nit: Use a TimeDelta?

http://codereview.chromium.org/10629016/diff/4001/remoting/host/client_sessio...
remoting/host/client_session.h:178: base::OneShotTimer<ClientSession>
disconnect_timer_;
nit: max_session_duration_timer_?

http://codereview.chromium.org/10629016/diff/4001/remoting/host/remoting_me2m...
File remoting/host/remoting_me2me_host.cc (right):

http://codereview.chromium.org/10629016/diff/4001/remoting/host/remoting_me2m...
remoting/host/remoting_me2me_host.cc:389: long max_session_duration_seconds =
nit: May as well put the variable definition in the #if... block to make it
easier to read.

http://codereview.chromium.org/10629016/diff/4001/remoting/host/remoting_me2m...
remoting/host/remoting_me2me_host.cc:400: max_session_duration_seconds);
Indentation.

http://codereview.chromium.org/10629016/diff/4001/remoting/host/simple_host_p...
File remoting/host/simple_host_process.cc (right):

http://codereview.chromium.org/10629016/diff/4001/remoting/host/simple_host_p...
remoting/host/simple_host_process.cc:240:
context_.url_request_context_getter()), 0);
Wrap the 0 to the next line.

[simonmorris, 2012-06-22 20:17:23]

http://codereview.chromium.org/10629016/diff/4001/remoting/host/chromoting_ho...
File remoting/host/chromoting_host.h (right):

http://codereview.chromium.org/10629016/diff/4001/remoting/host/chromoting_ho...
remoting/host/chromoting_host.h:75: long max_session_duration_seconds);
On 2012/06/22 18:52:21, Wez wrote:
> nit: Use a TimeDelta for this?

Done.

http://codereview.chromium.org/10629016/diff/4001/remoting/host/chromoting_ho...
remoting/host/chromoting_host.h:75: long max_session_duration_seconds);
On 2012/06/22 18:52:21, Wez wrote:
> I think this would make more sense as a SetMaximumSessionDuration() API, akin
to
> SetAuthenticatorFactory(), with no maximum duration by default.

Done.

http://codereview.chromium.org/10629016/diff/4001/remoting/host/client_session.h
File remoting/host/client_session.h (right):

http://codereview.chromium.org/10629016/diff/4001/remoting/host/client_sessio...
remoting/host/client_session.h:72: long max_duration_seconds);
On 2012/06/22 18:52:21, Wez wrote:
> nit: Use a TimeDelta?

Done.

http://codereview.chromium.org/10629016/diff/4001/remoting/host/client_sessio...
remoting/host/client_session.h:72: long max_duration_seconds);
On 2012/06/22 18:52:21, Wez wrote:
> nit: Again, I'd move this to a SetMaximumSessionDuration() method, akin to
> SetDisableInputs()

This would make the implementation more complex, without much benefit. What
would happen if the maximum were decreased while a session was in progress?

http://codereview.chromium.org/10629016/diff/4001/remoting/host/client_sessio...
remoting/host/client_session.h:178: base::OneShotTimer<ClientSession>
disconnect_timer_;
On 2012/06/22 18:52:21, Wez wrote:
> nit: max_session_duration_timer_?

Changed.

http://codereview.chromium.org/10629016/diff/4001/remoting/host/remoting_me2m...
File remoting/host/remoting_me2me_host.cc (right):

http://codereview.chromium.org/10629016/diff/4001/remoting/host/remoting_me2m...
remoting/host/remoting_me2me_host.cc:389: long max_session_duration_seconds =
On 2012/06/22 18:52:21, Wez wrote:
> nit: May as well put the variable definition in the #if... block to make it
> easier to read.

Done.

http://codereview.chromium.org/10629016/diff/4001/remoting/host/remoting_me2m...
remoting/host/remoting_me2me_host.cc:400: max_session_duration_seconds);
On 2012/06/22 18:52:21, Wez wrote:
> Indentation.

Removed.

http://codereview.chromium.org/10629016/diff/4001/remoting/host/simple_host_p...
File remoting/host/simple_host_process.cc (right):

http://codereview.chromium.org/10629016/diff/4001/remoting/host/simple_host_p...
remoting/host/simple_host_process.cc:240:
context_.url_request_context_getter()), 0);
On 2012/06/22 18:52:21, Wez wrote:
> Wrap the 0 to the next line.

Removed.

[Wez, 2012-06-22 23:49:17]

LGTM!

http://codereview.chromium.org/10629016/diff/4001/remoting/host/client_session.h
File remoting/host/client_session.h (right):

http://codereview.chromium.org/10629016/diff/4001/remoting/host/client_sessio...
remoting/host/client_session.h:72: long max_duration_seconds);
On 2012/06/22 20:17:23, simonmorris wrote:
> On 2012/06/22 18:52:21, Wez wrote:
> > nit: Again, I'd move this to a SetMaximumSessionDuration() method, akin to
> > SetDisableInputs()
> 
> This would make the implementation more complex, without much benefit. What
> would happen if the maximum were decreased while a session was in progress?

The only benefit would be that callers not interested in a session duration
limit (e.g. unit-tests) wouldn't need to pass the parameter.  Since the duration
is only applied from the point that authentication completes, a DCHECK for
!is_authenticated would protect against attempts to change the duration after
the session has begun.

http://codereview.chromium.org/10629016/diff/10001/remoting/host/client_sessi...
File remoting/host/client_session.cc (right):

http://codereview.chromium.org/10629016/diff/10001/remoting/host/client_sessi...
remoting/host/client_session.cc:107: this, &ClientSession::Disconnect);
nit: Indentation.

[simonmorris, 2012-06-22 23:54:03]

fyi

http://codereview.chromium.org/10629016/diff/10001/remoting/host/client_sessi...
File remoting/host/client_session.cc (right):

http://codereview.chromium.org/10629016/diff/10001/remoting/host/client_sessi...
remoting/host/client_session.cc:107: this, &ClientSession::Disconnect);
On 2012/06/22 23:49:18, Wez wrote:
> nit: Indentation.

Done.

[commit-bot: I haz the power, 2012-06-22 23:54:52]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/10629016/20001

[commit-bot: I haz the power, 2012-06-23 01:05:15]

Change committed as 143767