Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(489)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10642014: grd file update for new 2x assets (Closed)

Created:
8 years, 6 months ago by Nico
Modified:
8 years, 6 months ago
Reviewers:
Avi (use Gerrit), benrg, sky
CC:
chromium-reviews, oshima+watch_chromium.org, flackr, Avi (use Gerrit)
Visibility:
Public.

Description

grd file update for new 2x assets The grd changes were made by http://pastie.org/4132407 (and then cleaned up manually). BUG=132910 TEST=Look at various icons (blocked plugins, "press tab to search", etc) TBR=sky Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=143605

Patch Set 1 #

Patch Set 2 : manual cleanups #

Patch Set 3 : builds on mac #

Patch Set 4 : . #

Total comments: 1

Patch Set 5 : gtk #

Patch Set 6 : views cros #

Patch Set 7 : . #

Patch Set 8 : . #

Patch Set 9 : . #

Patch Set 10 : . #

Patch Set 11 : . #

Patch Set 12 : . #

Patch Set 13 : cros #

Patch Set 14 : mac search hint #

Unified diffs Side-by-side diffs Delta from patch set Stats (+167 lines, -155 lines) Patch
M chrome/app/theme/theme_resources.grd View 1 2 8 chunks +0 lines, -102 lines 0 comments Download
M chrome/app/theme/theme_resources_standard.grd View 1 2 11 chunks +104 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_browser_notifications.cc View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/options/network_config_view.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/cookies_tree_model.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/download/download_util.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/app_shortcut_manager.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_disabled_ui.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_icon_manager.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_install_prompt.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_uninstall_dialog.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/page_info_model.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/protector/default_search_provider_change.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/protector/homepage_change.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/protector/prefs_backup_invalid_change.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/protector/session_startup_change.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/speech/speech_recognition_bubble.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/speech/speech_recognition_tray_icon_controller.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_menu_bridge.mm View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/browser/edit_search_engine_cocoa_controller.mm View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/browser/edit_search_engine_cocoa_controller_unittest.mm View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/content_settings/collected_cookies_mac.mm View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/download/download_item_controller.mm View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/download/download_started_animation_mac.mm View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/extensions/browser_action_button.mm View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/history_overlay_controller.mm View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/hung_renderer_controller.mm View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/infobars/extension_infobar_controller.mm View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/location_bar/keyword_hint_decoration.mm View 1 2 3 4 5 6 7 8 9 10 11 12 13 2 chunks +3 lines, -5 lines 0 comments Download
M chrome/browser/ui/cocoa/speech_recognition_window_controller.mm View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/tab_contents/sad_tab_view.mm View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/create_application_shortcuts_dialog_gtk.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/download/download_item_gtk.cc View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/gtk/download/download_started_animation_gtk.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/edit_search_engine_dialog.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/hung_renderer_dialog_gtk.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/infobars/extension_infobar_gtk.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/sad_tab_gtk.cc View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/gtk/speech_recognition_bubble_gtk.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/intents/web_intent_picker.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/intents/web_intent_picker_unittest.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/panels/panel_browser_titlebar_gtk.cc View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/toolbar/wrench_menu_model.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/views/about_chrome_view.cc View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_menu_delegate.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/collected_cookies_views.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/create_application_shortcut_view.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/critical_notification_bubble_view.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/download/download_item_view.cc View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/views/download/download_started_animation_views.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/edit_search_engine_dialog.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/hung_renderer_view.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/infobars/extension_infobar.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/location_bar/keyword_hint_view.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/sad_tab_view.cc View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/views/speech_recognition_bubble_views.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/website_settings_popup_view.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/wrench_menu.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/extensions/extension_icon_source.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/upgrade_detector.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/extension.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Nico
https://chromiumcodereview.appspot.com/10642014/diff/6003/chrome/app/theme/theme_resources_standard.grd File chrome/app/theme/theme_resources_standard.grd (right): https://chromiumcodereview.appspot.com/10642014/diff/6003/chrome/app/theme/theme_resources_standard.grd#newcode49 chrome/app/theme/theme_resources_standard.grd:49: <structure type="chrome_scaled_image" name="IDR_BOOKMARK_BAR_FOLDER" file="bookmark_bar_folder.png" /> The non-mac version of ...
8 years, 6 months ago (2012-06-22 13:54:33 UTC) #1
Nico
Forgot to say: The grd changes were made by http://pastie.org/4132407 , I cleaned them up ...
8 years, 6 months ago (2012-06-22 13:55:36 UTC) #2
Avi (use Gerrit)
lgtm
8 years, 6 months ago (2012-06-22 16:21:57 UTC) #3
Nico
sky: OWNERS
8 years, 6 months ago (2012-06-22 16:28:01 UTC) #4
sky
8 years, 6 months ago (2012-06-22 17:07:35 UTC) #5 
LGTM

Powered by Google App Engine
This is Rietveld 408576698