Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(461)

Issue 10663039: Add Java function to retrieve the native library dir. (Closed)

Created:
8 years, 6 months ago by aurimas (slooooooooow)
Modified:
8 years, 5 months ago
CC:
chromium-reviews, erikwright (departed), brettw-cc_chromium.org
Visibility:
Public.

Description

Add Java function to retrieve the native library dir. Upstreaming the Change with change-id: I94aa26a6e421ec8310f351a410b9083d49eb90f4 made by Ben Murdoch ([email protected]) BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=145179

Patch Set 1 #

Total comments: 1

Patch Set 2 : Rebase to the latest revision #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -2 lines) Patch
M base/android/java/src/org/chromium/base/PathUtils.java View 1 2 chunks +15 lines, -0 lines 0 comments Download
M base/android/path_utils.h View 1 chunk +4 lines, -0 lines 0 comments Download
M base/android/path_utils.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M base/android/path_utils_unittest.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M base/base_paths_android.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
aurimas_google.com
Hello Jay, I'm making my first upstream CL. It is just adding one method to ...
8 years, 6 months ago (2012-06-26 17:08:07 UTC) #1
jcivelli
lgtm
8 years, 6 months ago (2012-06-26 17:24:51 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/10663039/1
8 years, 6 months ago (2012-06-26 18:42:21 UTC) #3
commit-bot: I haz the power
Presubmit check for 10663039-1 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 6 months ago (2012-06-26 18:42:26 UTC) #4
aurimas_google.com
Hello Guys, I am trying to upstream this one method addition from the downstream repo. ...
8 years, 6 months ago (2012-06-26 18:50:33 UTC) #5
aurimas (slooooooooow)
Hello Guys, I am trying to upstream this one method addition from the downstream repo. ...
8 years, 5 months ago (2012-07-02 18:07:13 UTC) #6
Mark Mentovai
https://chromiumcodereview.appspot.com/10663039/diff/1/base/base_paths_android.cc File base/base_paths_android.cc (right): https://chromiumcodereview.appspot.com/10663039/diff/1/base/base_paths_android.cc#newcode40 base/base_paths_android.cc:40: *result = FilePath(base::android::GetNativeLibraryDirectory()); LGTM
8 years, 5 months ago (2012-07-02 18:10:16 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/10663039/1
8 years, 5 months ago (2012-07-02 18:18:33 UTC) #8
commit-bot: I haz the power
Failed to apply patch for base/android/java/org/chromium/base/PathUtils.java: While running patch -p1 --forward --force; patching file base/android/java/org/chromium/base/PathUtils.java ...
8 years, 5 months ago (2012-07-02 18:18:35 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/10663039/11001
8 years, 5 months ago (2012-07-02 18:32:49 UTC) #10
commit-bot: I haz the power
8 years, 5 months ago (2012-07-02 20:04:05 UTC) #11
Change committed as 145179

Powered by Google App Engine
This is Rietveld 408576698