Issue 10683005: Remove two deprecated methods from base::Version

Issue 10683005: Remove two deprecated methods from base::Version (Closed)

Created:
8 years, 6 months ago by Ilya Sherman

Modified:
8 years, 5 months ago

Reviewers:
brettw, sky

CC:
chromium-reviews, mihaip-chromium-reviews_chromium.org, jochen+watch-content_chromium.org, erikwright (departed), jam, joi+watch-content_chromium.org, Aaron Boodman, darin-cc_chromium.org, brettw-cc_chromium.org, stuartmorgan+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Remove two deprecated methods from base::Version BUG=none TEST=none [email protected] Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=146157

Patch Set 1 #

Patch Set 2 : Fix Windows and Linux compile errors #

Patch Set 3 : Fix more Windows compile errors #

Patch Set 4 : More Windows fixes... #

Patch Set 5 : More Windows unit test compile fixes... #

Patch Set 6 : More clone removals #

Patch Set 7 : All greeeen #

Patch Set 8 : ... #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+376 lines, -427 lines)			Patch
M	base/version.h	View		1 chunk	+0 lines, -9 lines	0 comments	Download
M	base/version.cc	View		1 chunk	+0 lines, -16 lines	0 comments	Download
M	base/version_unittest.cc	View		2 chunks	+10 lines, -11 lines	0 comments	Download
M	chrome/app/client_util.cc	View	1 2 3	2 chunks	+8 lines, -8 lines	0 comments	Download
M	chrome/browser/chrome_browser_main_win.cc	View	1	1 chunk	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/enumerate_modules_model_win.cc	View	1 2 3	1 chunk	+10 lines, -13 lines	0 comments	Download
M	chrome/browser/extensions/api/webstore_private/webstore_private_apitest.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/extensions/crx_installer.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/crx_installer.cc	View		1 chunk	+2 lines, -3 lines	0 comments	Download
M	chrome/browser/extensions/extension_service_unittest.cc	View		25 chunks	+36 lines, -48 lines	0 comments	Download
M	chrome/browser/extensions/external_extension_provider_impl.cc	View		2 chunks	+4 lines, -5 lines	0 comments	Download
M	chrome/browser/extensions/external_registry_extension_loader_win.cc	View	1 2 3	1 chunk	+2 lines, -4 lines	0 comments	Download
M	chrome/browser/extensions/updater/extension_updater_unittest.cc	View		2 chunks	+3 lines, -4 lines	0 comments	Download
M	chrome/browser/extensions/user_script_master.cc	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/first_run/upgrade_util_win.cc	View	1 2 3	1 chunk	+4 lines, -6 lines	0 comments	Download
M	chrome/browser/gpu_blacklist.cc	View		6 chunks	+21 lines, -20 lines	0 comments	Download
M	chrome/browser/gpu_blacklist_unittest.cc	View		31 chunks	+67 lines, -68 lines	0 comments	Download
M	chrome/browser/gpu_util.cc	View	1 2 3	1 chunk	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/hang_monitor/hung_plugin_action.cc	View		1 chunk	+5 lines, -5 lines	0 comments	Download
M	chrome/browser/plugin_installer.cc	View		1 chunk	+5 lines, -5 lines	0 comments	Download
M	chrome/browser/ui/views/about_chrome_view.cc	View	1	1 chunk	+7 lines, -8 lines	0 comments	Download
M	chrome/browser/upgrade_detector_impl.cc	View	1	4 chunks	+16 lines, -19 lines	0 comments	Download
M	chrome/common/extensions/extension.cc	View		3 chunks	+7 lines, -9 lines	0 comments	Download
M	chrome/common/extensions/update_manifest.cc	View		2 chunks	+4 lines, -5 lines	0 comments	Download
M	chrome/common/service_process_util.cc	View	1	2 chunks	+6 lines, -7 lines	0 comments	Download
M	chrome/common/service_process_util_mac.mm	View		1 chunk	+7 lines, -8 lines	0 comments	Download
M	chrome/installer/setup/install_worker_unittest.cc	View	1 2 3 4 5 6	6 chunks	+7 lines, -7 lines	0 comments	Download
M	chrome/installer/setup/setup_main.cc	View	1	1 chunk	+4 lines, -4 lines	0 comments	Download
M	chrome/installer/setup/setup_util.cc	View	1 2 3	2 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/installer/util/google_update_settings_unittest.cc	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/installer/util/install_util.h	View	1	1 chunk	+13 lines, -10 lines	0 comments	Download
M	chrome/installer/util/install_util.cc	View	1 2	4 chunks	+14 lines, -15 lines	0 comments	Download
M	chrome/installer/util/installation_state.cc	View	1 2	3 chunks	+8 lines, -5 lines	0 comments	Download
M	chrome/installer/util/installation_validator_unittest.cc	View	1 2 3	1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/installer/util/installer_state.cc	View	1 2	3 chunks	+6 lines, -6 lines	0 comments	Download
M	chrome/installer/util/installer_state_unittest.cc	View	1 2 3 4	8 chunks	+22 lines, -28 lines	0 comments	Download
M	chrome/installer/util/product_unittest.cc	View	1 2 3	2 chunks	+3 lines, -4 lines	0 comments	Download
M	chrome/test/mini_installer_test/installer_test_util.cc	View	1	1 chunk	+4 lines, -4 lines	0 comments	Download
M	chrome_frame/dll_redirector.cc	View	1 2 3 4 5 6 7	2 chunks	+8 lines, -7 lines	0 comments	Download
M	chrome_frame/test/dll_redirector_loading_test.cc	View	1 2 3	3 chunks	+9 lines, -9 lines	0 comments	Download
M	chrome_frame/test/dll_redirector_test.cc	View	1 2 3 4 5 6 7	6 chunks	+13 lines, -10 lines	0 comments	Download
M	chrome_frame/test/test_with_web_server.cc	View	1	1 chunk	+7 lines, -5 lines	0 comments	Download
M	content/browser/plugin_data_remover_impl.cc	View		1 chunk	+4 lines, -5 lines	0 comments	Download
M	webkit/plugins/npapi/plugin_group.h	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	webkit/plugins/npapi/plugin_group.cc	View		2 chunks	+3 lines, -2 lines	0 comments	Download
M	webkit/plugins/npapi/plugin_group_unittest.cc	View		1 chunk	+4 lines, -3 lines	0 comments	Download
M	webkit/plugins/npapi/webplugin_delegate_impl_win.cc	View		1 chunk	+6 lines, -5 lines	0 comments	Download