Issue 10690144: Set the Feature's ChannelForTesting to Trunk during ActiveTabTest.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10690144: Set the Feature's ChannelForTesting to Trunk during ActiveTabTest. (Closed)

Created:
8 years, 5 months ago by Matt Perry

Modified:
8 years, 5 months ago

Reviewers:
Aaron Boodman

CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Set the Feature's ChannelForTesting to Trunk during ActiveTabTest. BUG=136629 TEST=no [email protected] Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=146213

Patch Set 1 #

Patch Set 2 : runtime fix #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -2 lines)			Patch
M	chrome/browser/extensions/active_tab_unittest.cc	View		2 chunks	+4 lines, -1 line	0 comments	Download
M	chrome/browser/extensions/extension_service.cc	View	1	2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/common/extensions/features/feature.h	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/common/extensions/features/feature.cc	View	1	1 chunk	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Matt Perry

8 years, 5 months ago (2012-07-11 21:05:50 UTC) #2

I also changed ExtensionService to pass the Feature's channel (so we use the
ChannelForTesting) to the renderer. This exposes the 'runtime' API based on the
Feature's channel.

Expand Messages | Collapse Messages