Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Issue 10695008: Link against gabi++ when building with the Android build system (Closed)

Created:
8 years, 5 months ago by Steve Block
Modified:
8 years, 5 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, jochen+watch-content_chromium.org
Visibility:
Public.

Description

Link against gabi++ when building with the Android build system When building with the NDK, RTTI is provided by stlport, but when building with the Android build system, it is provided by gabi++. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=144470

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M content/content_shell.gypi View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Steve Block
8 years, 5 months ago (2012-06-27 14:34:45 UTC) #1
digit1
lgtm
8 years, 5 months ago (2012-06-27 14:58:41 UTC) #2
Steve Block
+avi for OWNERS
8 years, 5 months ago (2012-06-27 14:59:46 UTC) #3
Avi (use Gerrit)
lgtm stamp
8 years, 5 months ago (2012-06-27 15:04:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/10695008/1
8 years, 5 months ago (2012-06-27 15:10:00 UTC) #5
commit-bot: I haz the power
8 years, 5 months ago (2012-06-27 17:09:49 UTC) #6
Change committed as 144470

Powered by Google App Engine
This is Rietveld 408576698