Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10696208: Move ExtensionEventRouter and related into extensions namespace (Closed)

Created:
8 years, 5 months ago by Devlin
Modified:
8 years, 5 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, mihaip-chromium-reviews_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org, hashimoto+watch_chromium.org, aboxhall+watch_chromium.org, yoshiki+watch_chromium.org, yuzo+watch_chromium.org, davidbarr+watch_chromium.org, Aaron Boodman, rginda+watch_chromium.org, Satish, yusukes+watch_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, brettw-cc_chromium.org, darin-cc_chromium.org, ctguil+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, zork+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Move ExtensionEventRouter and related into extensions namespace Moved ExtensionEventRouter, ExtensionEventRouterForwarder, ExtensionBrowserEventRouter into extensions namespace and renamed them appropriately. Also some header file gardening. BUG=137115, 117261 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=147984

Patch Set 1 : #

Patch Set 2 : Latest master for cq #

Patch Set 3 : Fixed bug + latest master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+734 lines, -3259 lines) Patch
M chrome/browser/accessibility/accessibility_extension_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/bookmarks/bookmark_extension_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/bookmarks/bookmark_manager_extension_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/browser_process.h View 3 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/browser_process_impl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/browser_process_impl.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/extensions/bluetooth_event_router.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_browser_event_router.cc View 1 8 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_handler_util.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/extensions/input_method_event_router.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/extensions/media_player_event_router.cc View 1 chunk +1 line, -1 line 0 comments Download
chrome/browser/extensions/api/alarms/alarm_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/api_resource_event_notifier.h View 1 4 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/api_resource_event_notifier.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/app/app_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/context_menu/context_menu_apitest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/cookies/cookies_api.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/debugger/debugger_api.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/downloads/downloads_api.cc View 4 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/extensions/api/downloads/downloads_api_unittest.cc View 1 24 chunks +29 lines, -27 lines 0 comments Download
M chrome/browser/extensions/api/extension_action/browser_action_apitest.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/extension_action/page_action_apitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/extension_action/page_as_browser_action_apitest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/extension_action/script_badge_apitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/managed_mode/managed_mode_api.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/offscreen_tabs/offscreen_tabs_api.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/omnibox/omnibox_api.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/proxy/proxy_api.h View 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/extensions/api/proxy/proxy_api.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/runtime/runtime_api.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/terminal/terminal_private_api.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/web_navigation/web_navigation_api.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/api/web_navigation/web_navigation_api_helpers.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/web_request/web_request_api.cc View 1 3 chunks +5 lines, -4 lines 0 comments Download
chrome/browser/extensions/api/web_request/web_request_api_unittest.cc View 5 chunks +5 lines, -5 lines 0 comments Download
A + chrome/browser/extensions/browser_event_router.h View 5 chunks +14 lines, -10 lines 0 comments Download
A + chrome/browser/extensions/browser_event_router.cc View 1 33 chunks +82 lines, -93 lines 0 comments Download
M chrome/browser/extensions/event_listener_map.h View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/extensions/event_listener_map.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/event_listener_map_unittest.cc View 1 12 chunks +22 lines, -18 lines 0 comments Download
A + chrome/browser/extensions/event_names.h View 2 chunks +9 lines, -5 lines 0 comments Download
A + chrome/browser/extensions/event_names.cc View 2 chunks +7 lines, -3 lines 0 comments Download
A + chrome/browser/extensions/event_router.h View 7 chunks +75 lines, -86 lines 0 comments Download
A + chrome/browser/extensions/event_router.cc View 1 27 chunks +151 lines, -175 lines 0 comments Download
A + chrome/browser/extensions/event_router_forwarder.h View 8 chunks +26 lines, -22 lines 0 comments Download
A + chrome/browser/extensions/event_router_forwarder.cc View 7 chunks +29 lines, -28 lines 0 comments Download
A + chrome/browser/extensions/event_router_forwarder_unittest.cc View 4 chunks +71 lines, -70 lines 0 comments Download
D chrome/browser/extensions/extension_browser_event_router.h View 1 chunk +0 lines, -242 lines 0 comments Download
D chrome/browser/extensions/extension_browser_event_router.cc View 1 1 chunk +0 lines, -712 lines 0 comments Download
chrome/browser/extensions/extension_devtools_bridge.cc View 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/extensions/extension_event_names.h View 1 chunk +0 lines, -75 lines 0 comments Download
D chrome/browser/extensions/extension_event_names.cc View 1 chunk +0 lines, -67 lines 0 comments Download
D chrome/browser/extensions/extension_event_router.h View 1 chunk +0 lines, -295 lines 0 comments Download
D chrome/browser/extensions/extension_event_router.cc View 1 1 chunk +0 lines, -628 lines 0 comments Download
D chrome/browser/extensions/extension_event_router_forwarder.h View 1 chunk +0 lines, -100 lines 0 comments Download
D chrome/browser/extensions/extension_event_router_forwarder.cc View 1 chunk +0 lines, -125 lines 0 comments Download
D chrome/browser/extensions/extension_event_router_forwarder_unittest.cc View 1 chunk +0 lines, -259 lines 0 comments Download
M chrome/browser/extensions/extension_font_settings_api.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_host.cc View 1 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_idle_api.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_input_ime_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_management_api.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_messages_apitest.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/extensions/extension_preference_api.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_preference_helpers.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_process_manager.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_processes_api.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_service.h View 1 5 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_service.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_system.h View 1 6 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/extensions/extension_system.cc View 1 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/extensions/extension_toolbar_model.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/lazy_background_page_apitest.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/menu_manager.cc View 3 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/extensions/menu_manager_unittest.cc View 1 2 5 chunks +14 lines, -14 lines 0 comments Download
M chrome/browser/extensions/page_action_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/permissions_updater.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/script_badge_controller.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/settings/settings_frontend.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/settings/settings_test_util.h View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/extensions/settings/settings_test_util.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/system/system_api.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/test_extension_system.h View 1 1 chunk +1 line, -1 line 0 comments Download
chrome/browser/extensions/test_extension_system.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/history/history_extension_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/io_thread.h View 5 chunks +9 lines, -6 lines 0 comments Download
M chrome/browser/io_thread.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/net/chrome_network_delegate.h View 3 chunks +6 lines, -3 lines 0 comments Download
M chrome/browser/net/chrome_network_delegate.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/profiles/off_the_record_profile_impl.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/profiles/off_the_record_profile_impl.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/profiles/profile.h View 1 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/profiles/profile_impl.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/profiles/profile_impl.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/profiles/profile_manager_unittest.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
chrome/browser/renderer_host/chrome_render_message_filter.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/speech/extension_api/tts_engine_extension_api.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/speech/extension_api/tts_extension_api_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/speech/speech_input_extension_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/extensions/browser_actions_controller.mm View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/location_bar/page_action_decoration.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/gtk/browser_actions_toolbar_gtk.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/gtk/extensions/extension_keybinding_registry_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/location_bar_view_gtk.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/extensions/extension_keybinding_registry_views.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/location_bar/location_bar_view.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/location_bar/page_action_image_view.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/chrome_browser_extensions.gypi View 1 3 chunks +8 lines, -8 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/base/testing_browser_process.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/base/testing_browser_process.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/base/testing_profile.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/base/testing_profile.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (0 generated)
Devlin
Please review when you get a chance: sky - c/b/ui, c/b/bookmarks, c/b/history battre - c/b/net ...
8 years, 5 months ago (2012-07-17 20:03:56 UTC) #1
battre
LGTM for c/b/net
8 years, 5 months ago (2012-07-17 21:01:02 UTC) #2
sky
LGTM
8 years, 5 months ago (2012-07-17 22:29:16 UTC) #3
Mihai Parparita -not on Chrome
LGTM
8 years, 5 months ago (2012-07-20 06:00:06 UTC) #4
Miranda Callahan
On 2012/07/20 06:00:06, Mihai Parparita wrote: > LGTM profiles/* LGTM
8 years, 5 months ago (2012-07-20 08:14:24 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/10696208/7002
8 years, 5 months ago (2012-07-23 17:20:16 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/10696208/16001
8 years, 5 months ago (2012-07-23 18:11:20 UTC) #7
commit-bot: I haz the power
Failed to apply patch for tools/emacs/trybot-mac.txt: While running patch -p1 --forward --force; patching file tools/emacs/trybot-mac.txt ...
8 years, 5 months ago (2012-07-23 18:12:09 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/10696208/11049
8 years, 5 months ago (2012-07-23 18:19:10 UTC) #9
commit-bot: I haz the power
Try job failure for 10696208-11049 (retry) on linux_rel for step "unit_tests". It's a second try, ...
8 years, 5 months ago (2012-07-23 19:05:00 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/10696208/13004
8 years, 5 months ago (2012-07-23 21:29:50 UTC) #11
commit-bot: I haz the power
8 years, 5 months ago (2012-07-23 23:22:16 UTC) #12 
Change committed as 147984

Powered by Google App Engine
This is Rietveld 408576698