Issue 10702010: Roll ANGLE 1046:1168.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10702010: Roll ANGLE 1046:1168. (Closed)

Created:
8 years, 5 months ago by apatrick_chromium

Modified:
8 years, 5 months ago

Reviewers:
Zhenyao Mo

CC:
chromium-reviews, apatrick_chromium

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Roll ANGLE 1046:1168. Suppressed regressing WebGL conformance tests. Removed check for alpha==1 for a depth texture because I think GL_ANGLE_depth_texture is specified such that this is not expected. The roll causes the image transport to be flipped. Compensated in AcceleratedSurface. BUG=134743 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=144776

Patch Set 1 #

Total comments: 1

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+6 lines, -4 lines)			Patch
M	DEPS	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/test/gpu/webgl_conformance_test_expectations.txt	View	2 chunks	+4 lines, -1 line	1 comment	Download
M	gpu/command_buffer/tests/gl_depth_texture_unittest.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	ui/surface/accelerated_surface_win.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Zhenyao Mo

8 years, 5 months ago (2012-06-28 18:14:42 UTC) #2

LGTM

https://chromiumcodereview.appspot.com/10702010/diff/1/chrome/test/gpu/webgl_...
File chrome/test/gpu/webgl_conformance_test_expectations.txt (right):

https://chromiumcodereview.appspot.com/10702010/diff/1/chrome/test/gpu/webgl_...
chrome/test/gpu/webgl_conformance_test_expectations.txt:27: 134743 MAC WIN LINUX
: conformance_ogles_GL_build_build_081_to_088 = FAIL
It's weird you still see the ogles failures , because from the next two lines,
you see conformance_ogles_* is SKIPed.

Are you sure you need them?

Expand Messages | Collapse Messages