Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 10703142: Move WebstoreInstaller, WebstoreInlineInstaller, related in extensions namespace (Closed)

Created:
8 years, 5 months ago by Devlin
Modified:
8 years, 5 months ago
Reviewers:
Matt Perry, binji
CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org, rdsmith+dwatch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Move WebstoreInstaller, WebstoreInlineInstaller, related in extensions namespace BUG=136833, 117261 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=146407

Patch Set 1 #

Patch Set 2 : Latest merge with master for cq #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -34 lines) Patch
M chrome/browser/download/chrome_download_manager_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/download/download_crx_util.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/crx_installer.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/crx_installer.cc View 1 1 chunk +5 lines, -4 lines 0 comments Download
M chrome/browser/extensions/crx_installer_browsertest.cc View 1 chunk +6 lines, -5 lines 0 comments Download
M chrome/browser/extensions/extension_tab_helper.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_tab_helper.cc View 1 chunk +8 lines, -7 lines 0 comments Download
M chrome/browser/extensions/webstore_inline_installer.h View 1 2 chunks +7 lines, -6 lines 0 comments Download
M chrome/browser/extensions/webstore_inline_installer.cc View 3 chunks +5 lines, -1 line 0 comments Download
M chrome/browser/extensions/webstore_inline_installer_unittest.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/extensions/webstore_install_helper.h View 1 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/extensions/webstore_install_helper.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/extensions/webstore_installer.h View 1 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/extensions/webstore_installer.cc View 3 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/ui/intents/web_intent_picker_controller.h View 1 2 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/ui/intents/web_intent_picker_controller.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Devlin
Please review when time allows: binji: c/b/ui/intents mpcomplete: c/b/extensions Thanks in advance.
8 years, 5 months ago (2012-07-11 22:28:23 UTC) #1
Matt Perry
lgtm
8 years, 5 months ago (2012-07-11 23:47:49 UTC) #2
Matt Perry
lgtm lgtm
8 years, 5 months ago (2012-07-11 23:47:49 UTC) #3
binji
intents lgtm
8 years, 5 months ago (2012-07-12 17:18:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/10703142/4002
8 years, 5 months ago (2012-07-12 17:41:28 UTC) #5
commit-bot: I haz the power
8 years, 5 months ago (2012-07-12 19:11:26 UTC) #6
Change committed as 146407

Powered by Google App Engine
This is Rietveld 408576698