Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(729)

Issue 10704121: Make all gtest targets into bundles on iOS (Closed)

Created:
8 years, 5 months ago by stuartmorgan
Modified:
8 years, 5 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Make all gtest targets into bundles on iOS The raw 'executable' type maps to the .tool Apple product-type, which doesn't exist on iOS. Make each unit test a bundle instead. BUG=None TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=145671

Patch Set 1 #

Patch Set 2 : Fix key ordering #

Total comments: 2

Patch Set 3 : Add line break #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -8 lines) Patch
M testing/gtest.gyp View 1 2 3 chunks +40 lines, -1 line 0 comments Download
A + testing/gtest_ios/unittest-Info.plist View 1 2 chunks +11 lines, -7 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
stuartmorgan
8 years, 5 months ago (2012-07-09 12:30:13 UTC) #1
Mark Mentovai
LGTM https://chromiumcodereview.appspot.com/10704121/diff/2001/testing/gtest.gyp File testing/gtest.gyp (right): https://chromiumcodereview.appspot.com/10704121/diff/2001/testing/gtest.gyp#newcode80 testing/gtest.gyp:80: 'BUNDLE_ID_TEST_NAME': '>!(echo ">(_target_name)" | sed -e "s/_//g")', Break ...
8 years, 5 months ago (2012-07-09 12:41:53 UTC) #2
stuartmorgan
http://codereview.chromium.org/10704121/diff/2001/testing/gtest.gyp File testing/gtest.gyp (right): http://codereview.chromium.org/10704121/diff/2001/testing/gtest.gyp#newcode80 testing/gtest.gyp:80: 'BUNDLE_ID_TEST_NAME': '>!(echo ">(_target_name)" | sed -e "s/_//g")', On 2012/07/09 ...
8 years, 5 months ago (2012-07-09 13:01:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/10704121/7001
8 years, 5 months ago (2012-07-09 13:01:49 UTC) #4
Mark Mentovai
LGTM
8 years, 5 months ago (2012-07-09 13:01:53 UTC) #5
commit-bot: I haz the power
8 years, 5 months ago (2012-07-09 14:41:16 UTC) #6
Change committed as 145671

Powered by Google App Engine
This is Rietveld 408576698