Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(376)

Issue 10709004: Remove a few methods from WCD that aren't needed at this level. (Closed)

Created:
8 years, 5 months ago by Ben Goodger (Google)
Modified:
8 years, 5 months ago
Reviewers:
jam
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, jochen+watch-content_chromium.org
Visibility:
Public.

Description

Remove a few methods from WCD that aren't needed at this level. Also moves application creation off Browser. http://crbug.com/133576 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=144732

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -44 lines) Patch
M chrome/browser/ui/browser.h View 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/browser.cc View 2 chunks +0 lines, -24 lines 0 comments Download
M chrome/browser/ui/browser_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser_commands.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/browser_commands.cc View 2 chunks +23 lines, -0 lines 0 comments Download
M chrome/browser/ui/gtk/create_application_shortcuts_dialog_gtk.cc View 2 chunks +7 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/create_application_shortcut_view.cc View 2 chunks +7 lines, -4 lines 0 comments Download
M content/public/browser/web_contents_delegate.h View 2 chunks +0 lines, -9 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Ben Goodger (Google)
8 years, 5 months ago (2012-06-27 23:59:56 UTC) #1
jam
8 years, 5 months ago (2012-06-28 00:06:00 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698