Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10795056: Remove last references to profile->GetHistory() and profile->GetBookmarkModel() (Closed)

Created:
8 years, 5 months ago by rpetterson
Modified:
8 years, 4 months ago
Reviewers:
Elliot Glaysher, sky
CC:
chromium-reviews
Visibility:
Public.

Description

Remove last references to profile->GetHistory() and profile->GetBookmarkModel(). BUG=97804, 112525 TEST=existing unittests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150483

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : #

Patch Set 8 : #

Patch Set 9 : #

Patch Set 10 : #

Patch Set 11 : #

Patch Set 12 : #

Patch Set 13 : #

Patch Set 14 : #

Patch Set 15 : #

Patch Set 16 : #

Patch Set 17 : #

Patch Set 18 : #

Patch Set 19 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -91 lines) Patch
M chrome/browser/profiles/off_the_record_profile_impl.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/browser/profiles/off_the_record_profile_impl.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 2 chunks +0 lines, -17 lines 0 comments Download
M chrome/browser/profiles/profile.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 4 chunks +0 lines, -22 lines 0 comments Download
M chrome/browser/profiles/profile_impl.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/browser/profiles/profile_impl.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 5 chunks +0 lines, -22 lines 0 comments Download
M chrome/test/base/profile_mock.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/test/base/testing_profile.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/test/base/testing_profile.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 4 chunks +10 lines, -18 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
rpetterson
erg - profiles sky - test
8 years, 4 months ago (2012-08-07 18:22:25 UTC) #1
Elliot Glaysher
profiles lgtm
8 years, 4 months ago (2012-08-07 19:37:10 UTC) #2
sky
LGTM
8 years, 4 months ago (2012-08-07 20:32:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/10795056/25034
8 years, 4 months ago (2012-08-07 20:35:58 UTC) #4
commit-bot: I haz the power
Failed to apply patch for chrome/browser/profiles/profile.h: While running patch -p0 --forward --force; patching file chrome/browser/profiles/profile.h ...
8 years, 4 months ago (2012-08-07 22:02:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/10795056/34013
8 years, 4 months ago (2012-08-08 00:09:56 UTC) #6
commit-bot: I haz the power
Failed to apply patch for chrome/browser/profiles/profile.h: While running patch -p0 --forward --force; patching file chrome/browser/profiles/profile.h ...
8 years, 4 months ago (2012-08-08 00:09:58 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/10795056/15034
8 years, 4 months ago (2012-08-08 00:14:57 UTC) #8
commit-bot: I haz the power
Failed to apply patch for chrome/browser/profiles/profile_impl.h: While running patch -p0 --forward --force; patching file chrome/browser/profiles/profile_impl.h ...
8 years, 4 months ago (2012-08-08 00:14:59 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/10795056/18033
8 years, 4 months ago (2012-08-08 00:17:21 UTC) #10
commit-bot: I haz the power
8 years, 4 months ago (2012-08-08 02:02:56 UTC) #11 
Change committed as 150483

Powered by Google App Engine
This is Rietveld 408576698