Give MockRead and MockWrite distinct types.

Give MockRead and MockWrite distinct types.

Currently, MockRead and MockWrite are defined as the same type by using
typedef. However, these types are different types and should not be used
interchangably.

This change gives MockRead and MockWrite distinct types by using templates
so the compiler can cause an error when these types are used interchangably.
Some misuses of MockRead and MockWrite were found, so these are fixed in this
change, too.

BUG=none
[email protected],[email protected]


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148782

[mmenke, 2012-07-23 15:44:25]

Seems like a good idea to me.  LGTM.

http://codereview.chromium.org/10796085/diff/3002/net/socket/socket_test_util.h
File net/socket/socket_test_util.h (right):

http://codereview.chromium.org/10796085/diff/3002/net/socket/socket_test_util...
net/socket/socket_test_util.h:85: // given in MockTCPClientSocket::Write().
Might want to mention |result|, too, which has the same distinction - value
returned vs expected value returned.

[Yuta Kitamura, 2012-07-24 01:21:30]

Thanks.

akalin: Could you look at the changes under jingle?

https://chromiumcodereview.appspot.com/10796085/diff/3002/net/socket/socket_t...
File net/socket/socket_test_util.h (right):

https://chromiumcodereview.appspot.com/10796085/diff/3002/net/socket/socket_t...
net/socket/socket_test_util.h:85: // given in MockTCPClientSocket::Write().
On 2012/07/23 15:44:25, Matt Menke wrote:
> Might want to mention |result|, too, which has the same distinction - value
> returned vs expected value returned.

I think |result| has the same meaning in both MockRead and
MockWrite -- the return value of Read()/Write() call. Do I
miss something?

[mmenke, 2012-07-24 01:22:43]

On 2012/07/24 01:21:30, Yuta Kitamura wrote:
> Thanks.
> 
> akalin: Could you look at the changes under jingle?
> 
>
https://chromiumcodereview.appspot.com/10796085/diff/3002/net/socket/socket_t...
> File net/socket/socket_test_util.h (right):
> 
>
https://chromiumcodereview.appspot.com/10796085/diff/3002/net/socket/socket_t...
> net/socket/socket_test_util.h:85: // given in MockTCPClientSocket::Write().
> On 2012/07/23 15:44:25, Matt Menke wrote:
> > Might want to mention |result|, too, which has the same distinction - value
> > returned vs expected value returned.
> 
> I think |result| has the same meaning in both MockRead and
> MockWrite -- the return value of Read()/Write() call. Do I
> miss something?

No, I did - you're right.

[akalin, 2012-07-24 04:42:32]

jingle lgtm

[commit-bot: I haz the power, 2012-07-26 09:50:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/10796085/3002

[commit-bot: I haz the power, 2012-07-26 09:50:29]

Failed to apply patch for
jingle/notifier/base/fake_ssl_client_socket_unittest.cc:
While running patch -p1 --forward --force;
patching file jingle/notifier/base/fake_ssl_client_socket_unittest.cc
Hunk #1 FAILED at 72.
1 out of 1 hunk FAILED -- saving rejects to file
jingle/notifier/base/fake_ssl_client_socket_unittest.cc.rej

[commit-bot: I haz the power, 2012-07-26 10:08:39]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/10796085/13001

[commit-bot: I haz the power, 2012-07-26 10:31:15]

Try job failure for 10796085-13001 (retry) on linux_clang for step "compile"
(clobber build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_clan...

[commit-bot: I haz the power, 2012-07-27 03:49:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/10796085/13001

[commit-bot: I haz the power, 2012-07-27 04:02:31]

Try job failure for 10796085-13001 (retry) on mac_rel for step "compile"
(clobber build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[commit-bot: I haz the power, 2012-07-27 04:17:16]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/10796085/22002

[commit-bot: I haz the power, 2012-07-27 09:11:40]

Try job failure for 10796085-22002 (retry) on linux_rel for step
"browser_tests".
It's a second try, previously, steps "interactive_ui_tests, browser_tests"
failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[Yuta Kitamura, 2012-07-27 13:34:08]

On 2012/07/27 09:11:40, I haz the power (commit-bot) wrote:
> Try job failure for 10796085-22002 (retry) on linux_rel for step
> "browser_tests".
> It's a second try, previously, steps "interactive_ui_tests, browser_tests"
> failed.
>
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

Boo :( This looks like a flakiness, too, so let me try commit-queue again. (I
don't have time to do manual commit now.) Sorry about the spam.

[commit-bot: I haz the power, 2012-07-27 13:34:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/10796085/22002

[commit-bot: I haz the power, 2012-07-27 19:02:05]

Change committed as 148782