Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 10818006: Re-enable OTP sign in on trunk (Closed)

Created:
8 years, 5 months ago by Roger Tawa OOO till Jul 10th
Modified:
8 years, 5 months ago
CC:
chromium-reviews, Raghu Simha, ncarter (slow), arv (Not doing code reviews), akalin, tim (not reviewing)
Visibility:
Public.

Description

Re-enable OTP sign in on trunk by reverting most of 147297. I am not simply reverting 147297 because that CL included some js code for correctly handling errors in the ASP case, and that is still useful should the user decide to go back to ASPs. Change that disabled OTP on trunk: https://chromiumcodereview.appspot.com/10800010 http:crrev.com/147297 BUG=137772 TEST=Signing in should ask for OTP instead of ASP. Review URL: https://chromiumcodereview.appspot.com/10800010 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148201

Patch Set 1 #

Patch Set 2 : Don't revert change to js #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -22 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/sync/profile_sync_service_harness.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/sync_setup_handler.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/sync_setup_handler_unittest.cc View 1 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 2 2 chunks +1 line, -1 line 0 comments Download
M chrome/common/chrome_switches.cc View 1 2 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Roger Tawa OOO till Jul 10th
8 years, 5 months ago (2012-07-23 15:45:12 UTC) #1
Roger Tawa OOO till Jul 10th
Hi Tim, Please take a look. Thanks.
8 years, 5 months ago (2012-07-24 15:21:26 UTC) #2
tim (not reviewing)
lgtm
8 years, 5 months ago (2012-07-24 17:21:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/10818006/12001
8 years, 5 months ago (2012-07-24 18:39:42 UTC) #4
commit-bot: I haz the power
Presubmit check for 10818006-12001 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 5 months ago (2012-07-24 18:39:48 UTC) #5
Roger Tawa OOO till Jul 10th
Hi James, Can you do an owner review for the two webui files? Thanks.
8 years, 5 months ago (2012-07-24 19:54:41 UTC) #6
James Hawkins
lgtm
8 years, 5 months ago (2012-07-24 19:57:06 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/10818006/12001
8 years, 5 months ago (2012-07-24 20:03:23 UTC) #8
commit-bot: I haz the power
8 years, 5 months ago (2012-07-24 21:19:09 UTC) #9
Change committed as 148201

Powered by Google App Engine
This is Rietveld 408576698