Issue 10823260: Re-add sourceSetTimestampOffset to webmediaplayer_impl

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10823260: Re-add sourceSetTimestampOffset to webmediaplayer_impl (Closed)

Created:
8 years, 4 months ago by annacc

Modified:
8 years, 4 months ago

Reviewers:
vrk (LEFT CHROMIUM)

CC:
chromium-reviews, feature-media-reviews_chromium.org, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Re-add sourceSetTimestampOffset to webmediaplayer_impl sourceSetTimestampOffset() was removed in r150129 because it looked like it wasn't being used. It just hadn't been hooked up to WebKit yet. This patch will add it back. BUG=141659 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=150894

Patch Set 1 #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -0 lines)			Patch
	M	webkit/media/webmediaplayer_impl.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
	M	webkit/media/webmediaplayer_impl.cc	View		1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/10823260/1

8 years, 4 months ago (2012-08-09 17:32:51 UTC) #3

commit-bot: I haz the power

Try job failure for 10823260-1 (retry) on mac_rel for step "browser_tests". It's a second try, ...

8 years, 4 months ago (2012-08-09 18:49:29 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/10823260/1

8 years, 4 months ago (2012-08-09 19:29:37 UTC) #5

commit-bot: I haz the power

8 years, 4 months ago (2012-08-09 20:36:31 UTC) #6

Try job failure for 10823260-1 (retry) on mac_rel for step "browser_tests".
It's a second try, previously, step "browser_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

Expand Messages | Collapse Messages