Remove unnecessary use of SupportsWeakPtr in content/browser/renderer_host

Remove unnecessary use of SupportsWeakPtr in content/browser/renderer_host

Most of them are replaced with WeakPtrFactory to avoid exposing AsWeakPtr()

BUG=None
TEST=build success


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149375

[hashimoto, 2012-07-27 09:04:08]

jam,
Could you review this change?

[jam, 2012-07-27 23:31:37]

I don't have any background on this, can you describe the motivation?

[hashimoto, 2012-07-30 03:27:35]

On 2012/07/27 23:31:37, John Abd-El-Malek wrote:
> I don't have any background on this, can you describe the motivation?

Sorry for the missing context.
I've began to work on  crbug.com/112607 which requires using WeakPtr with
ResourceLoader, and found that most SupportsWeakPtr use cases in
content/browser/renderer_host are unnecessary.
(At least, no one is using ResourceDispatcherHost::AsWeakPtr)

Since WeakPtrFactory is safer than SupportsWeakPtr
(https://groups.google.com/a/chromium.org/d/msg/chromium-dev/1umM0irvLAw/017uf...),
I thought they should be replaced with WeakPtrFactory.

Does this make sense?

[jam, 2012-07-30 15:15:28]

redirecting to Darin, since he's been in this code a lot recently.

[darin (slow to review), 2012-07-31 18:23:38]

LGTM

[commit-bot: I haz the power, 2012-08-01 03:59:52]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/10824061/1

[commit-bot: I haz the power, 2012-08-01 05:14:31]

Change committed as 149375