Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 10826192: Browser Plugin: Rename WebContentsImpl::browser_plugin_host() to WebContentsImpl::old_browser_plugi… (Closed)

Created:
8 years, 4 months ago by Fady Samuel
Modified:
8 years, 4 months ago
Reviewers:
Charlie Reis, jam
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, rjkroege
Visibility:
Public.

Description

Browser Plugin: Rename WebContentsImpl::browser_plugin_host() to WebContentsImpl::old_browser_plugin_host() To avoid name collision with the new BrowserPluginHost implementation, rename the accessor in WebContentsImpl. BUG=141232 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150480

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -7 lines) Patch
M content/browser/browser_plugin/old/browser_plugin_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/web_contents_impl.h View 2 chunks +5 lines, -3 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Fady Samuel
8 years, 4 months ago (2012-08-07 21:43:55 UTC) #1
Fady Samuel
Adding creis@ as suggested by jam@
8 years, 4 months ago (2012-08-07 23:23:17 UTC) #2
Charlie Reis
LGTM.
8 years, 4 months ago (2012-08-07 23:52:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/10826192/1
8 years, 4 months ago (2012-08-08 00:40:17 UTC) #4
commit-bot: I haz the power
8 years, 4 months ago (2012-08-08 01:50:29 UTC) #5
Change committed as 150480

Powered by Google App Engine
This is Rietveld 408576698