Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10828140: Upstream about:welcome page for Android. (Closed)

Created:
8 years, 4 months ago by newt (away)
Modified:
8 years, 4 months ago
Reviewers:
Nico, Evan Stade
CC:
chromium-reviews, arv (Not doing code reviews)
Visibility:
Public.

Description

Upstream about:welcome page for Android. This page is specific to Android devices and is shown to the user after first-run. BUG=136951 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=152007

Patch Set 1 #

Total comments: 3

Patch Set 2 : Using WebUI now #

Total comments: 15

Patch Set 3 : #

Patch Set 4 : Removed about_welcome_android.js #

Patch Set 5 : #

Patch Set 6 : Removed .png files #

Patch Set 7 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+312 lines, -1 line) Patch
M chrome/browser/browser_resources.grd View 1 2 3 4 5 6 2 chunks +7 lines, -0 lines 0 comments Download
A chrome/browser/resources/about_welcome_android/about_welcome_android.css View 1 1 chunk +157 lines, -0 lines 0 comments Download
A chrome/browser/resources/about_welcome_android/about_welcome_android.html View 1 2 3 4 5 6 1 chunk +33 lines, -0 lines 0 comments Download
A chrome/browser/resources/about_welcome_android/about_welcome_android.js View 1 2 3 4 5 6 1 chunk +27 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc View 1 2 3 4 5 6 2 chunks +8 lines, -1 line 0 comments Download
A chrome/browser/ui/webui/welcome_ui_android.h View 1 1 chunk +19 lines, -0 lines 0 comments Download
A chrome/browser/ui/webui/welcome_ui_android.cc View 1 2 3 4 5 6 1 chunk +42 lines, -0 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 3 4 5 6 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/common/url_constants.h View 1 2 3 4 5 6 3 chunks +9 lines, -0 lines 0 comments Download
M chrome/common/url_constants.cc View 1 2 3 4 5 6 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (0 generated)
newt (away)
PTAL, thank you!
8 years, 4 months ago (2012-08-03 01:48:44 UTC) #1
Evan Stade
http://codereview.chromium.org/10828140/diff/1/chrome/browser/browser_about_handler.h File chrome/browser/browser_about_handler.h (right): http://codereview.chromium.org/10828140/diff/1/chrome/browser/browser_about_handler.h#newcode84 chrome/browser/browser_about_handler.h:84: class AboutAndroidApp { why is this class in this ...
8 years, 4 months ago (2012-08-03 17:58:01 UTC) #2
newt (away)
Evan, I reworked this to use WebUI. The instructions at https://sites.google.com/a/chromium.org/dev/developers/webui are a little out ...
8 years, 4 months ago (2012-08-09 23:47:46 UTC) #3
Evan Stade
you did well for how little documentation there is. http://codereview.chromium.org/10828140/diff/6001/chrome/browser/resources/about_welcome_android/about_welcome_android.html File chrome/browser/resources/about_welcome_android/about_welcome_android.html (right): http://codereview.chromium.org/10828140/diff/6001/chrome/browser/resources/about_welcome_android/about_welcome_android.html#newcode9 chrome/browser/resources/about_welcome_android/about_welcome_android.html:9: ...
8 years, 4 months ago (2012-08-10 02:40:01 UTC) #4
newt (away)
Thanks, I've made all the changes except the oncontextmenu handler (see comment there). http://codereview.chromium.org/10828140/diff/6001/chrome/browser/resources/about_welcome_android/about_welcome_android.html File ...
8 years, 4 months ago (2012-08-10 20:49:43 UTC) #5
Evan Stade
lgtm
8 years, 4 months ago (2012-08-13 22:21:01 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/10828140/6003
8 years, 4 months ago (2012-08-13 22:53:31 UTC) #7
commit-bot: I haz the power
Failed to apply patch for chrome/browser/browser_resources.grd: While running patch -p1 --forward --force; patching file chrome/browser/browser_resources.grd ...
8 years, 4 months ago (2012-08-13 22:53:33 UTC) #8
newt (away)
We decided not to disable context menus on the page. Can I then simply remove ...
8 years, 4 months ago (2012-08-13 23:00:25 UTC) #9
Evan Stade
you can remove about_welcome_android.js. I don't think you need cr.js either.
8 years, 4 months ago (2012-08-14 21:35:18 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/10828140/13001
8 years, 4 months ago (2012-08-15 23:23:36 UTC) #11
commit-bot: I haz the power
Presubmit check for 10828140-13001 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 4 months ago (2012-08-15 23:23:45 UTC) #12
newt (away)
Adding thakis for: * chrome/chrome_browser.gypi * chrome/common/url_constants.h * chrome/common/url_constants.cc
8 years, 4 months ago (2012-08-15 23:48:22 UTC) #13
Nico
Do you want to land the binary files in a separate CL, so that you ...
8 years, 4 months ago (2012-08-15 23:50:00 UTC) #14
Nico
(But the file you wanted me to look at lgtm either way)
8 years, 4 months ago (2012-08-15 23:51:03 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/10828140/16002
8 years, 4 months ago (2012-08-16 21:57:27 UTC) #16
commit-bot: I haz the power
8 years, 4 months ago (2012-08-17 00:23:34 UTC) #17 
Change committed as 152007

Powered by Google App Engine
This is Rietveld 408576698