Created a helper function "FindDiskBySourcePath" in DiskMountManager.

Created a helper function "FindDiskBySourcePath" in DiskMountManager.

BUG=none
TEST=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150205

[kmadhusu, 2012-08-03 07:12:59]

As a follow up of codereview.chromium.org/10830003, made changes to
DiskMountManager to create a new helper function. PTAL. Thanks.

[Ben Chan, 2012-08-03 15:04:55]

https://chromiumcodereview.appspot.com/10829160/diff/1/chrome/browser/chromeo...
File chrome/browser/chromeos/extensions/file_browser_private_api.cc (right):

https://chromiumcodereview.appspot.com/10829160/diff/1/chrome/browser/chromeo...
chrome/browser/chromeos/extensions/file_browser_private_api.cc:115: return disk
&& disk->is_hidden() ? NULL : disk;
return (disk && disk->is_hidden()) ? NULL : disk;

https://chromiumcodereview.appspot.com/10829160/diff/1/chrome/browser/media_g...
File chrome/browser/media_gallery/media_device_notifications_chromeos.cc
(right):

https://chromiumcodereview.appspot.com/10829160/diff/1/chrome/browser/media_g...
chrome/browser/media_gallery/media_device_notifications_chromeos.cc:26: return
disk ==  NULL ? std::string() : disk->fs_uuid();
return disk ? disk->fs_uuid() : std::string();

[kmadhusu, 2012-08-03 18:13:52]

benchan@: Addressed review comments. PTAL. Thanks.

https://chromiumcodereview.appspot.com/10829160/diff/1/chrome/browser/chromeo...
File chrome/browser/chromeos/extensions/file_browser_private_api.cc (right):

https://chromiumcodereview.appspot.com/10829160/diff/1/chrome/browser/chromeo...
chrome/browser/chromeos/extensions/file_browser_private_api.cc:115: return disk
&& disk->is_hidden() ? NULL : disk;
On 2012/08/03 15:04:55, Ben Chan wrote:
> return (disk && disk->is_hidden()) ? NULL : disk;

Done.

https://chromiumcodereview.appspot.com/10829160/diff/1/chrome/browser/media_g...
File chrome/browser/media_gallery/media_device_notifications_chromeos.cc
(right):

https://chromiumcodereview.appspot.com/10829160/diff/1/chrome/browser/media_g...
chrome/browser/media_gallery/media_device_notifications_chromeos.cc:26: return
disk ==  NULL ? std::string() : disk->fs_uuid();
On 2012/08/03 15:04:55, Ben Chan wrote:
> return disk ? disk->fs_uuid() : std::string();

Fixed.

[kmadhusu, 2012-08-03 18:14:33]

Added tbarzic@ as reviewer for OWNER's Check.

tbarzic@: PTAL. Thanks.

[tbarzic, 2012-08-06 18:12:08]

lgtm, given the *.FileBrowserMount test passes

http://codereview.chromium.org/10829160/diff/8/chrome/browser/chromeos/disks/...
File chrome/browser/chromeos/disks/mock_disk_mount_manager.h (right):

http://codereview.chromium.org/10829160/diff/8/chrome/browser/chromeos/disks/...
chrome/browser/chromeos/disks/mock_disk_mount_manager.h:78: // This function is
primarily for MediaDeviceNotificationsTest.
nit:
I'd loose the second sentence here.
(it is used only in MediaDeviceNotificaionsTest at the moment, but I wouldn't
say it is specific to that test).

actually, the same goes for mountPointsInternal

http://codereview.chromium.org/10829160/diff/8/chrome/browser/chromeos/extens...
File chrome/browser/chromeos/extensions/file_browser_private_api.cc (right):

http://codereview.chromium.org/10829160/diff/8/chrome/browser/chromeos/extens...
chrome/browser/chromeos/extensions/file_browser_private_api.cc:114: return (disk
&& disk->is_hidden()) ? NULL : disk;
please make sure ExtensionFileBrowserPrivateApiTest.FileBrowserMount
passes (I have a feeling this could break it).

you'll probably have to set mocks for FindDiskBySourcePath in
file_browser_private_apitest.cc

[kmadhusu, 2012-08-06 21:17:38]

tbarzic@: As we discussed, added a new mock function in
file_browser_private_apitest to fix FileBrowserMount test. PTAL. 

benchan@: ping

Thanks.

https://chromiumcodereview.appspot.com/10829160/diff/8/chrome/browser/chromeo...
File chrome/browser/chromeos/disks/mock_disk_mount_manager.h (right):

https://chromiumcodereview.appspot.com/10829160/diff/8/chrome/browser/chromeo...
chrome/browser/chromeos/disks/mock_disk_mount_manager.h:78: // This function is
primarily for MediaDeviceNotificationsTest.
On 2012/08/06 18:12:08, tbarzic wrote:
> nit:
> I'd loose the second sentence here.
> (it is used only in MediaDeviceNotificaionsTest at the moment, but I wouldn't
> say it is specific to that test).
> 
> actually, the same goes for mountPointsInternal

Done.

[tbarzic, 2012-08-06 21:40:35]

On 2012/08/06 21:17:38, kmadhusu wrote:
> tbarzic@: As we discussed, added a new mock function in
> file_browser_private_apitest to fix FileBrowserMount test. PTAL. 
> 
> benchan@: ping
> 
> Thanks.
> 
>
https://chromiumcodereview.appspot.com/10829160/diff/8/chrome/browser/chromeo...
> File chrome/browser/chromeos/disks/mock_disk_mount_manager.h (right):
> 
>
https://chromiumcodereview.appspot.com/10829160/diff/8/chrome/browser/chromeo...
> chrome/browser/chromeos/disks/mock_disk_mount_manager.h:78: // This function
is
> primarily for MediaDeviceNotificationsTest.
> On 2012/08/06 18:12:08, tbarzic wrote:
> > nit:
> > I'd loose the second sentence here.
> > (it is used only in MediaDeviceNotificaionsTest at the moment, but I
wouldn't
> > say it is specific to that test).
> > 
> > actually, the same goes for mountPointsInternal
> 
> Done.

LGTM

[Ben Chan, 2012-08-06 21:51:26]

lgtm with 1 nit

https://chromiumcodereview.appspot.com/10829160/diff/9010/chrome/browser/chro...
File chrome/browser/chromeos/extensions/file_browser_private_apitest.cc (right):

https://chromiumcodereview.appspot.com/10829160/diff/9010/chrome/browser/chro...
chrome/browser/chromeos/extensions/file_browser_private_apitest.cc:223: return
volume_it == volumes_.end() ? NULL : volume_it->second;
(volume_it == volumes_.end()) ?

[kmadhusu, 2012-08-06 21:55:48]

https://chromiumcodereview.appspot.com/10829160/diff/9010/chrome/browser/chro...
File chrome/browser/chromeos/extensions/file_browser_private_apitest.cc (right):

https://chromiumcodereview.appspot.com/10829160/diff/9010/chrome/browser/chro...
chrome/browser/chromeos/extensions/file_browser_private_apitest.cc:223: return
volume_it == volumes_.end() ? NULL : volume_it->second;
On 2012/08/06 21:51:27, Ben Chan wrote:
> (volume_it == volumes_.end()) ? 

sure. Done.

[commit-bot: I haz the power, 2012-08-06 21:59:40]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/10829160/3008

[commit-bot: I haz the power, 2012-08-06 21:59:45]

Presubmit check for 10829160-3008 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    chrome/browser/chromeos

Presubmit checks took 1.3s to calculate.

Was the presubmit check useful? Please send feedback & hate mail to
[email protected]!

[kmadhusu, 2012-08-06 22:04:09]

Added zelidrag@ as reviewer for chrome/browser/chromeos OWNER's check.

zelidrag@: PTAL. 

Thanks.

[zel, 2012-08-06 22:09:33]

lgtm

[commit-bot: I haz the power, 2012-08-06 22:12:32]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/10829160/3008

[commit-bot: I haz the power, 2012-08-06 22:54:16]

Try job failure for 10829160-3008 (retry) on linux_chromeos for step "compile"
(clobber build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[commit-bot: I haz the power, 2012-08-06 23:21:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/10829160/3008

[commit-bot: I haz the power, 2012-08-07 01:08:58]

Change committed as 150205