Add IPC::Sender and GetRoutingID() to WebContents for convenience and safety.

Add IPC::Sender and GetRoutingID() to WebContents for convenience and safety.

Code that is or has a WebContentsObserver can already use safe
versions of Send() and GetRoutingID() that perform NULL checks and
delete the Message object and return MSG_ROUTING_NONE when
appropriate.  This brings the same thing to code that has just a
WebContents.

BUG=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151880

[Jói, 2012-08-15 16:12:10]

John, as discussed.

Cheers,
Jói

[jam, 2012-08-15 16:22:02]

lgtm

http://codereview.chromium.org/10830337/diff/1/content/browser/web_contents/w...
File content/browser/web_contents/web_contents_impl.cc (right):

http://codereview.chromium.org/10830337/diff/1/content/browser/web_contents/w...
content/browser/web_contents/web_contents_impl.cc:2460: Send(new
ViewMsg_EnableViewSourceMode(GetRoutingID()));
I think you need to keep this as is.

render_view_host might not be equal to GetRenderViewHost() in case of pending
RVHs

http://codereview.chromium.org/10830337/diff/1/content/public/browser/web_con...
File content/public/browser/web_contents.h (right):

http://codereview.chromium.org/10830337/diff/1/content/public/browser/web_con...
content/public/browser/web_contents.h:49: class WebContents : public
PageNavigator, IPC::Sender {
nit: I think the convention is another public before IPC::Sender

http://codereview.chromium.org/10830337/diff/1/content/public/browser/web_con...
content/public/browser/web_contents.h:114: // For convenience, returns
MSG_ROUTING_NONE when there is no RenderViewHost.
nit: to be extra clear (since there could be multiple RVHs), can you say

// Gets the current RenderViewHost's routing id. Returns MSG_ROUTING_NONE when
there is no RenderViewHost.

[Jói, 2012-08-15 19:13:23]

Issues addressed, flipping the CQ bit now.

Cheers,
Jói

http://codereview.chromium.org/10830337/diff/1/content/browser/web_contents/w...
File content/browser/web_contents/web_contents_impl.cc (right):

http://codereview.chromium.org/10830337/diff/1/content/browser/web_contents/w...
content/browser/web_contents/web_contents_impl.cc:2460: Send(new
ViewMsg_EnableViewSourceMode(GetRoutingID()));
On 2012/08/15 16:22:02, John Abd-El-Malek wrote:
> I think you need to keep this as is.
> 
> render_view_host might not be equal to GetRenderViewHost() in case of pending
> RVHs

Phew, thanks for catching that!

http://codereview.chromium.org/10830337/diff/1/content/public/browser/web_con...
File content/public/browser/web_contents.h (right):

http://codereview.chromium.org/10830337/diff/1/content/public/browser/web_con...
content/public/browser/web_contents.h:49: class WebContents : public
PageNavigator, IPC::Sender {
On 2012/08/15 16:22:02, John Abd-El-Malek wrote:
> nit: I think the convention is another public before IPC::Sender

Done.

http://codereview.chromium.org/10830337/diff/1/content/public/browser/web_con...
content/public/browser/web_contents.h:114: // For convenience, returns
MSG_ROUTING_NONE when there is no RenderViewHost.
On 2012/08/15 16:22:02, John Abd-El-Malek wrote:
> nit: to be extra clear (since there could be multiple RVHs), can you say
> 
> // Gets the current RenderViewHost's routing id. Returns MSG_ROUTING_NONE when
> there is no RenderViewHost.

Done.

[commit-bot: I haz the power, 2012-08-15 19:14:16]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/10830337/6

[commit-bot: I haz the power, 2012-08-15 19:45:21]

Try job failure for 10830337-6 on mac_rel for step "update".
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

Step "update" is always a major failure.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2012-08-16 08:55:46]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/10830337/11001

[commit-bot: I haz the power, 2012-08-16 10:27:35]

Try job failure for 10830337-11001 (retry) on linux_rel for step
"interactive_ui_tests".
It's a second try, previously, step "interactive_ui_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[commit-bot: I haz the power, 2012-08-16 10:42:18]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/10830337/11001

[commit-bot: I haz the power, 2012-08-16 12:59:20]

Change committed as 151880