Issue 10832348: Tab value for context menu onclick event should be optional.

Issue 10832348: Tab value for context menu onclick event should be optional. (Closed)

Created:
8 years, 4 months ago by Marijn Kruisselbrink

Modified:
8 years, 4 months ago

Reviewers:
Mihai Parparita -not on Chrome

CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Tab value for context menu onclick event should be optional. In platform apps there are no tabs, and thus no way to pass a valid Tab value in this event. BUG=142747 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=152020

Patch Set 2 : fix small things in comments/variable names #

Patch Set 3 : regenerate docs #

Patch Set 4 : update the test code to chrome.app.runtime instead of experimental #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+45 lines, -6 lines)			Patch
M	chrome/browser/extensions/menu_manager.cc	View	1 2 3	1 chunk	+8 lines, -5 lines	0 comments	Download
M	chrome/browser/extensions/platform_app_browsertest.cc	View	1	1 chunk	+27 lines, -0 lines	0 comments	Download
M	chrome/common/extensions/api/context_menus.json	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/common/extensions/docs/apps/contextMenus.html	View	1 2	2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/common/extensions/docs/extensions/contextMenus.html	View	1 2	2 chunks	+2 lines, -1 line	0 comments	Download
A +	chrome/test/data/extensions/platform_apps/context_menu_click/main.html	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	chrome/test/data/extensions/platform_apps/context_menu_click/main.js	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	chrome/test/data/extensions/platform_apps/context_menu_click/manifest.json	View	1 2 3	1 chunk	+1 line, -0 lines	0 comments	Download
A +	chrome/test/data/extensions/platform_apps/context_menu_click/test.js	View	1 2 3	1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

Mihai Parparita -not on Chrome

LGTM http://codereview.chromium.org/10832348/diff/1/chrome/browser/extensions/menu_manager.cc File chrome/browser/extensions/menu_manager.cc (right): http://codereview.chromium.org/10832348/diff/1/chrome/browser/extensions/menu_manager.cc#newcode620 chrome/browser/extensions/menu_manager.cc:620: // No tab info in a platform app ...

8 years, 4 months ago (2012-08-16 19:52:42 UTC) #2

Marijn Kruisselbrink

okay, I fixed all those things, does that mean I should check the "commit" checkbox ...

8 years, 4 months ago (2012-08-16 20:31:06 UTC) #3

Mihai Parparita -not on Chrome

Yes, but please regenerate the docs (to match the modifications to the description) first. Mihai ...

8 years, 4 months ago (2012-08-16 23:22:25 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/10832348/4003

8 years, 4 months ago (2012-08-16 23:33:36 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/10832348/8010

8 years, 4 months ago (2012-08-17 00:03:19 UTC) #6

Change committed as 152020

Expand Messages | Collapse Messages