Coverity fixlet.

Coverity fixlet.


CID=104449,104364,104363,104357,104340,104298,104297,104058,104056,104055

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148669

[Danh Nguyen, 2012-07-25 19:08:51]

Hi Scott, Antony,

We're doing a Coverity fixlet in LA.  I'm wondering whether you could give me a
quick owner review on these fixes.  They are small changes so I hope it won't
take much of your time.

Thanks a lot for your help.

Danh

[asargent_no_longer_on_chrome, 2012-07-25 19:22:15]

LGTM

http://codereview.chromium.org/10833014/diff/1/chrome/browser/extensions/exte...
File chrome/browser/extensions/extension_info_map.cc (right):

http://codereview.chromium.org/10833014/diff/1/chrome/browser/extensions/exte...
chrome/browser/extensions/extension_info_map.cc:131: DCHECK(extension != NULL);
It might be better to make this a CHECK instead of DCHECK, since we'll get crash
on next line anyway if |extension| is null.

[Danh Nguyen, 2012-07-25 20:25:03]

Thanks, Antony.  I appreciate your help very much.

Scott,

I do need your help for the changes under chrome/browser/ui.  Could you take a
look?

Thanks,
Danh

http://codereview.chromium.org/10833014/diff/1/chrome/browser/extensions/exte...
File chrome/browser/extensions/extension_info_map.cc (right):

http://codereview.chromium.org/10833014/diff/1/chrome/browser/extensions/exte...
chrome/browser/extensions/extension_info_map.cc:131: DCHECK(extension != NULL);
On 2012/07/25 19:22:15, Antony Sargent wrote:
> It might be better to make this a CHECK instead of DCHECK, since we'll get
crash
> on next line anyway if |extension| is null. 
> 
> 
> 

Done.

[sky, 2012-07-25 21:28:12]

LGTM

[Danh Nguyen, 2012-07-25 21:33:12]

Thank you Scott.  I appreciate that very much.

Danh

[commit-bot: I haz the power, 2012-07-25 23:37:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/10833014/10001

[commit-bot: I haz the power, 2012-07-26 01:02:55]

Try job failure for 10833014-10001 (retry) on mac_rel for steps
"nacl_integration, interactive_ui_tests, browser_tests, unit_tests".
It's a second try, previously, steps "nacl_integration, interactive_ui_tests,
browser_tests, unit_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[commit-bot: I haz the power, 2012-07-26 18:52:01]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/10833014/3003

[commit-bot: I haz the power, 2012-07-26 21:33:04]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/10833014/3003

[commit-bot: I haz the power, 2012-07-27 00:16:41]

Change committed as 148669