Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1054)

Issue 10834010: Revert 144488 - For unit tests, track additions to AtExitManager and warn. (Closed)

Created:
8 years, 5 months ago by Scott Byer
Modified:
8 years, 5 months ago
Reviewers:
Scott Byer
CC:
chromium-reviews, joi+watch-content_chromium.org, erikwright (departed), darin-cc_chromium.org, jam, brettw-cc_chromium.org
Visibility:
Public.

Description

Revert 144488 - For unit tests, track additions to AtExitManager and warn. While trying to bullet proof a unit test, I had trouble getting very far when running all tests in shuffle mode. Tracked that back to a few other tests doing stuff that accessed Singleton()s outside of a test-scoped ShadowingAtExitManager. Seemed to me that should be an invariant around any unit test, so created this towards that end, hopefully helping stabilize out unit_tests a bit more. BUG=133403 Review URL: https://chromiumcodereview.appspot.com/10582012 [email protected] Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=148405

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -102 lines) Patch
M base/at_exit.h View 3 chunks +1 line, -8 lines 0 comments Download
M base/at_exit.cc View 2 chunks +1 line, -10 lines 0 comments Download
M base/test/test_suite.h View 1 chunk +0 lines, -2 lines 0 comments Download
M base/test/test_suite.cc View 4 chunks +0 lines, -56 lines 0 comments Download
M base/test/test_switches.h View 1 chunk +0 lines, -2 lines 0 comments Download
M base/test/test_switches.cc View 1 chunk +4 lines, -15 lines 0 comments Download
M chrome/test/base/in_process_browser_test.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M content/public/test/test_launcher.h View 2 chunks +3 lines, -1 line 0 comments Download
M content/test/test_launcher.cc View 4 chunks +6 lines, -5 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Scott Byer
8 years, 5 months ago (2012-07-25 20:35:10 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698