CSS Media Query now reports touch-support accurately for Windows.

CSS Media Query now reports touch-support accurately for Windows.


BUG=143792
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=155484

[girard, 2012-08-20 21:15:17]

Quick patch to correct the implementation of Query("pointer").

https://chromiumcodereview.appspot.com/10836349/diff/2001/content/browser/web...
File content/browser/web_contents/web_contents_impl.cc (right):

https://chromiumcodereview.appspot.com/10836349/diff/2001/content/browser/web...
content/browser/web_contents/web_contents_impl.cc:537: // Docs:
http://msdn.microsoft.com/en-us/library/dd371581(VS.85).aspx
Q: Is it reasonable to leave a documentation link in the code?  This page
contains a lot of info on the return value(s), such as how to detect a
multi-touch, or pen vs touch, etc.

https://chromiumcodereview.appspot.com/10836349/diff/2001/content/browser/web...
content/browser/web_contents/web_contents_impl.cc:538:
prefs.device_supports_touch = (::GetSystemMetrics(SM_DIGITIZER) > 0);
Q: Would it be better to move this out to base::win::IsTouchSupported()?

[sky, 2012-08-20 22:53:48]

https://chromiumcodereview.appspot.com/10836349/diff/2001/content/browser/web...
File content/browser/web_contents/web_contents_impl.cc (right):

https://chromiumcodereview.appspot.com/10836349/diff/2001/content/browser/web...
content/browser/web_contents/web_contents_impl.cc:537: // Docs:
http://msdn.microsoft.com/en-us/library/dd371581(VS.85).aspx
On 2012/08/20 21:15:18, girard wrote:
> Q: Is it reasonable to leave a documentation link in the code?  This page
> contains a lot of info on the return value(s), such as how to detect a
> multi-touch, or pen vs touch, etc.

Yes.

https://chromiumcodereview.appspot.com/10836349/diff/2001/content/browser/web...
content/browser/web_contents/web_contents_impl.cc:538:
prefs.device_supports_touch = (::GetSystemMetrics(SM_DIGITIZER) > 0);
On 2012/08/20 21:15:18, girard wrote:
> Q: Would it be better to move this out to base::win::IsTouchSupported()?

That sounds better to me.

[Rick Byers, 2012-08-21 11:26:16]

lgtm with nit

https://chromiumcodereview.appspot.com/10836349/diff/2001/content/browser/web...
File content/browser/web_contents/web_contents_impl.cc (right):

https://chromiumcodereview.appspot.com/10836349/diff/2001/content/browser/web...
content/browser/web_contents/web_contents_impl.cc:530: ui::GetDisplayLayout() ==
ui::LAYOUT_TOUCH;
You might as well remove this line now (or explicitly initialize to false) -
Windows was the only other case we cared about.

[girard, 2012-08-23 15:57:23]

Moved function to base::win.

https://chromiumcodereview.appspot.com/10836349/diff/2001/content/browser/web...
File content/browser/web_contents/web_contents_impl.cc (right):

https://chromiumcodereview.appspot.com/10836349/diff/2001/content/browser/web...
content/browser/web_contents/web_contents_impl.cc:530: ui::GetDisplayLayout() ==
ui::LAYOUT_TOUCH;
On 2012/08/21 11:26:16, Rick Byers wrote:
> You might as well remove this line now (or explicitly initialize to false) -
> Windows was the only other case we cared about.

Done.

https://chromiumcodereview.appspot.com/10836349/diff/2001/content/browser/web...
content/browser/web_contents/web_contents_impl.cc:538:
prefs.device_supports_touch = (::GetSystemMetrics(SM_DIGITIZER) > 0);
On 2012/08/20 22:53:49, sky wrote:
> On 2012/08/20 21:15:18, girard wrote:
> > Q: Would it be better to move this out to base::win::IsTouchSupported()?
> 
> That sounds better to me.

Done.

[sky, 2012-08-23 16:45:35]

You want these in ui/base, not base.

[girard, 2012-08-23 22:18:25]

On 2012/08/23 16:45:35, sky wrote:
> You want these in ui/base, not base.

Thanks.  Done.

[sky, 2012-08-23 22:54:34]

https://chromiumcodereview.appspot.com/10836349/diff/14001/content/browser/we...
File content/browser/web_contents/web_contents_impl.cc (right):

https://chromiumcodereview.appspot.com/10836349/diff/14001/content/browser/we...
content/browser/web_contents/web_contents_impl.cc:18: #include
"base/win/win_util.h"
Remove this.

https://chromiumcodereview.appspot.com/10836349/diff/14001/ui/base/touch/touc...
File ui/base/touch/touch_device.cc (right):

https://chromiumcodereview.appspot.com/10836349/diff/14001/ui/base/touch/touc...
ui/base/touch/touch_device.cc:6: #include "base/win/windows_version.h"
nit: newline between 5/6 and 6/7

https://chromiumcodereview.appspot.com/10836349/diff/14001/ui/base/touch/touc...
File ui/base/touch/touch_device.h (right):

https://chromiumcodereview.appspot.com/10836349/diff/14001/ui/base/touch/touc...
ui/base/touch/touch_device.h:14: UI_EXPORT bool IsTouchDevicePresent();
This file should be named touch_device_win

[girard, 2012-08-24 14:30:12]

Files renamed, and other nits have been cleaned up.  Thanks for the feedback.

https://chromiumcodereview.appspot.com/10836349/diff/14001/content/browser/we...
File content/browser/web_contents/web_contents_impl.cc (right):

https://chromiumcodereview.appspot.com/10836349/diff/14001/content/browser/we...
content/browser/web_contents/web_contents_impl.cc:18: #include
"base/win/win_util.h"
On 2012/08/23 22:54:34, sky wrote:
> Remove this.

Done.

https://chromiumcodereview.appspot.com/10836349/diff/14001/ui/base/touch/touc...
File ui/base/touch/touch_device.cc (right):

https://chromiumcodereview.appspot.com/10836349/diff/14001/ui/base/touch/touc...
ui/base/touch/touch_device.cc:6: #include "base/win/windows_version.h"
On 2012/08/23 22:54:34, sky wrote:
> nit: newline between 5/6 and 6/7

Done.

https://chromiumcodereview.appspot.com/10836349/diff/14001/ui/base/touch/touc...
File ui/base/touch/touch_device.h (right):

https://chromiumcodereview.appspot.com/10836349/diff/14001/ui/base/touch/touc...
ui/base/touch/touch_device.h:14: UI_EXPORT bool IsTouchDevicePresent();
On 2012/08/23 22:54:34, sky wrote:
> This file should be named touch_device_win

Done. (Renamed both header and source files.)

[sky, 2012-08-24 18:09:15]

LGTM

[commit-bot: I haz the power, 2012-08-24 18:18:18]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/10836349/18001

[commit-bot: I haz the power, 2012-08-24 18:51:31]

Try job failure for 10836349-18001 (retry) on linux_chromeos for step "compile"
(clobber build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[commit-bot: I haz the power, 2012-09-07 02:10:51]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/10836349/18001

[commit-bot: I haz the power, 2012-09-07 06:38:40]

Try job failure for 10836349-18001 (previous was lost) (retry) on linux_chromeos
for step "compile" (clobber build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[commit-bot: I haz the power, 2012-09-07 16:19:56]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/10836349/29001

[commit-bot: I haz the power, 2012-09-07 17:44:04]

Try job failure for 10836349-29001 (retry) on linux_rel for step
"interactive_ui_tests".
It's a second try, previously, step "interactive_ui_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[commit-bot: I haz the power, 2012-09-07 18:52:32]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/10836349/29001

[commit-bot: I haz the power, 2012-09-07 21:22:05]

Change committed as 155484