Correct const accessors in base/values.(h|cc), Part II (ListValue)

Correct const accessors in base/values.(h|cc), Part II (ListValue)

For problem description and other info please see the BUG page.
This is for ListValue.

BUG=138946
TEST=N/A (no fix & no new feature)
TBR=jar,zelidrag,scottbyer,mpcomplete,darin,achuith,sky,estade,atwilson,grt,thakis,jamesr,hans,sadrul,pastarmovj


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149819

[vabr (Chromium), 2012-08-01 15:37:32]

Hi all, please find a personalised message below :). It's a large CL, but
individual parts for review should be small.

Dominic,
Could you please take a look at chrome/browser/net/* part of this? Especially
chrome/browser/net/predictor_unittest.cc, where I had to write const and
non-const version of FindSerializationMotivation.

David,
Following our e-mail discussion, I modified
chrome/browser/ui/webui/options2/autofill_options_handler.cc . How does that
look to you?
When I tried to add duplicate numbers in chrome://chrome/settings/autofill ,
they were removed on my patched version (in other words, the behaviour was
exactly the same as in the current beta).
I also ran AutofillTest.* browser tests on my machine (linux, debug build) and
checked that they passed.

James,
Could you please take a look at chrome/browser/ui/webui/options2? In
handler_options_handler.cc I removed two lines which seemed superfluous (other
changes there are just adding const). Other non-trivial change in options2 is
the one mentioned to David, please have a look at it as well.

Brett,
Could you please review the changes to base?

All other OWNERS are in TBR because those changes were only adding "const" to
types, and should be harmless.

Thanks to all,

Vaclav

[dhollowa, 2012-08-01 16:11:56]

Autofill: LGTM.

http://codereview.chromium.org/10837044/diff/4006/chrome/browser/ui/webui/opt...
File chrome/browser/ui/webui/options2/autofill_options_handler.cc (right):

http://codereview.chromium.org/10837044/diff/4006/chrome/browser/ui/webui/opt...
chrome/browser/ui/webui/options2/autofill_options_handler.cc:162:
AutofillProfile* profile) {
nit: this line can be unwrapped.

http://codereview.chromium.org/10837044/diff/4006/chrome/browser/ui/webui/opt...
chrome/browser/ui/webui/options2/autofill_options_handler.cc:258: ListValue*
list = extracted_list->DeepCopy();
optional: I have a slight preference for creating the scoped_ptr here (RAII) and
then using |Pass()| when returning it.

[brettw, 2012-08-01 22:03:09]

base LGTM

[battre, 2012-08-02 08:39:02]

LGTM @ net

Thanks a lot for doing this!

[battre, 2012-08-02 08:39:26]

On 2012/08/02 08:39:02, battre wrote:
> LGTM @ net
> 
> Thanks a lot for doing this!

sorry meant chrome/browser/net

[James Hawkins, 2012-08-02 20:51:30]

webui LGTM

[vabr (Chromium), 2012-08-03 07:08:23]

Thanks you all for the prompt reviews!
I addressed David's comments and rebased, and I'm sending it to the CQ.

Vaclav

http://codereview.chromium.org/10837044/diff/4006/chrome/browser/ui/webui/opt...
File chrome/browser/ui/webui/options2/autofill_options_handler.cc (right):

http://codereview.chromium.org/10837044/diff/4006/chrome/browser/ui/webui/opt...
chrome/browser/ui/webui/options2/autofill_options_handler.cc:162:
AutofillProfile* profile) {
On 2012/08/01 16:11:56, dhollowa wrote:
> nit: this line can be unwrapped.

Done.

http://codereview.chromium.org/10837044/diff/4006/chrome/browser/ui/webui/opt...
chrome/browser/ui/webui/options2/autofill_options_handler.cc:258: ListValue*
list = extracted_list->DeepCopy();
On 2012/08/01 16:11:56, dhollowa wrote:
> optional: I have a slight preference for creating the scoped_ptr here (RAII)
and
> then using |Pass()| when returning it.

Done.

[commit-bot: I haz the power, 2012-08-03 07:08:39]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/10837044/5005

[commit-bot: I haz the power, 2012-08-03 08:43:43]

Change committed as 149819