Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(432)

Issue 10867020: Add DIR_ANDROID_EXTERNAL_STORAGE to base/base_path.h (Closed)

Created:
8 years, 4 months ago by nilesh
Modified:
8 years, 4 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews, erikwright+watch_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Add DIR_ANDROID_EXTERNAL_STORAGE to base/base_path.h This adds a method to get the external storage directory on Android. BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=153183

Patch Set 1 #

Patch Set 2 : Restrict to Android only. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -0 lines) Patch
M base/android/java/src/org/chromium/base/PathUtils.java View 1 chunk +9 lines, -0 lines 0 comments Download
M base/android/path_utils.h View 1 chunk +3 lines, -0 lines 0 comments Download
M base/android/path_utils.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M base/base_paths.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M base/base_paths_android.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
nilesh
8 years, 4 months ago (2012-08-22 22:56:19 UTC) #1
Mark Mentovai
LGTM
8 years, 4 months ago (2012-08-23 12:30:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/10867020/7001
8 years, 4 months ago (2012-08-23 14:41:25 UTC) #3
commit-bot: I haz the power
Try job failure for 10867020-7001 (retry) on linux_rel for step "interactive_ui_tests". It's a second try, ...
8 years, 4 months ago (2012-08-23 16:27:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/10867020/7001
8 years, 4 months ago (2012-08-23 21:34:32 UTC) #5
commit-bot: I haz the power
Try job failure for 10867020-7001 (retry) on linux_chromeos for step "browser_tests". It's a second try, ...
8 years, 4 months ago (2012-08-24 01:11:57 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/10867020/7001
8 years, 4 months ago (2012-08-24 03:37:57 UTC) #7
commit-bot: I haz the power
8 years, 4 months ago (2012-08-24 10:08:30 UTC) #8
Change committed as 153183

Powered by Google App Engine
This is Rietveld 408576698