Issue 10870071: Renamed Encoder -> VideoEncoder.

Issue 10870071: Renamed Encoder -> VideoEncoder. (Closed)

Created:
8 years, 4 months ago by kxing

Modified:
8 years, 4 months ago

Reviewers:
simonmorris, Wez

CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Renamed Encoder -> VideoEncoder. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=153261

Patch Set 1 #

Total comments: 6

Patch Set 2 : Addressed comments #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+160 lines, -144 lines)			Patch
M	remoting/codec/codec_test.h	View		1 chunk	+11 lines, -8 lines	0 comments	Download
M	remoting/codec/codec_test.cc	View		10 chunks	+30 lines, -29 lines	0 comments	Download
M	remoting/codec/video_decoder_vp8_unittest.cc	View		1 chunk	+7 lines, -7 lines	0 comments	Download
M	remoting/codec/video_encode_decode_unittest.cc	View		1 chunk	+9 lines, -6 lines	0 comments	Download
M	remoting/codec/video_encoder.h	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	remoting/codec/video_encoder_row_based.h	View	1	2 chunks	+12 lines, -10 lines	0 comments	Download
M	remoting/codec/video_encoder_row_based.cc	View		4 chunks	+27 lines, -26 lines	0 comments	Download
M	remoting/codec/video_encoder_row_based_unittest.cc	View		1 chunk	+8 lines, -6 lines	0 comments	Download
M	remoting/codec/video_encoder_vp8.h	View		3 chunks	+5 lines, -5 lines	0 comments	Download
M	remoting/codec/video_encoder_vp8.cc	View		6 chunks	+11 lines, -10 lines	0 comments	Download
M	remoting/codec/video_encoder_vp8_unittest.cc	View		5 chunks	+14 lines, -14 lines	0 comments	Download
M	remoting/host/chromoting_host.h	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	remoting/host/chromoting_host.cc	View	1	2 chunks	+8 lines, -6 lines	0 comments	Download
M	remoting/host/screen_recorder.h	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	remoting/host/screen_recorder.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	remoting/host/screen_recorder_unittest.cc	View		4 chunks	+9 lines, -9 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

simonmorris

http://codereview.chromium.org/10870071/diff/1/remoting/codec/video_encoder_row_based.h File remoting/codec/video_encoder_row_based.h (right): http://codereview.chromium.org/10870071/diff/1/remoting/codec/video_encoder_row_based.h#newcode16 remoting/codec/video_encoder_row_based.h:16: // VideoEncoderRowBased implements an VideoEncoder using zlib or verbatim ...

8 years, 4 months ago (2012-08-24 16:19:28 UTC) #2

kxing

Could someone PTAL again? http://codereview.chromium.org/10870071/diff/1/remoting/codec/video_encoder_row_based.h File remoting/codec/video_encoder_row_based.h (right): http://codereview.chromium.org/10870071/diff/1/remoting/codec/video_encoder_row_based.h#newcode16 remoting/codec/video_encoder_row_based.h:16: // VideoEncoderRowBased implements an VideoEncoder ...

8 years, 4 months ago (2012-08-24 16:28:03 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/10870071/6001

8 years, 4 months ago (2012-08-24 17:19:02 UTC) #5

Change committed as 153261

Expand Messages | Collapse Messages