Shard DatabaseTracker

Access the DatabaseTracker via a StoragePartition to support the isolated app feature.

TBR=brettw,mkwst,kalman
BUG=85121
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=153814

[michaeln, 2012-08-27 20:53:44]

ptal

[awong, 2012-08-27 21:11:25]

looking pretty good. 1 nit, and 1 implementation comment.

https://chromiumcodereview.appspot.com/10879075/diff/9007/chrome/browser/exte...
File chrome/browser/extensions/data_deleter.cc (right):

https://chromiumcodereview.appspot.com/10879075/diff/9007/chrome/browser/exte...
chrome/browser/extensions/data_deleter.cc:85: // TODO(michaeln): use contexts
from the right StoragePartition
Capitalization and punctuation.

Also, if you want, you can cite bug http://crbug.com/85127

https://chromiumcodereview.appspot.com/10879075/diff/9007/content/browser/bro...
File content/browser/browser_context.cc (right):

https://chromiumcodereview.appspot.com/10879075/diff/9007/content/browser/bro...
content/browser/browser_context.cc:169:
GetDefaultStoragePartition(browser_context)->GetDatabaseTracker()->
Should this use the ForEachStoragePartiion and call SetForceKeepSessionState()
over everything?
If the ordering isn't too critical, we could also do the same thing on
DOMStorageContextImpl.

BTW, is this method safe to call on the UI thread?

[michaeln, 2012-08-27 22:09:57]

https://chromiumcodereview.appspot.com/10879075/diff/9007/chrome/browser/exte...
File chrome/browser/extensions/data_deleter.cc (right):

https://chromiumcodereview.appspot.com/10879075/diff/9007/chrome/browser/exte...
chrome/browser/extensions/data_deleter.cc:85: // TODO(michaeln): use contexts
from the right StoragePartition
On 2012/08/27 21:11:25, awong wrote:
> Capitalization and punctuation.
> 
> Also, if you want, you can cite bug http://crbug.com/85127

Done.

https://chromiumcodereview.appspot.com/10879075/diff/9007/content/browser/bro...
File content/browser/browser_context.cc (right):

https://chromiumcodereview.appspot.com/10879075/diff/9007/content/browser/bro...
content/browser/browser_context.cc:169:
GetDefaultStoragePartition(browser_context)->GetDatabaseTracker()->
On 2012/08/27 21:11:25, awong wrote:
> Should this use the ForEachStoragePartiion and call SetForceKeepSessionState()
> over everything?

For now, i've been avoiding putting behaviors related to general settings on top
of isolated partitions, for at least a few reasons...

* Not clear what the desired relationship between general settings and isolated
app settings is?

* Calling ForEachPartition doesn't really cut it since unless the partition has
been accessed, there won't be an instance in memory to poke at.

* FUD

> BTW, is this method safe to call on the UI thread?

thread-safe, yes

https://chromiumcodereview.appspot.com/10879075/diff/9007/content/public/brow...
File content/public/browser/browser_context.h (left):

https://chromiumcodereview.appspot.com/10879075/diff/9007/content/public/brow...
content/public/browser/browser_context.h:59: static
webkit_database::DatabaseTracker* GetDatabaseTracker(
Removing this method is the main point of this CL, so that the StoragePartition
accessor must be used.

[awong, 2012-08-27 22:11:18]

LGTM

Fair points on not having defined behavior and about missing pieces that aren't
loaded into the current browser context.

[michaeln, 2012-08-29 00:48:10]

I'm TBR'ing various owners since this is a mechanical change, similar to others
that have been going in, but spread out across things.