Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 10880015: contacts: Add --enable-contacts switch. (Closed)

Created:
8 years, 4 months ago by Daniel Erat
Modified:
8 years, 3 months ago
Reviewers:
satorux1, sky
CC:
chromium-reviews, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

contacts: Add --enable-contacts switch. Adds a command-line flag that results in the ContactManager singleton being instantiated on Chrome OS (and hence, Google contacts being periodically synced) and lists it on chrome://flags. Contacts aren't yet exposed in the UI. BUG=128805 TEST=none [email protected] Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=153830

Patch Set 1 #

Patch Set 2 : merge #

Patch Set 3 : whoops, really merge #

Patch Set 4 : merge again #

Patch Set 5 : and another merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -4 lines) Patch
M chrome/app/generated_resources.grd View 2 chunks +7 lines, -1 line 0 comments Download
M chrome/browser/about_flags.cc View 1 2 3 4 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/chrome_browser_main_chromeos.h View 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/chrome_browser_main_chromeos.cc View 1 3 chunks +9 lines, -2 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/chrome_switches.cc View 1 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
Daniel Erat
8 years, 4 months ago (2012-08-22 22:56:21 UTC) #1
Daniel Erat
8 years, 3 months ago (2012-08-28 14:28:24 UTC) #2
satorux1
lgtm. sorry for the belated response. i was almost entirely ooo last week
8 years, 3 months ago (2012-08-28 15:24:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/10880015/14001
8 years, 3 months ago (2012-08-28 20:26:56 UTC) #4
commit-bot: I haz the power
Presubmit check for 10880015-14001 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 3 months ago (2012-08-28 20:26:59 UTC) #5
Daniel Erat
8 years, 3 months ago (2012-08-28 20:30:39 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/10880015/14001
8 years, 3 months ago (2012-08-28 20:31:27 UTC) #7
sky
LGTM
8 years, 3 months ago (2012-08-28 20:59:54 UTC) #8
commit-bot: I haz the power
Failed to apply patch for chrome/browser/about_flags.cc: While running patch -p1 --forward --force; patching file chrome/browser/about_flags.cc ...
8 years, 3 months ago (2012-08-28 23:48:28 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/10880015/8011
8 years, 3 months ago (2012-08-29 00:07:24 UTC) #10
commit-bot: I haz the power
8 years, 3 months ago (2012-08-29 02:34:23 UTC) #11
Change committed as 153830

Powered by Google App Engine
This is Rietveld 408576698