Issue 10895027: Extension Docs Server 2: Redirect code.google.com/chrome/extensions to

Issue 10895027: Extension Docs Server 2: Redirect code.google.com/chrome/extensions to (Closed)

Created:
8 years, 3 months ago by Aaron Boodman

Modified:
8 years, 3 months ago

Reviewers:
not at google - send to devlin

CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Extension Docs Server 2: Redirect code.google.com/chrome/extensions to developer.chrome.com/extensions Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=154028

Patch Set 2 : remove version #

Patch Set 3 : yo #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+41 lines, -8 lines)			Patch
M	chrome/common/extensions/docs/server2/branch_utility.py	View	1 2	1 chunk	+5 lines, -1 line	0 comments	Download
M	chrome/common/extensions/docs/server2/handler.py	View	1 2	2 chunks	+34 lines, -7 lines	0 comments	Download
M	chrome/common/extensions/docs/server2/integration_test.py	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/common/extensions/docs/server2/preview.py	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

not at google - send to devlin

lgtm https://chromiumcodereview.appspot.com/10895027/diff/1/chrome/common/extensions/docs/server2/handler.py File chrome/common/extensions/docs/server2/handler.py (right): https://chromiumcodereview.appspot.com/10895027/diff/1/chrome/common/extensions/docs/server2/handler.py#newcode231 chrome/common/extensions/docs/server2/handler.py:231: nits: surrounding this method in 2 blank lines ...

8 years, 3 months ago (2012-08-29 07:20:46 UTC) #2

Aaron Boodman

http://codereview.chromium.org/10895027/diff/1/chrome/common/extensions/docs/server2/handler.py File chrome/common/extensions/docs/server2/handler.py (right): http://codereview.chromium.org/10895027/diff/1/chrome/common/extensions/docs/server2/handler.py#newcode231 chrome/common/extensions/docs/server2/handler.py:231: On 2012/08/29 07:20:46, kalman wrote: > nits: surrounding this ...

8 years, 3 months ago (2012-08-29 19:42:41 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/10895027/6001

8 years, 3 months ago (2012-08-29 19:51:19 UTC) #4

commit-bot: I haz the power

8 years, 3 months ago (2012-08-29 19:51:21 UTC) #5

Failed to apply patch for
chrome/common/extensions/docs/server2/branch_utility.py:
While running patch -p1 --forward --force;
patching file chrome/common/extensions/docs/server2/branch_utility.py
Hunk #1 FAILED at 14.
1 out of 1 hunk FAILED -- saving rejects to file
chrome/common/extensions/docs/server2/branch_utility.py.rej

Expand Messages | Collapse Messages