Support an --install-from-webstore command line switch

Support an --install-from-webstore command line switch

This is to make standalone installation of apps from the Chrome app host possible.

BUG=138311
[email protected] (for chrome/common/chrome_switches.{h,cc})


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=157088

[asargent_no_longer_on_chrome, 2012-09-07 21:15:41]

http://codereview.chromium.org/10907104/diff/6015/chrome/browser/extensions/e...
File chrome/browser/extensions/extension_install_dialog.cc (left):

http://codereview.chromium.org/10907104/diff/6015/chrome/browser/extensions/e...
chrome/browser/extensions/extension_install_dialog.cc:72:
delegate->InstallUIAbort(false);
FYI, I know for sure that GTK's ShowExtensionInstallDialogImpl properly handles
this case of the parent window being NULL, and I am currently verifying that
MacOS/Windows/ChromeOS work as well. If any of them have problems, I can turn
this into an #ifdef for the ones that currently work, and do follow-up CL's to
fix the broken ones.

[Mihai Parparita -not on Chrome, 2012-09-07 22:01:36]

http://codereview.chromium.org/10907104/diff/6015/chrome/browser/chrome_brows...
File chrome/browser/chrome_browser_main.cc (right):

http://codereview.chromium.org/10907104/diff/6015/chrome/browser/chrome_brows...
chrome/browser/chrome_browser_main.cc:1345:
cmdline.GetSwitchValueASCII(switches::kAppsInstallFromID),
Other StartupHelper methods take the whole CommandLine, and extract what they
need from it. It seems more consistent to do that here too.

http://codereview.chromium.org/10907104/diff/6015/chrome/browser/chrome_brows...
chrome/browser/chrome_browser_main.cc:1348: else
Unnecessary else, given the return above.

http://codereview.chromium.org/10907104/diff/6015/chrome/browser/download/dow...
File chrome/browser/download/download_crx_util.cc (right):

http://codereview.chromium.org/10907104/diff/6015/chrome/browser/download/dow...
chrome/browser/download/download_crx_util.cc:83: if (!is_gallery_download)
Doesn't this mean that the SetUseAppInstalledBubble setting will no longer be
propagated for gallery installs?

http://codereview.chromium.org/10907104/diff/6015/chrome/browser/extensions/e...
File chrome/browser/extensions/extension_install_dialog.cc (left):

http://codereview.chromium.org/10907104/diff/6015/chrome/browser/extensions/e...
chrome/browser/extensions/extension_install_dialog.cc:72:
delegate->InstallUIAbort(false);
On 2012/09/07 21:15:41, Antony Sargent wrote:
> FYI, I know for sure that GTK's ShowExtensionInstallDialogImpl properly
handles
> this case of the parent window being NULL, and I am currently verifying that
> MacOS/Windows/ChromeOS work as well. If any of them have problems, I can turn
> this into an #ifdef for the ones that currently work, and do follow-up CL's to
> fix the broken ones. 

OK. We end up using in Widget::CreateWindowWithParent in the views version, but
since the parent-less version just calls that with a NULL parent, I think it
should work.

http://codereview.chromium.org/10907104/diff/6015/chrome/browser/extensions/s...
File chrome/browser/extensions/startup_helper.cc (right):

http://codereview.chromium.org/10907104/diff/6015/chrome/browser/extensions/s...
chrome/browser/extensions/startup_helper.cc:100: return
base::Bind(&AppInstallHelper::OnAppInstallComplete,
Why not do this inline in te WebstoreInlineInstaller call?

http://codereview.chromium.org/10907104/diff/6015/chrome/browser/extensions/s...
chrome/browser/extensions/startup_helper.cc:104: const std::string& error) {
It would be nice to somehow propagate this error back to the return value of
InstallAppFromId.

http://codereview.chromium.org/10907104/diff/6015/chrome/browser/extensions/s...
chrome/browser/extensions/startup_helper.cc:111:
scoped_ptr<content::WebContents> web_contents(
Add a TODO about removing the need for this WebContents (I thought we had
discussed how it wasn't strictly necessary)?

http://codereview.chromium.org/10907104/diff/6015/chrome/browser/extensions/w...
File chrome/browser/extensions/webstore_inline_installer.cc (right):

http://codereview.chromium.org/10907104/diff/6015/chrome/browser/extensions/w...
chrome/browser/extensions/webstore_inline_installer.cc:305:
CompleteInstall(kNotFromVerifiedSiteError);
Seems like you'd want to ignore this error if require_verified_site_ is false.

http://codereview.chromium.org/10907104/diff/6015/chrome/browser/extensions/w...
File chrome/browser/extensions/webstore_inline_installer.h (right):

http://codereview.chromium.org/10907104/diff/6015/chrome/browser/extensions/w...
chrome/browser/extensions/webstore_inline_installer.h:36: class
WebstoreInlineInstaller
Add a TODO about renaming this class, since it's no longer inline
installation-specific. WebstoreStandaloneInstaller perhaps? (since it doesn't
depend on the webstore web UI)

http://codereview.chromium.org/10907104/diff/6015/chrome/browser/extensions/w...
chrome/browser/extensions/webstore_inline_installer.h:47: typedef
base::Callback<void(bool success, const std::string& error)> Callback;
This needs a base/callback.h #include.

http://codereview.chromium.org/10907104/diff/6015/chrome/browser/extensions/w...
chrome/browser/extensions/webstore_inline_installer.h:51: bool
require_verified_site,
An enum param would be more readable.

http://codereview.chromium.org/10907104/diff/6015/chrome/common/chrome_switch...
File chrome/common/chrome_switches.cc (right):

http://codereview.chromium.org/10907104/diff/6015/chrome/common/chrome_switch...
chrome/common/chrome_switches.cc:94: // When passed on the command-line, this
causes chrome to attempt to download
Nit: capitalize Chrome.

http://codereview.chromium.org/10907104/diff/6015/chrome/common/chrome_switch...
chrome/common/chrome_switches.cc:95: // and install an app from the webstore
with the given id.
Mention that there's an install prompt too (i.e. this is not a silent
installation flag).

http://codereview.chromium.org/10907104/diff/6015/chrome/common/chrome_switch...
chrome/common/chrome_switches.cc:96: const char kAppsInstallFromID[]    =
"apps-install-from-id";
If it's not too late, I think "webstore" should be in the flag name somewhere
(and in the StartupHelper method name).

Also, ID should probably be capitalized as "Id" (though we're not consistent
elsewhere)

[asargent_no_longer_on_chrome, 2012-09-14 23:24:35]

http://codereview.chromium.org/10907104/diff/6015/chrome/browser/chrome_brows...
File chrome/browser/chrome_browser_main.cc (right):

http://codereview.chromium.org/10907104/diff/6015/chrome/browser/chrome_brows...
chrome/browser/chrome_browser_main.cc:1345:
cmdline.GetSwitchValueASCII(switches::kAppsInstallFromID),
On 2012/09/07 22:01:36, Mihai Parparita wrote:
> Other StartupHelper methods take the whole CommandLine, and extract what they
> need from it. It seems more consistent to do that here too.

Done.

http://codereview.chromium.org/10907104/diff/6015/chrome/browser/chrome_brows...
chrome/browser/chrome_browser_main.cc:1348: else
On 2012/09/07 22:01:36, Mihai Parparita wrote:
> Unnecessary else, given the return above.

Done.

http://codereview.chromium.org/10907104/diff/6015/chrome/browser/download/dow...
File chrome/browser/download/download_crx_util.cc (right):

http://codereview.chromium.org/10907104/diff/6015/chrome/browser/download/dow...
chrome/browser/download/download_crx_util.cc:83: if (!is_gallery_download)
On 2012/09/07 22:01:36, Mihai Parparita wrote:
> Doesn't this mean that the SetUseAppInstalledBubble setting will no longer be
> propagated for gallery installs?

Yes. New version of patch should fix this.

http://codereview.chromium.org/10907104/diff/6015/chrome/browser/extensions/s...
File chrome/browser/extensions/startup_helper.cc (right):

http://codereview.chromium.org/10907104/diff/6015/chrome/browser/extensions/s...
chrome/browser/extensions/startup_helper.cc:100: return
base::Bind(&AppInstallHelper::OnAppInstallComplete,
On 2012/09/07 22:01:36, Mihai Parparita wrote:
> Why not do this inline in te WebstoreInlineInstaller call?

Done.

http://codereview.chromium.org/10907104/diff/6015/chrome/browser/extensions/s...
chrome/browser/extensions/startup_helper.cc:104: const std::string& error) {
On 2012/09/07 22:01:36, Mihai Parparita wrote:
> It would be nice to somehow propagate this error back to the return value of
> InstallAppFromId.

Done.

http://codereview.chromium.org/10907104/diff/6015/chrome/browser/extensions/s...
chrome/browser/extensions/startup_helper.cc:111:
scoped_ptr<content::WebContents> web_contents(
On 2012/09/07 22:01:36, Mihai Parparita wrote:
> Add a TODO about removing the need for this WebContents (I thought we had
> discussed how it wasn't strictly necessary)?

Done.

http://codereview.chromium.org/10907104/diff/6015/chrome/browser/extensions/w...
File chrome/browser/extensions/webstore_inline_installer.cc (right):

http://codereview.chromium.org/10907104/diff/6015/chrome/browser/extensions/w...
chrome/browser/extensions/webstore_inline_installer.cc:305:
CompleteInstall(kNotFromVerifiedSiteError);
On 2012/09/07 22:01:36, Mihai Parparita wrote:
> Seems like you'd want to ignore this error if require_verified_site_ is false.

Done.

http://codereview.chromium.org/10907104/diff/6015/chrome/browser/extensions/w...
File chrome/browser/extensions/webstore_inline_installer.h (right):

http://codereview.chromium.org/10907104/diff/6015/chrome/browser/extensions/w...
chrome/browser/extensions/webstore_inline_installer.h:36: class
WebstoreInlineInstaller
On 2012/09/07 22:01:36, Mihai Parparita wrote:
> Add a TODO about renaming this class, since it's no longer inline
> installation-specific. WebstoreStandaloneInstaller perhaps? (since it doesn't
> depend on the webstore web UI)

Done.

http://codereview.chromium.org/10907104/diff/6015/chrome/browser/extensions/w...
chrome/browser/extensions/webstore_inline_installer.h:47: typedef
base::Callback<void(bool success, const std::string& error)> Callback;
On 2012/09/07 22:01:36, Mihai Parparita wrote:
> This needs a base/callback.h #include.

Done.

http://codereview.chromium.org/10907104/diff/6015/chrome/browser/extensions/w...
chrome/browser/extensions/webstore_inline_installer.h:51: bool
require_verified_site,
On 2012/09/07 22:01:36, Mihai Parparita wrote:
> An enum param would be more readable.

Done.

http://codereview.chromium.org/10907104/diff/6015/chrome/common/chrome_switch...
File chrome/common/chrome_switches.cc (right):

http://codereview.chromium.org/10907104/diff/6015/chrome/common/chrome_switch...
chrome/common/chrome_switches.cc:94: // When passed on the command-line, this
causes chrome to attempt to download
On 2012/09/07 22:01:36, Mihai Parparita wrote:
> Nit: capitalize Chrome.

Done.

http://codereview.chromium.org/10907104/diff/6015/chrome/common/chrome_switch...
chrome/common/chrome_switches.cc:95: // and install an app from the webstore
with the given id.
On 2012/09/07 22:01:36, Mihai Parparita wrote:
> Mention that there's an install prompt too (i.e. this is not a silent
> installation flag).

Done.

http://codereview.chromium.org/10907104/diff/6015/chrome/common/chrome_switch...
chrome/common/chrome_switches.cc:96: const char kAppsInstallFromID[]    =
"apps-install-from-id";
On 2012/09/07 22:01:36, Mihai Parparita wrote:
> If it's not too late, I think "webstore" should be in the flag name somewhere
> (and in the StartupHelper method name).
> 
> Also, ID should probably be capitalized as "Id" (though we're not consistent
> elsewhere)

Done.

http://codereview.chromium.org/10907104/diff/14002/chrome/browser/extensions/...
File chrome/browser/extensions/webstore_inline_install_browsertest.cc (right):

http://codereview.chromium.org/10907104/diff/14002/chrome/browser/extensions/...
chrome/browser/extensions/webstore_inline_install_browsertest.cc:193:
switches::kInstallFromWebstore, kTestExtensionId);
FYI, I bailed on the approach of passing this command line flag in
SetUpCommandLine, because then there was no convenient hook to register to
listen for the NOTIFICATION_EXTENSION_INSTALLED notification (if I called Add on
the registrar_ in SetUpCommandLine, I get a crash because the
NotificationService isn't set up yet). 

An alternative would be to stash a static variable in StartupHelper with the
last install status, which I could then access, or to modify BrowserTestBase to
remember the result of BrowserMain(). 

The downside of doing it the way I currently am is that there ends up being a
Browser created, which isn't true in real world usage.

[Mihai Parparita -not on Chrome, 2012-09-16 06:37:37]

On Fri, Sep 14, 2012 at 4:24 PM, <[email protected]> wrote:
>
> FYI, I bailed on the approach of passing this command line flag in
> SetUpCommandLine, because then there was no convenient hook to register
> to listen for the NOTIFICATION_EXTENSION_**INSTALLED notification (if I
> called Add on the registrar_ in SetUpCommandLine, I get a crash because
> the NotificationService isn't set up yet).
>
> An alternative would be to stash a static variable in StartupHelper with
> the last install status, which I could then access, or to modify
> BrowserTestBase to remember the result of BrowserMain().
>
> The downside of doing it the way I currently am is that there ends up
> being a Browser created, which isn't true in real world usage.
>

Can you assert that when you get the NOTIFICATION_EXTENSION_INSTALLED
notification, no browser has been created yet?

Mihai

[Mihai Parparita -not on Chrome, 2012-09-16 06:42:38]

LGTM so that this is unblocked while I'm on vacation.

http://codereview.chromium.org/10907104/diff/5030/chrome/browser/extensions/s...
File chrome/browser/extensions/startup_helper.cc (right):

http://codereview.chromium.org/10907104/diff/5030/chrome/browser/extensions/s...
chrome/browser/extensions/startup_helper.cc:149: return helper.success();
To aid debugging, log helper.error() if success if false?

http://codereview.chromium.org/10907104/diff/5030/chrome/browser/extensions/w...
File chrome/browser/extensions/webstore_inline_installer.cc (right):

http://codereview.chromium.org/10907104/diff/5030/chrome/browser/extensions/w...
chrome/browser/extensions/webstore_inline_installer.cc:298: // Verified site is
required
Actually, this whole block should go into a if (require_verified_site_) check.
If an item doesn't have a verified site, then the web store response won't have
the key either.

http://codereview.chromium.org/10907104/diff/5030/chrome/browser/extensions/w...
chrome/browser/extensions/webstore_inline_installer.cc:370:
install_ui_.reset(new ExtensionInstallPrompt(NULL, web_contents(), profile));
If we don't pass in a parent, will the dialog still be centered correctly when
doing an actual inline install?

http://codereview.chromium.org/10907104/diff/5030/chrome/common/chrome_switch...
File chrome/common/chrome_switches.cc (right):

http://codereview.chromium.org/10907104/diff/5030/chrome/common/chrome_switch...
chrome/common/chrome_switches.cc:95: // app/extension id given, and then prompt
the user to download and install it.
Nit: capitalize ID.

[asargent_no_longer_on_chrome, 2012-09-17 05:11:45]

http://codereview.chromium.org/10907104/diff/5030/chrome/browser/extensions/s...
File chrome/browser/extensions/startup_helper.cc (right):

http://codereview.chromium.org/10907104/diff/5030/chrome/browser/extensions/s...
chrome/browser/extensions/startup_helper.cc:149: return helper.success();
On 2012/09/16 06:42:38, Mihai Parparita wrote:
> To aid debugging, log helper.error() if success if false?

Done.

http://codereview.chromium.org/10907104/diff/5030/chrome/browser/extensions/w...
File chrome/browser/extensions/webstore_inline_installer.cc (right):

http://codereview.chromium.org/10907104/diff/5030/chrome/browser/extensions/w...
chrome/browser/extensions/webstore_inline_installer.cc:298: // Verified site is
required
On 2012/09/16 06:42:38, Mihai Parparita wrote:
> Actually, this whole block should go into a if (require_verified_site_) check.
> If an item doesn't have a verified site, then the web store response won't
have
> the key either.

Good catch, done.

http://codereview.chromium.org/10907104/diff/5030/chrome/browser/extensions/w...
chrome/browser/extensions/webstore_inline_installer.cc:370:
install_ui_.reset(new ExtensionInstallPrompt(NULL, web_contents(), profile));
On 2012/09/16 06:42:38, Mihai Parparita wrote:
> If we don't pass in a parent, will the dialog still be centered correctly when
> doing an actual inline install?

It seems to be at least on Linux. I'll test on Windows and Mac as well.

http://codereview.chromium.org/10907104/diff/5030/chrome/common/chrome_switch...
File chrome/common/chrome_switches.cc (right):

http://codereview.chromium.org/10907104/diff/5030/chrome/common/chrome_switch...
chrome/common/chrome_switches.cc:95: // app/extension id given, and then prompt
the user to download and install it.
On 2012/09/16 06:42:38, Mihai Parparita wrote:
> Nit: capitalize ID.

Done.

[commit-bot: I haz the power, 2012-09-17 05:12:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/10907104/8015

[commit-bot: I haz the power, 2012-09-17 07:41:23]

Change committed as 157088