Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10917081: webui: Pass the desired scale factor to individual webui components (Closed)

Created:
8 years, 3 months ago by Nico
Modified:
8 years, 3 months ago
Reviewers:
pkotwicz
CC:
chromium-reviews, asanka, Randy Smith (Not in Mondays)
Visibility:
Public.

Description

webui: Pass the desired scale factor to individual webui components ChromeWebUIControllerFactory still always requests the 100P favicon, so no functionality change. BUG=145228 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=154958

Patch Set 1 #

Patch Set 2 : comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -46 lines) Patch
M chrome/browser/ui/webui/bookmarks_ui.h View 1 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/bookmarks_ui.cc View 1 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/chrome_web_ui_controller_factory.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc View 1 3 chunks +12 lines, -11 lines 0 comments Download
M chrome/browser/ui/webui/crashes_ui.h View 1 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/crashes_ui.cc View 1 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/downloads_ui.h View 1 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/downloads_ui.cc View 1 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/flags_ui.h View 1 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/flags_ui.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/flash_ui.h View 1 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/flash_ui.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/history_ui.h View 1 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/history_ui.cc View 1 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/options/options_ui.h View 1 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/options/options_ui.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/plugins_ui.h View 1 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/plugins_ui.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Nico
8 years, 3 months ago (2012-09-05 04:19:29 UTC) #1
pkotwicz
LGTM with Nits. Can you rename desired_scale_factor to scale_factor? It is true that LoadDataResourceBytes() falls ...
8 years, 3 months ago (2012-09-05 15:09:19 UTC) #2
Nico
Done, thanks.
8 years, 3 months ago (2012-09-05 15:30:31 UTC) #3
commit-bot: I haz the power
8 years, 3 months ago (2012-09-05 15:30:47 UTC) #4

Powered by Google App Engine
This is Rietveld 408576698