Add plumbing for flag: --disable-gesture-tap-highlight

Add plumbing for flag: --disable-gesture-tap-highlight

BUG=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=154762

[wjmaclean, 2012-08-30 18:58:00]

This CL plumbs a flag into webkit to allow command-line disabling of the new
link highlighting feature.

Not sure if I've included the correct owners here for review, please let me know
who I'm missing (not much overlap, so I picked two ...)

[wjmaclean, 2012-08-30 19:55:43]

On 2012/08/30 18:58:00, wjmaclean wrote:
> This CL plumbs a flag into webkit to allow command-line disabling of the new
> link highlighting feature.
> 
> Not sure if I've included the correct owners here for review, please let me
know
> who I'm missing (not much overlap, so I picked two ...)

Seems WebKit hasn't rolled ... will re-submit try jobs once it does.

[Jói, 2012-08-30 19:56:21]

LGTM

[Ben Goodger (Google), 2012-08-30 21:21:46]

lgtm

[commit-bot: I haz the power, 2012-08-31 15:41:27]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/10918009/1

[commit-bot: I haz the power, 2012-08-31 15:41:31]

Presubmit check for 10918009-1 failed and returned exit status 1.


Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    webkit
    content/common

Presubmit checks took 1.4s to calculate.

[wjmaclean, 2012-08-31 15:50:51]

Need review from two more owners please.

[jln (very slow on Chromium), 2012-08-31 18:35:36]

On 2012/08/31 15:50:51, wjmaclean wrote:
> Need review from two more owners please.

If you added me for content/common, I'm an OWNER there only for sandbox-related
stuff, sorry.

[wjmaclean, 2012-08-31 19:05:54]

On 2012/08/31 18:35:36, Julien Tinnes wrote:
> On 2012/08/31 15:50:51, wjmaclean wrote:
> > Need review from two more owners please.
> 
> If you added me for content/common, I'm an OWNER there only for
sandbox-related
> stuff, sorry.

Ugh, but *all* the OWNERS are sandbox related ... not very clear for someone
whose only interest is in plumbing a flag ... I'll try one of the others -
thanks.

[wjmaclean, 2012-08-31 19:07:07]

Justin, can you do an owners review? V. short.

[jamesr, 2012-08-31 19:07:37]

On 2012/08/31 19:07:07, wjmaclean wrote:
> Justin, can you do an owners review? V. short.

Is the patch in sandbox_policy.cc ?  I think you need to look at the parent
OWNERS

[jln (very slow on Chromium), 2012-08-31 19:08:59]

On 2012/08/31 19:07:37, jamesr wrote:
> On 2012/08/31 19:07:07, wjmaclean wrote:
> > Justin, can you do an owners review? V. short.
> 
> Is the patch in sandbox_policy.cc ?  I think you need to look at the parent
> OWNERS

Look that the OWNERS of content/, they are the true owners of content/common.

[wjmaclean, 2012-08-31 19:11:20]

On 2012/08/31 19:08:59, Julien Tinnes wrote:
> On 2012/08/31 19:07:37, jamesr wrote:
> > On 2012/08/31 19:07:07, wjmaclean wrote:
> > > Justin, can you do an owners review? V. short.
> > 
> > Is the patch in sandbox_policy.cc ?  I think you need to look at the parent
> > OWNERS
> 
> Look that the OWNERS of content/, they are the true owners of content/common.

Ahhh, interesting ... pre-submit sent me to content/common, and I thought that
meant content/common/OWNERS ... try, try again.

[wjmaclean, 2012-08-31 19:12:30]

Still looking for owners review for content/ ...

Cheers,

James

[darin (slow to review), 2012-08-31 22:47:34]

LGTM

[commit-bot: I haz the power, 2012-09-04 13:52:04]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/10918009/1

[commit-bot: I haz the power, 2012-09-04 16:38:14]

Change committed as 154762