Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 10919307: Move IndexedDBContext into the StoragePartition and ensure isolation. (Closed)

Created:
8 years, 3 months ago by awong
Modified:
8 years, 3 months ago
CC:
chromium-reviews, mihaip-chromium-reviews_chromium.org, jam, joi+watch-content_chromium.org, Aaron Boodman, darin-cc_chromium.org, markusheintz_
Visibility:
Public.

Description

Move IndexedDBContext into the StoragePartition and ensure isolation. This pickups up from http://codereview.chromium.org/10836216. After this, IndexedDB should be properly isolated in ChromeApps and Isolated Sites. TBR=kalman,sky,mkwst BUG=85121 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=157045

Patch Set 1 #

Patch Set 2 : Fix another unittest." #

Patch Set 3 : stupid lowercasing #

Total comments: 10

Patch Set 4 : nits addressed #

Patch Set 5 : merged ToT #

Patch Set 6 : rebased #

Patch Set 7 : remove useless include #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -41 lines) Patch
M chrome/browser/browsing_data/browsing_data_indexed_db_helper.h View 2 chunks +6 lines, -1 line 0 comments Download
M chrome/browser/browsing_data/browsing_data_indexed_db_helper.cc View 1 4 chunks +6 lines, -7 lines 0 comments Download
M chrome/browser/extensions/data_deleter.h View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/extensions/data_deleter.cc View 1 2 3 4 5 4 chunks +8 lines, -5 lines 0 comments Download
M chrome/browser/extensions/extension_service_unittest.cc View 2 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/options/cookies_view_handler.cc View 1 2 3 4 5 6 3 chunks +7 lines, -1 line 0 comments Download
M content/browser/browser_context.cc View 1 2 3 4 5 3 chunks +5 lines, -11 lines 0 comments Download
M content/browser/in_process_webkit/indexed_db_browsertest.cc View 1 2 3 1 chunk +3 lines, -2 lines 0 comments Download
M content/browser/in_process_webkit/indexed_db_quota_client_unittest.cc View 2 chunks +3 lines, -1 line 0 comments Download
M content/browser/in_process_webkit/indexed_db_unittest.cc View 4 chunks +7 lines, -3 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 2 3 4 5 1 chunk +4 lines, -3 lines 0 comments Download
M content/public/browser/browser_context.h View 1 2 3 4 5 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 13 (0 generated)
awong
Another one!
8 years, 3 months ago (2012-09-15 00:45:42 UTC) #1
Charlie Reis
Nice and simple. LGTM, with indent fixes. https://codereview.chromium.org/10919307/diff/9002/chrome/browser/extensions/data_deleter.cc File chrome/browser/extensions/data_deleter.cc (right): https://codereview.chromium.org/10919307/diff/9002/chrome/browser/extensions/data_deleter.cc#newcode91 chrome/browser/extensions/data_deleter.cc:91: BrowserContext::GetDefaultStoragePartition(profile); nit: ...
8 years, 3 months ago (2012-09-15 00:55:58 UTC) #2
awong
TBRing owners changes for kalman, sky, and mkwst because this is just a viral propagation ...
8 years, 3 months ago (2012-09-15 01:19:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/10919307/2003
8 years, 3 months ago (2012-09-15 01:20:08 UTC) #4
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build. Your ...
8 years, 3 months ago (2012-09-15 02:02:58 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/10919307/6004
8 years, 3 months ago (2012-09-15 02:38:08 UTC) #6
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build. Your ...
8 years, 3 months ago (2012-09-15 04:30:41 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/10919307/6004
8 years, 3 months ago (2012-09-15 05:18:58 UTC) #8
commit-bot: I haz the power
Failed to apply patch for content/browser/browser_context.cc: While running patch -p1 --forward --force; patching file content/browser/browser_context.cc ...
8 years, 3 months ago (2012-09-15 05:19:03 UTC) #9
Use mkwst_at_chromium.org plz.
browsing_data LGTM.
8 years, 3 months ago (2012-09-15 07:43:19 UTC) #10
Mike West
On 2012/09/15 07:43:19, Use mkwst_at_chromium.org. wrote: > browsing_data LGTM. Er. LGTM from the right account. ...
8 years, 3 months ago (2012-09-15 07:44:13 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/10919307/9030
8 years, 3 months ago (2012-09-16 05:26:29 UTC) #12
commit-bot: I haz the power
8 years, 3 months ago (2012-09-16 07:31:44 UTC) #13
Change committed as 157045

Powered by Google App Engine
This is Rietveld 408576698