Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 10941050: Second try of 157576 https://chromiumcodereview.appspot.com/10780013/ (Closed)

Created:
8 years, 3 months ago by Cem Kocagil
Modified:
8 years, 3 months ago
CC:
chromium-reviews, mihaip-chromium-reviews_chromium.org, jam, browser-components-watch_chromium.org, joi+watch-content_chromium.org, Aaron Boodman, darin-cc_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Second try of 157576 https://chromiumcodereview.appspot.com/10780013/ Add reverse URL handler for shortening uber URLs BUG=120493 TEST=Open the settings page. The address bar should show "chrome://settings". Click the "extensions" button on the left. The address bar should show "chrome://extensions". Click the "settings" button on the left, "show advanced settings", "content settings". The address bar should show "chrome://settings/content". Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=158504

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+161 lines, -19 lines) Patch
M chrome/browser/chrome_content_browser_client.cc View 1 3 chunks +65 lines, -2 lines 0 comments Download
A chrome/browser/chrome_content_browser_client_browsertest.cc View 1 1 chunk +54 lines, -0 lines 0 comments Download
M chrome/browser/extensions/lazy_background_page_apitest.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/history/history_browsertest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser_navigator_browsertest.cc View 1 14 chunks +27 lines, -14 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/web_contents/navigation_controller_impl.cc View 1 1 chunk +11 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Cem Kocagil
+ben: I haven't touched the files you reviewed last time (chrome_tests.gypi, browser_navigator_browsertest.cc, history_browsertest.cc, lazy_background_page_apitest.cc), can ...
8 years, 3 months ago (2012-09-19 22:23:56 UTC) #1
Alexei Svitkine (slow)
LGTM. I've sent off some try jobs for you.
8 years, 3 months ago (2012-09-20 14:41:24 UTC) #2
Charlie Reis
navigation_controller_impl.cc still LGTM.
8 years, 3 months ago (2012-09-20 17:11:35 UTC) #3
Ben Goodger (Google)
lgtm
8 years, 3 months ago (2012-09-24 16:56:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/10941050/2001
8 years, 3 months ago (2012-09-24 22:57:27 UTC) #5
commit-bot: I haz the power
8 years, 3 months ago (2012-09-25 03:06:28 UTC) #6
Change committed as 158504

Powered by Google App Engine
This is Rietveld 408576698