Make original_response_headers parameter of NetworkDelegate::OnHeadersReceived const

Make original_response_headers parameter of NetworkDelegate::OnHeadersReceived const


BUG=149890
[email protected],[email protected],[email protected]

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=163111

[battre, 2012-09-18 16:49:27]

Hi.

I had to close the previous CL and create a new one because my client would not
upload new versions of the CL anymore.

Best regards,
Dominic

[commit-bot: I haz the power, 2012-09-19 09:05:20]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a lowly provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[battre, 2012-09-19 09:05:52]

On 2012/09/19 09:05:20, I haz the power (commit-bot) wrote:
> No LGTM from a valid reviewer yet. Only full committers are accepted.
> Even if an LGTM may have been provided, it was from a non-committer or
> a lowly provisional committer, _not_ a full super star committer.
> See http://www.chromium.org/getting-involved/become-a-committer
> Note that this has nothing to do with OWNERS files.

sorry, tried to click on "Try more bots" :-(

[cbentzel, 2012-09-19 11:27:29]

LGTM

[battre, 2012-10-19 19:00:08]

Reviving this old CL.

TBR'ing for trivial changes (only making one parameter const):
webkit: [email protected]
android_webview/OWNERS: [email protected]
content/shell: [email protected]

[commit-bot: I haz the power, 2012-10-19 19:00:40]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/10944013/11001

[commit-bot: I haz the power, 2012-10-19 20:34:15]

Sorry for I got bad news for ya.
Compile failed with a clobber build.
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2012-10-19 22:11:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/10944013/11001

[commit-bot: I haz the power, 2012-10-20 00:42:34]

Change committed as 163111

[jochen (gone - plz use gerrit), 2012-10-20 02:04:13]

https://codereview.chromium.org/10944013/diff/11001/net/base/network_delegate.h
File net/base/network_delegate.h (right):

https://codereview.chromium.org/10944013/diff/11001/net/base/network_delegate...
net/base/network_delegate.h:76: const HttpResponseHeaders*
original_response_headers,
why are you making this a const ptr instead of a const ref?

[battre, 2012-10-20 09:49:56]

https://codereview.chromium.org/10944013/diff/11001/net/base/network_delegate.h
File net/base/network_delegate.h (right):

https://codereview.chromium.org/10944013/diff/11001/net/base/network_delegate...
net/base/network_delegate.h:76: const HttpResponseHeaders*
original_response_headers,
On 2012/10/20 02:04:13, jochen wrote:
> why are you making this a const ptr instead of a const ref?

like for URLRequest, you are allowed to hold on to the pointer if you are
careful about the life-time management. Pass by reference indicates in my mind
that you must not store a pointer to the element because it is only guaranteed
to be valid during the life-time of the call.