Rewrite Mod3Mask to ControlMask

Rewrite Mod3Mask to ControlMask.

BUG=chrome-os-partner:14339
TEST=./out/Debug/unit_tests --gtest_filter="*Fn*"
TEST=manual. Change all "F5" in /usr/share/X11/xkb/symbols/srvr_ctrl to "F15", remove all *.xkm cache files in /var/lib/xkb/, restart X by sign out/in, then press F5+n, F5+f, etc. Confirm that they works as Chrome/Ash shortcuts. Change the current layout to Neo2, then press F5+n. Confirm that it does not work as an Ash shortcut.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=157885

[Yusuke Sato, 2012-09-20 21:06:37]

Daniel, could you have a look at this?
(patches for xkeyboard-config and F14 are almost ready too.)

[Daniel Erat, 2012-09-20 21:12:45]

lgtm

http://codereview.chromium.org/10965008/diff/4002/chrome/browser/ui/ash/event...
File chrome/browser/ui/ash/event_rewriter.cc (right):

http://codereview.chromium.org/10965008/diff/4002/chrome/browser/ui/ash/event...
chrome/browser/ui/ash/event_rewriter.cc:513: "xkb:de:neo:ger") {
nit: mind moving this to a const value at the top of the file?

[Yusuke Sato, 2012-09-20 21:45:16]

http://codereview.chromium.org/10965008/diff/4002/chrome/browser/ui/ash/event...
File chrome/browser/ui/ash/event_rewriter.cc (right):

http://codereview.chromium.org/10965008/diff/4002/chrome/browser/ui/ash/event...
chrome/browser/ui/ash/event_rewriter.cc:513: "xkb:de:neo:ger") {
On 2012/09/20 21:12:46, Daniel Erat wrote:
> nit: mind moving this to a const value at the top of the file?

Done.

[commit-bot: I haz the power, 2012-09-20 22:22:10]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/10965008/2005

[commit-bot: I haz the power, 2012-09-21 01:03:47]

Change committed as 157885