alternate ntp: persist show-search-provider-logo option at chrome://instant

alternate ntp: persist show-search-provider-logo option at chrome://instant

- in the process, move registration of zero-suggest-provider-url pref to instant ui where registration of all prefs are consolidated

TBR=estade
BUG=150863
TEST=verify per bug rpt


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=158096

[kuan, 2012-09-20 20:45:38]

david, pls look at everything.
samarth, i moved registration of zero-suggest-provider-url to instant ui.
scott, i need approval for autocomplete and views subdir.
james, i need approval for webui subdir.

thanks.

[samarth, 2012-09-20 21:09:29]

lgtm

https://chromiumcodereview.appspot.com/10967022/diff/1/chrome/browser/autocom...
File chrome/browser/autocomplete/zero_suggest_provider.cc (right):

https://chromiumcodereview.appspot.com/10967022/diff/1/chrome/browser/autocom...
chrome/browser/autocomplete/zero_suggest_provider.cc:16: #include
"chrome/browser/prefs/pref_service.h"
nit: Do you still need this include?

[kuan, 2012-09-20 21:13:40]

https://chromiumcodereview.appspot.com/10967022/diff/1/chrome/browser/autocom...
File chrome/browser/autocomplete/zero_suggest_provider.cc (right):

https://chromiumcodereview.appspot.com/10967022/diff/1/chrome/browser/autocom...
chrome/browser/autocomplete/zero_suggest_provider.cc:16: #include
"chrome/browser/prefs/pref_service.h"
On 2012/09/20 21:09:29, samarth wrote:
> nit: Do you still need this include?

yeah, i tried removing it, but it's needed @38 "profile->GetPrefs()->GetString".

[dhollowa, 2012-09-20 21:25:02]

LGTM.  Thanks!

[sky, 2012-09-20 22:12:24]

LGTM

[kuan, 2012-09-21 16:33:03]

james, ping.. cld u ptal at webui files? thx.

[kuan, 2012-09-21 17:37:01]

evan, cld u pls provide owners' approval for webui files?  thx.

[kuan, 2012-09-21 20:12:49]

per discussion w/ dhollowa, i'm tbr'ing estade, and sending this to cq.

[commit-bot: I haz the power, 2012-09-21 20:13:07]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/10967022/4002

[commit-bot: I haz the power, 2012-09-21 22:28:48]

Change committed as 158096