Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Issue 11008017: cc: Never block on uploads from previous frame and increase max pending uploads. (Closed)

Created:
8 years, 2 months ago by reveman
Modified:
8 years, 2 months ago
Reviewers:
nduca, brianderson, piman
CC:
chromium-reviews, cc-bugs_chromium.org
Visibility:
Public.

Description

cc: Never block on uploads from previous frame and increase max pending uploads. By discarding pending uploads after drawing we allow multiple frames with reasonable amounts of uploads in the pipeline at the same time. Also increase maxPendingUpdateIntervals to allow an estimated 16ms of texture uploads per frame without blocking. BUG=152631 TEST=manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=159654

Patch Set 1 #

Patch Set 2 : Add unit test. #

Patch Set 3 : Set maxPendingUpdateIntervals to 4. #

Patch Set 4 : Rename numPendingUploads to numBlockingUploads and discardPendingUploads to markPendingUploadsAsNon… #

Unified diffs Side-by-side diffs Delta from patch set Stats (+109 lines, -27 lines) Patch
M cc/CCLayerTreeHostImpl.cpp View 1 2 3 2 chunks +5 lines, -0 lines 0 comments Download
M cc/CCTextureUpdateController.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M cc/CCTextureUpdateController.cpp View 1 2 3 2 chunks +7 lines, -7 lines 0 comments Download
M cc/TextureUploader.h View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M cc/ThrottledTextureUploader.h View 1 2 3 4 chunks +6 lines, -2 lines 0 comments Download
M cc/ThrottledTextureUploader.cpp View 1 2 3 6 chunks +33 lines, -5 lines 0 comments Download
M cc/ThrottledTextureUploaderTest.cpp View 1 2 3 2 chunks +41 lines, -7 lines 0 comments Download
M cc/UnthrottledTextureUploader.h View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M cc/UnthrottledTextureUploader.cpp View 1 2 3 1 chunk +5 lines, -1 line 0 comments Download
M cc/test/CCTiledLayerTestCommon.h View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M cc/test/CCTiledLayerTestCommon.cpp View 1 2 3 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
reveman
This should allow multiple frames in the pipeline, each with 16ms worth of estimated texture ...
8 years, 2 months ago (2012-09-30 19:45:38 UTC) #1
brianderson
couldn't tell from a quick look, which part of this patch increases the pending uploads ...
8 years, 2 months ago (2012-10-01 20:29:17 UTC) #2
reveman
On 2012/10/01 20:29:17, Brian Anderson wrote: > couldn't tell from a quick look, which part ...
8 years, 2 months ago (2012-10-01 21:55:29 UTC) #3
nduca
I just dont get this.
8 years, 2 months ago (2012-10-01 22:15:19 UTC) #4
nduca
LGTM but lets get a better name. NoLongerNeeded, Obsolete, Etc.
8 years, 2 months ago (2012-10-01 22:58:02 UTC) #5
nduca
lgtm
8 years, 2 months ago (2012-10-02 05:41:29 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/11008017/17001
8 years, 2 months ago (2012-10-02 05:42:38 UTC) #7
commit-bot: I haz the power
8 years, 2 months ago (2012-10-02 08:11:53 UTC) #8
Change committed as 159654

Powered by Google App Engine
This is Rietveld 408576698