Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 11016038: Removes BrowserContext::DidLastSessionExitCleanly() and makes (Closed)

Created:
8 years, 2 months ago by sky
Modified:
8 years, 2 months ago
Reviewers:
Avi (use Gerrit), sail
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, rdsmith+dwatch_chromium.org
Visibility:
Public.

Description

Removes BrowserContext::DidLastSessionExitCleanly() and makes NavigationController::Restore() take an enum instead that encapsculates this. BUG=90737 TEST=none [email protected],[email protected] Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=160052

Patch Set 1 #

Patch Set 2 : Comment #

Patch Set 3 : Fix android #

Patch Set 4 : content:: #

Unified diffs Side-by-side diffs Delta from patch set Stats (+103 lines, -69 lines) Patch
M chrome/browser/profiles/off_the_record_profile_impl.h View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/profiles/off_the_record_profile_impl.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/profiles/profile.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/profiles/profile_impl.h View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/profiles/profile_impl.cc View 2 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/sessions/session_restore_android.cc View 1 2 3 2 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/ui/browser_tabrestore.cc View 4 chunks +19 lines, -2 lines 0 comments Download
M chrome/browser/ui/startup/startup_browser_creator.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/base/testing_profile.h View 2 chunks +1 line, -1 line 0 comments Download
M chrome/test/base/testing_profile.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M content/browser/download/download_manager_impl_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/web_contents/navigation_controller_impl.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/web_contents/navigation_controller_impl.cc View 5 chunks +21 lines, -9 lines 0 comments Download
M content/browser/web_contents/navigation_controller_impl_unittest.cc View 2 chunks +8 lines, -4 lines 0 comments Download
M content/browser/web_contents/navigation_entry_impl.h View 1 chunk +3 lines, -2 lines 0 comments Download
M content/browser/web_contents/navigation_entry_impl_unittest.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/public/browser/browser_context.h View 1 chunk +0 lines, -4 lines 0 comments Download
M content/public/browser/navigation_controller.h View 2 chunks +16 lines, -7 lines 0 comments Download
M content/public/test/test_browser_context.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/test/test_browser_context.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M content/shell/shell_browser_context.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/shell/shell_browser_context.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
sky
8 years, 2 months ago (2012-10-03 21:38:08 UTC) #1
sky
avi: content sail: profiles
8 years, 2 months ago (2012-10-03 21:38:23 UTC) #2
sail
profiles/* LGTM!
8 years, 2 months ago (2012-10-03 21:43:40 UTC) #3
Avi (use Gerrit)
LGTM Note that this is bug 90737; please link that in your CL description.
8 years, 2 months ago (2012-10-03 22:23:42 UTC) #4
sky
I must have had the wrong thing on the clipboard. Thanks for noticing. -Scott On ...
8 years, 2 months ago (2012-10-03 22:40:57 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/11016038/2001
8 years, 2 months ago (2012-10-03 22:41:17 UTC) #6
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build. Your ...
8 years, 2 months ago (2012-10-03 23:04:48 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/11016038/1026
8 years, 2 months ago (2012-10-03 23:29:43 UTC) #8
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build. Your ...
8 years, 2 months ago (2012-10-03 23:49:38 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/11016038/10002
8 years, 2 months ago (2012-10-03 23:55:50 UTC) #10
commit-bot: I haz the power
8 years, 2 months ago (2012-10-04 02:26:39 UTC) #11
Change committed as 160052

Powered by Google App Engine
This is Rietveld 408576698