Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 11024004: Switch ConstrainedWindowTabHelper to use WebContentsUserData. (Closed)

Created:
8 years, 2 months ago by Avi (use Gerrit)
Modified:
8 years, 2 months ago
Reviewers:
sky
CC:
chromium-reviews, groby+watch_chromium.org, creis+watch_chromium.org, tfarina, samarth, sreeram, gideonwald, dominich, David Black, Jered, ajwong+watch_chromium.org, gbillock+watch_chromium.org, smckay+watch_chromium.org, rouslan+watch_chromium.org, Shishir
Visibility:
Public.

Description

Switch ConstrainedWindowTabHelper to use WebContentsUserData. BUG=107201 TEST=no visible change Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=159811

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : views #

Patch Set 4 : rebase #

Patch Set 5 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+152 lines, -118 lines) Patch
M chrome/browser/instant/instant_loader.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/repost_form_warning_browsertest.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/ssl/ssl_browser_tests.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/browser.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser.cc View 1 2 3 1 chunk +5 lines, -4 lines 0 comments Download
M chrome/browser/ui/browser_adoption.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/browser_commands.cc View 1 2 3 1 chunk +7 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_controller.mm View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/constrained_window/constrained_window_mac2.mm View 2 chunks +7 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/constrained_window_mac.mm View 2 chunks +7 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm View 1 2 3 1 chunk +8 lines, -5 lines 0 comments Download
M chrome/browser/ui/constrained_window_tab_helper.h View 3 chunks +10 lines, -9 lines 0 comments Download
M chrome/browser/ui/constrained_window_tab_helper.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/ui/constrained_window_tab_helper_delegate.h View 1 chunk +7 lines, -7 lines 0 comments Download
M chrome/browser/ui/constrained_window_tab_helper_delegate.cc View 1 chunk +1 line, -5 lines 0 comments Download
M chrome/browser/ui/constrained_window_tab_helper_unittest.cc View 2 chunks +10 lines, -6 lines 0 comments Download
M chrome/browser/ui/gtk/constrained_window_gtk.cc View 3 chunks +10 lines, -3 lines 0 comments Download
M chrome/browser/ui/intents/web_intent_picker_controller.cc View 1 2 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/ui/tab_contents/tab_contents.h View 1 2 3 3 chunks +0 lines, -6 lines 0 comments Download
M chrome/browser/ui/tab_contents/tab_contents.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/collected_cookies_views.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/constrained_web_dialog_delegate_views.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/constrained_window_views.h View 1 2 3 chunks +7 lines, -6 lines 0 comments Download
M chrome/browser/ui/views/constrained_window_views.cc View 1 2 3 4 5 chunks +15 lines, -13 lines 0 comments Download
M chrome/browser/ui/views/constrained_window_views_browsertest.cc View 1 2 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/extensions/media_galleries_dialog_views.cc View 1 2 3 4 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/ui/views/login_prompt_views.cc View 1 2 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/ui/views/ssl_client_certificate_selector.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/tab_contents/chrome_web_contents_view_delegate_views.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M chrome/browser/ui/views/tab_modal_confirm_dialog_views.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/web_intent_picker_views.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/constrained_web_dialog_ui_browsertest.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/print_preview/print_preview_ui_unittest.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 16 (0 generated)
Avi (use Gerrit)
8 years, 2 months ago (2012-09-30 20:30:14 UTC) #1
sky
LGTM
8 years, 2 months ago (2012-10-01 14:36:23 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/11024004/1
8 years, 2 months ago (2012-10-01 15:19:06 UTC) #3
commit-bot: I haz the power
Retried try job too often for step(s) crypto_unittests, unit_tests, cacheinvalidation_unittests, remoting_unittests, jingle_unittests, nacl_integration, ipc_tests, interactive_ui_tests, ...
8 years, 2 months ago (2012-10-01 15:23:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/11024004/1
8 years, 2 months ago (2012-10-01 19:24:33 UTC) #5
commit-bot: I haz the power
Retried try job too often for step(s) interactive_ui_tests, jingle_unittests, gpu_unittests, base_unittests, sync_integration_tests, sql_unittests, chrome_frame_unittests, content_unittests, ...
8 years, 2 months ago (2012-10-01 21:27:46 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/11024004/7002
8 years, 2 months ago (2012-10-01 21:32:41 UTC) #7
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build. Your ...
8 years, 2 months ago (2012-10-01 23:19:52 UTC) #8
Avi (use Gerrit)
PTAL Switched ConstrainedWindowViews to take a WebContents rather than TabContents.
8 years, 2 months ago (2012-10-01 23:49:29 UTC) #9
sky
SLGTM
8 years, 2 months ago (2012-10-01 23:57:22 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/11024004/8004
8 years, 2 months ago (2012-10-01 23:58:21 UTC) #11
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build. Your ...
8 years, 2 months ago (2012-10-02 00:45:35 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/11024004/6044
8 years, 2 months ago (2012-10-02 14:39:22 UTC) #13
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build. Your ...
8 years, 2 months ago (2012-10-02 15:12:17 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/11024004/19001
8 years, 2 months ago (2012-10-02 21:59:06 UTC) #15
commit-bot: I haz the power
8 years, 2 months ago (2012-10-03 00:27:30 UTC) #16
Change committed as 159811

Powered by Google App Engine
This is Rietveld 408576698