Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11065041: [cros login] Add new password changed dialog, enabled by default (Closed)

Created:
8 years, 2 months ago by Nikita (slow)
Modified:
8 years ago
Reviewers:
sky, Ivan Korotkov
CC:
chromium-reviews, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

[cros login] Add new password changed dialog, enabled by default * Change order for some methods (sort). BUG=124699 TBR=sky Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=173021

Patch Set 1 #

Patch Set 2 : merge #

Patch Set 3 : fix merge #

Patch Set 4 : m #

Patch Set 5 : merge #

Patch Set 6 : integrate #

Patch Set 7 : cleanup #

Total comments: 8

Patch Set 8 : fixes #

Patch Set 9 : . #

Patch Set 10 : fix test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+612 lines, -82 lines) Patch
M chrome/app/chromeos_strings.grdp View 1 2 3 4 5 6 7 1 chunk +21 lines, -0 lines 0 comments Download
M chrome/app/generated_resources.grd View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 2 3 4 5 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/existing_user_controller.h View 1 2 3 4 5 1 chunk +6 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/existing_user_controller.cc View 1 2 3 4 5 6 7 7 chunks +45 lines, -25 lines 0 comments Download
M chrome/browser/chromeos/login/existing_user_controller_browsertest.cc View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/login/login_display.h View 1 2 3 4 5 4 chunks +26 lines, -11 lines 0 comments Download
M chrome/browser/chromeos/login/webui_login_display.h View 1 2 3 4 5 2 chunks +6 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/webui_login_display.cc View 1 2 3 4 5 4 chunks +29 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/login/webui_screen_locker.h View 1 2 3 4 5 1 chunk +6 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/webui_screen_locker.cc View 1 2 3 4 5 4 chunks +21 lines, -9 lines 0 comments Download
M chrome/browser/resources/chromeos/login/display_manager.js View 1 2 3 4 5 2 chunks +9 lines, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/login/login.html View 1 2 3 4 5 3 chunks +3 lines, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/login/login.js View 1 2 3 4 5 2 chunks +9 lines, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/login/oobe.css View 1 2 3 4 5 3 chunks +6 lines, -3 lines 0 comments Download
M chrome/browser/resources/chromeos/login/oobe.html View 1 2 3 4 5 3 chunks +3 lines, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/login/oobe.js View 1 2 3 4 5 2 chunks +9 lines, -0 lines 0 comments Download
A chrome/browser/resources/chromeos/login/screen_password_changed.css View 1 2 3 4 5 6 7 1 chunk +90 lines, -0 lines 0 comments Download
A chrome/browser/resources/chromeos/login/screen_password_changed.html View 1 2 3 4 5 1 chunk +22 lines, -0 lines 0 comments Download
A chrome/browser/resources/chromeos/login/screen_password_changed.js View 1 2 3 4 5 6 7 8 1 chunk +181 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/signin_screen_handler.h View 1 2 3 4 5 7 chunks +24 lines, -8 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc View 1 2 3 4 5 6 7 6 chunks +77 lines, -12 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/chrome_switches.cc View 1 2 3 4 5 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Nikita (slow)
I'm still testing and there would couple of small fixes but overall CL is ready ...
8 years ago (2012-12-13 14:08:35 UTC) #1
Nikita (slow)
Most of the new code is in chromeos/login/screen_password_changed.* Rest is either plumbing / switches or ...
8 years ago (2012-12-13 14:09:36 UTC) #2
Ivan Korotkov
lgtm https://codereview.chromium.org/11065041/diff/14001/chrome/app/chromeos_strings.grdp File chrome/app/chromeos_strings.grdp (right): https://codereview.chromium.org/11065041/diff/14001/chrome/app/chromeos_strings.grdp#newcode354 chrome/app/chromeos_strings.grdp:354: <message name="IDS_LOGIN_PASSWORD_CHANGED_CANT_REMEMBER" desc="Link that lets user skip old ...
8 years ago (2012-12-13 15:11:32 UTC) #3
Nikita (slow)
https://codereview.chromium.org/11065041/diff/14001/chrome/app/chromeos_strings.grdp File chrome/app/chromeos_strings.grdp (right): https://codereview.chromium.org/11065041/diff/14001/chrome/app/chromeos_strings.grdp#newcode354 chrome/app/chromeos_strings.grdp:354: <message name="IDS_LOGIN_PASSWORD_CHANGED_CANT_REMEMBER" desc="Link that lets user skip old password ...
8 years ago (2012-12-13 16:48:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/11065041/15050
8 years ago (2012-12-13 20:37:35 UTC) #5
commit-bot: I haz the power
Presubmit check for 11065041-15050 failed and returned exit status 1. Running presubmit commit checks ...
8 years ago (2012-12-13 20:37:51 UTC) #6
Nikita (slow)
TBR'ing sky@ for chrome/browser/about_flags.cc
8 years ago (2012-12-13 21:17:28 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/11065041/15050
8 years ago (2012-12-13 21:20:09 UTC) #8
commit-bot: I haz the power
8 years ago (2012-12-14 00:40:48 UTC) #9
Message was sent while issue was closed. 
Change committed as 173021

Powered by Google App Engine
This is Rietveld 408576698