Remove deprecated function.

1. Create ApiFunction, which is a new base class of AsyncApiFunction that is intended to do all its work on the UI thread. Motivation is Notification API.

2. While refactoring AsyncApiFunction, get rid of DeprecatedExtractSrcId().

3. Notice that in the process of migrating usb_api.cc to the non-deprecated ExtractSrcId(), USB tests broke. Wonder why that is, because the new code is exactly like Socket/Serial's usage of ExtractSrcId().

4. Realize that Socket/Serial have stopped using ApiResourceEventNotifier long, long ago (probably when Peng refactored the callback design), and that ExtractSrcId() broke when Antony and I refactored the JSON compiler into the IDL compiler (by which point nobody was using ExtractSrcId() anymore). It's also possible that I cargo-culted my own code from Socket into Serial, where it languished unused.

5. After discussion with Antony, fix ExtractSrcId() by making srcId explicit in the IDL.

6. Remove all traces of src_id and event_notifier in serial/socket.

7. Remove the original introduction of ApiFunction and submit this CL on its own.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=161237

[bryeung, 2012-10-10 18:15:42]

Looks like a great simplification.

usb changes lgtm

[asargent_no_longer_on_chrome, 2012-10-10 21:28:59]

LGTM w/ 1 nit

http://codereview.chromium.org/11088044/diff/1/chrome/browser/extensions/api/...
File chrome/browser/extensions/api/api_function.h (right):

http://codereview.chromium.org/11088044/diff/1/chrome/browser/extensions/api/...
chrome/browser/extensions/api/api_function.h:15: class ApiFunction : public
UIThreadExtensionFunction {
nit: Adding this class seems unrelated to the rest of the stuff in this CL,
since you don't actually use it anywhere - would it make sense to split out into
its own CL?

[Mihai Parparita -not on Chrome, 2012-10-10 21:33:11]

On Wed, Oct 10, 2012 at 2:29 PM, <[email protected]> wrote:

> http://codereview.chromium.**org/11088044/diff/1/chrome/**
>
browser/extensions/api/api_**function.h#newcode15<http://codereview.chromium.org/11088044/diff/1/chrome/browser/extensions/api/api_function.h#newcode15>
> chrome/browser/extensions/api/**api_function.h:15: class ApiFunction :
> public UIThreadExtensionFunction {
> nit: Adding this class seems unrelated to the rest of the stuff in this
> CL, since you don't actually use it anywhere - would it make sense to
> split out into its own CL?
>

+1 to this. Also, you may want to add Aaron on that review, since based on
http://codereview.chromium.org/11038021/diff/1/chrome/browser/extensions/api/...
his most recent emails on
http://codereview.chromium.org/9317065/ he had an opinion about the
ExtensionFunction class hierarchy.

Mihai

[commit-bot: I haz the power, 2012-10-10 21:59:35]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/11088044/4002

[commit-bot: I haz the power, 2012-10-11 00:03:42]

Commit queue rejected this change because the description was changed
between the time the change entered the commit queue and the time it
was ready to commit. You can safely check the commit box again.

[commit-bot: I haz the power, 2012-10-11 00:05:55]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/11088044/4002

[commit-bot: I haz the power, 2012-10-11 00:06:25]

Change committed as 161237

[miket_OOO, 2012-10-11 16:26:36]

On 2012/10/11 00:06:25, I haz the power (commit-bot) wrote:
> Change committed as 161237

Thanks for watching this, Mihai. The behavior is much better than it used to be,
when it would re-run all the try jobs, regardless of greenness.