Histogram argument related change

Histogram argument related change

1. HistogramBase supports HasConstructionArguments.
2. Move Histogram::InspectConstructionArguments() to public, so chromeos
does not need to extend Histogram to do arguments checking.

Also grouped OVERRIDE functions in histogram.cc/h together.

[email protected]


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=163788

[kaiwang, 2012-10-23 22:46:46]

ping...

[kaiwang, 2012-10-23 23:32:30]

I think I forgot to publish this CL... Anyway please help to review it, thanks a
lot!

[Ilya Sherman, 2012-10-24 00:30:08]

LGTM

http://codereview.chromium.org/11231025/diff/1/base/metrics/histogram_base.h
File base/metrics/histogram_base.h (right):

http://codereview.chromium.org/11231025/diff/1/base/metrics/histogram_base.h#...
base/metrics/histogram_base.h:54: virtual bool HasConstructionArguments(Sample
minimum,
nit: Please add a comment describing this method.

http://codereview.chromium.org/11231025/diff/1/base/metrics/sparse_histogram.h
File base/metrics/sparse_histogram.h (right):

http://codereview.chromium.org/11231025/diff/1/base/metrics/sparse_histogram....
base/metrics/sparse_histogram.h:30: 
nit: Spurious newline

[zel, 2012-10-24 01:11:00]

+hshi@

http://codereview.chromium.org/11231025/diff/1/chrome/browser/chromeos/extern...
File chrome/browser/chromeos/external_metrics.cc (left):

http://codereview.chromium.org/11231025/diff/1/chrome/browser/chromeos/extern...
chrome/browser/chromeos/external_metrics.cc:38: class SystemHistogram : public
base::Histogram {
You can get rid of this class now and just expose CheckValues() and
CheckLinearValues() as functions.

[hshi1, 2012-10-24 01:13:09]

On 2012/10/24 01:11:00, zel wrote:
> +hshi@
> 
>
http://codereview.chromium.org/11231025/diff/1/chrome/browser/chromeos/extern...
> File chrome/browser/chromeos/external_metrics.cc (left):
> 
>
http://codereview.chromium.org/11231025/diff/1/chrome/browser/chromeos/extern...
> chrome/browser/chromeos/external_metrics.cc:38: class SystemHistogram : public
> base::Histogram {
> You can get rid of this class now and just expose CheckValues() and
> CheckLinearValues() as functions.

Agreed -- the class SystemHistogram was introduced just to work around the
protected function InspectConstructionArguments; now that it is public it is no
longer necessary to have this class.

[kaiwang, 2012-10-24 03:43:28]

Thanks for your quick review!

http://codereview.chromium.org/11231025/diff/1/base/metrics/histogram_base.h
File base/metrics/histogram_base.h (right):

http://codereview.chromium.org/11231025/diff/1/base/metrics/histogram_base.h#...
base/metrics/histogram_base.h:54: virtual bool HasConstructionArguments(Sample
minimum,
On 2012/10/24 00:30:08, Ilya Sherman wrote:
> nit: Please add a comment describing this method.

Done.

http://codereview.chromium.org/11231025/diff/1/base/metrics/sparse_histogram.h
File base/metrics/sparse_histogram.h (right):

http://codereview.chromium.org/11231025/diff/1/base/metrics/sparse_histogram....
base/metrics/sparse_histogram.h:30: 
On 2012/10/24 00:30:08, Ilya Sherman wrote:
> nit: Spurious newline

Done.

http://codereview.chromium.org/11231025/diff/1/chrome/browser/chromeos/extern...
File chrome/browser/chromeos/external_metrics.cc (left):

http://codereview.chromium.org/11231025/diff/1/chrome/browser/chromeos/extern...
chrome/browser/chromeos/external_metrics.cc:38: class SystemHistogram : public
base::Histogram {
On 2012/10/24 01:11:00, zel wrote:
> You can get rid of this class now and just expose CheckValues() and
> CheckLinearValues() as functions.

Done.

[hshi1, 2012-10-24 04:06:44]

external_metrics.cc: LGTM. Thanks!

[commit-bot: I haz the power, 2012-10-24 06:08:03]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/11231025/13001

[commit-bot: I haz the power, 2012-10-24 06:08:08]

Presubmit check for 11231025-13001 failed and returned exit status 1.


Running presubmit commit checks ...

** Presubmit Messages **
If this change has an associated bug, add BUG=[bug number].

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    chrome/browser/chromeos

Presubmit checks took 1.1s to calculate.

[commit-bot: I haz the power, 2012-10-24 06:15:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/11231025/13001

[commit-bot: I haz the power, 2012-10-24 08:18:54]

Change committed as 163788