Fix extension event dispatch for split mode extensions.

Fix extension event dispatch for split mode extensions.

Previously extensions with loaded background pages that were also split
mode (i.e. with an unloaded incognito mode background page) would not
receive events.

BUG=156484
TEST=on ChromeOS, the calculator app can be closed and immediately reopened


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=164339

[Matt Perry, 2012-10-25 21:00:03]

https://codereview.chromium.org/11260041/diff/6/chrome/browser/extensions/eve...
File chrome/browser/extensions/event_router.cc (right):

https://codereview.chromium.org/11260041/diff/6/chrome/browser/extensions/eve...
chrome/browser/extensions/event_router.cc:88: EventDispatchIdentifier;
I would make this a pair of Profile, extensionId. That way you don't have to
deal with the NULL bg host case. (And you won't need this helper function.)

https://codereview.chromium.org/11260041/diff/6/chrome/browser/extensions/eve...
chrome/browser/extensions/event_router.cc:438:
DispatchLazyEvent(listener->extension_id, event));
How about just passing &already_dispatched to this method. Then you don't need
to merge the sets afterwards.

[bryeung, 2012-10-25 21:21:25]

Great suggestions: thank you.

They're all incorporated.  PTAL

[Matt Perry, 2012-10-25 21:35:27]

LGTM

https://codereview.chromium.org/11260041/diff/10001/chrome/browser/extensions...
File chrome/browser/extensions/event_router.cc (right):

https://codereview.chromium.org/11260041/diff/10001/chrome/browser/extensions...
chrome/browser/extensions/event_router.cc:444: 
nit: rm extra newline

[commit-bot: I haz the power, 2012-10-26 15:54:19]

Change committed as 164339