Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11348125: Rename ipc_consts.h to ipc_constants.h (Closed)

Created:
8 years, 1 month ago by Wez
Modified:
8 years, 1 month ago
CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, rmsousa+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix #endif comment. #

Patch Set 3 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -78 lines) Patch
M remoting/host/daemon_process_win.cc View 1 chunk +1 line, -1 line 0 comments Download
A + remoting/host/ipc_constants.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + remoting/host/ipc_constants.cc View 1 chunk +1 line, -1 line 0 comments Download
D remoting/host/ipc_consts.h View 1 chunk +0 lines, -27 lines 0 comments Download
D remoting/host/ipc_consts.cc View 1 chunk +0 lines, -38 lines 0 comments Download
M remoting/host/remoting_me2me_host.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/win/unprivileged_process_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/win/wts_console_session_process_driver.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/win/wts_session_process_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/remoting.gyp View 1 2 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Wez
Minor file rename.
8 years, 1 month ago (2012-11-19 19:24:33 UTC) #1
alexeypa (please no reviews)
lgtm https://chromiumcodereview.appspot.com/11348125/diff/1/remoting/host/ipc_constants.h File remoting/host/ipc_constants.h (right): https://chromiumcodereview.appspot.com/11348125/diff/1/remoting/host/ipc_constants.h#newcode27 remoting/host/ipc_constants.h:27: #endif // REMOTING_HOST_IPC_CONSTS_H_ nit: REMOTING_HOST_IPC_CONSTANTS_H_
8 years, 1 month ago (2012-11-19 19:35:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/11348125/4001
8 years, 1 month ago (2012-11-19 20:11:40 UTC) #3
Wez
https://chromiumcodereview.appspot.com/11348125/diff/1/remoting/host/ipc_constants.h File remoting/host/ipc_constants.h (right): https://chromiumcodereview.appspot.com/11348125/diff/1/remoting/host/ipc_constants.h#newcode27 remoting/host/ipc_constants.h:27: #endif // REMOTING_HOST_IPC_CONSTS_H_ On 2012/11/19 19:35:03, alexeypa wrote: > ...
8 years, 1 month ago (2012-11-19 20:46:05 UTC) #4
commit-bot: I haz the power
Retried try job too often for step(s) content_browsertests
8 years, 1 month ago (2012-11-19 21:20:31 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/11348125/4001
8 years, 1 month ago (2012-11-19 23:00:21 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/11348125/9002
8 years, 1 month ago (2012-11-20 07:10:06 UTC) #7
commit-bot: I haz the power
8 years, 1 month ago (2012-11-20 09:00:44 UTC) #8 
Change committed as 168765

Powered by Google App Engine
This is Rietveld 408576698