Changing Autofill implementation for android.

Changing Autofill implementation for android.

Changing Autofill implementation to better match gtk linux implementation.

BUG=160593
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=168408

[aurimas (slooooooooow), 2012-11-09 17:55:46]

Hey Chris,

Could you take a look at my first try on the move to use autofill_popup_view for
Android? I am having issues with dismissing the popup. After calling the
AutofillExternalDelegate::HideAutofillPopup() a new popup is constructed. Can
you see what the issue could be?

Aurimas

[csharp, 2012-11-09 18:56:48]

I"m not sure exactly why a new popup is appearing, but that sounds similar to an
earlier issue I had encountered. Basically the problem was that the
autofillpopup sent the rpc to fill in the text with the selected value, the
autofill agent (in the renderer process) thought that this was the user
modifying the box by hand, so it showed a new popup.

https://chromiumcodereview.appspot.com/10442105 was landed to fix this problem,
but I'm guessing that there is some difference for android that causes this to
no work.

https://codereview.chromium.org/11364179/diff/1/chrome/browser/ui/android/aut...
File chrome/browser/ui/android/autofill/autofill_external_delegate.cc (right):

https://codereview.chromium.org/11364179/diff/1/chrome/browser/ui/android/aut...
chrome/browser/ui/android/autofill/autofill_external_delegate.cc:37:
view_->Show(autofill_values,
Add a call to CreateViewIfNeeded before this (this works as is for now because
of a bug I'm fixing right now)

[aurimas (slooooooooow), 2012-11-09 19:30:07]

I realized that the popup was not dismissed properly even before my change. I
will try to look at the CL you mentioned.

See comments below:

https://codereview.chromium.org/11364179/diff/1/chrome/browser/ui/android/aut...
File chrome/browser/ui/android/autofill/autofill_external_delegate.cc (right):

https://codereview.chromium.org/11364179/diff/1/chrome/browser/ui/android/aut...
chrome/browser/ui/android/autofill/autofill_external_delegate.cc:37:
view_->Show(autofill_values,
On 2012/11/09 18:56:48, csharp wrote:
> Add a call to CreateViewIfNeeded before this (this works as is for now because
> of a bug I'm fixing right now)

I was under impression that setBounds is always called before
ApplyAutofillSuggestions. Is that not true? Otherwise where do you place the
popup?

[csharp, 2012-11-09 20:18:21]

https://codereview.chromium.org/11364179/diff/1/chrome/browser/ui/android/aut...
File chrome/browser/ui/android/autofill/autofill_external_delegate.cc (right):

https://codereview.chromium.org/11364179/diff/1/chrome/browser/ui/android/aut...
chrome/browser/ui/android/autofill/autofill_external_delegate.cc:37:
view_->Show(autofill_values,
On 2012/11/09 19:30:07, aurimas wrote:
> On 2012/11/09 18:56:48, csharp wrote:
> > Add a call to CreateViewIfNeeded before this (this works as is for now
because
> > of a bug I'm fixing right now)
> 
> I was under impression that setBounds is always called before
> ApplyAutofillSuggestions. Is that not true? Otherwise where do you place the
> popup?

The setbounds in the delegate is getting renamed, since it is actually setting
the bounds of the text box that will be filled by the popup. The placing of the
popup should be done by ShowInternal

[aurimas (slooooooooow), 2012-11-09 22:30:46]

Hey Ted,

Could you take a look at this CL?

Aurimas

[Ted C, 2012-11-13 19:29:55]

https://chromiumcodereview.appspot.com/11364179/diff/10002/chrome/android/jav...
File
chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillPopup.java
(right):

https://chromiumcodereview.appspot.com/11364179/diff/10002/chrome/android/jav...
chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillPopup.java:43:
* An interface that an Autofill callback object has to implement.
This isn't a particularly helpful comment.  It doesn't describe the purpose of
the class.

https://chromiumcodereview.appspot.com/11364179/diff/10002/chrome/android/jav...
chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillPopup.java:45:
public interface AutofillCallback {
This name seems odd to me.  Callback to me doesn't imply it should do any work,
but something that should be notified of something occurring.

Something like AutofillPopupDelegate or some other kind of garbage.

https://chromiumcodereview.appspot.com/11364179/diff/10002/chrome/android/jav...
chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillPopup.java:105:
setOnItemClickListener(new AdapterView.OnItemClickListener() {
As a bit of cleanup, you might want to make this class implement
AdapterView.OnItemClickListener, then you avoid an additional generated class
definition.

Then it would just be setOnItemClickListener(this);

https://chromiumcodereview.appspot.com/11364179/diff/10002/chrome/android/jav...
chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillPopup.java:200:
public void setAnchorRect(float x, float y, float width, float height) {
javadoc all public methods

https://chromiumcodereview.appspot.com/11364179/diff/10002/chrome/android/jav...
File
chrome/android/javatests/src/org/chromium/chrome/browser/test/AutofillTest.java
(right):

https://chromiumcodereview.appspot.com/11364179/diff/10002/chrome/android/jav...
chrome/android/javatests/src/org/chromium/chrome/browser/test/AutofillTest.java:40:
* Tests the Autofill's java code for creating the AutofillExternalDelegate,
opening and closing
AutofillExternalDelegate doesn't exist anymore

https://chromiumcodereview.appspot.com/11364179/diff/10002/chrome/android/tes...
File
chrome/android/testshell/java/src/org/chromium/chrome/testshell/ChromiumTestShellActivity.java
(right):

https://chromiumcodereview.appspot.com/11364179/diff/10002/chrome/android/tes...
chrome/android/testshell/java/src/org/chromium/chrome/testshell/ChromiumTestShellActivity.java:126:
* @return
return what?  The suspense is killing me!!!!

https://chromiumcodereview.appspot.com/11364179/diff/10002/chrome/browser/aut...
File chrome/browser/autofill/autofill_popup_view.cc (right):

https://chromiumcodereview.appspot.com/11364179/diff/10002/chrome/browser/aut...
chrome/browser/autofill/autofill_popup_view.cc:72: label_font_ =
value_font_.DeriveFont(kLabelFontSizeDelta);
should label_font_ be ifdefed out in the header?

https://chromiumcodereview.appspot.com/11364179/diff/10002/chrome/browser/ui/...
File chrome/browser/ui/android/autofill/autofill_external_delegate.h (right):

https://chromiumcodereview.appspot.com/11364179/diff/10002/chrome/browser/ui/...
chrome/browser/ui/android/autofill/autofill_external_delegate.h:10: #include
"ui/gfx/native_widget_types.h"
Where is this needed?

https://chromiumcodereview.appspot.com/11364179/diff/10002/chrome/browser/ui/...
File chrome/browser/ui/android/autofill/autofill_popup_view_android.h (right):

https://chromiumcodereview.appspot.com/11364179/diff/10002/chrome/browser/ui/...
chrome/browser/ui/android/autofill/autofill_popup_view_android.h:37: jobject
obj);
these can fit on the same line, so no need to have this on the second.

https://chromiumcodereview.appspot.com/11364179/diff/10002/content/public/tes...
File
content/public/test/android/javatests/src/org/chromium/content/browser/test/util/TouchCommon.java
(right):

https://chromiumcodereview.appspot.com/11364179/diff/10002/content/public/tes...
content/public/test/android/javatests/src/org/chromium/content/browser/test/util/TouchCommon.java:189:
private void dispatchTouchEvent(final MotionEvent event) {
have this method call your new method like:

dispatchTouchEvent(mActivityTestCase.getActivity().findViewById(android.R.id.content).getRootView()),
event);

[aurimas (slooooooooow), 2012-11-13 22:13:12]

Hey Ted,

Fixed everything except for autofill_popup_view.cc:72 comment. Can you look at
it below?

Aurimas

https://chromiumcodereview.appspot.com/11364179/diff/10002/chrome/android/jav...
File
chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillPopup.java
(right):

https://chromiumcodereview.appspot.com/11364179/diff/10002/chrome/android/jav...
chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillPopup.java:43:
* An interface that an Autofill callback object has to implement.
On 2012/11/13 19:29:55, Ted C wrote:
> This isn't a particularly helpful comment.  It doesn't describe the purpose of
> the class.

Done.

https://chromiumcodereview.appspot.com/11364179/diff/10002/chrome/android/jav...
chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillPopup.java:45:
public interface AutofillCallback {
On 2012/11/13 19:29:55, Ted C wrote:
> This name seems odd to me.  Callback to me doesn't imply it should do any
work,
> but something that should be notified of something occurring.
> 
> Something like AutofillPopupDelegate or some other kind of garbage.

Done.

https://chromiumcodereview.appspot.com/11364179/diff/10002/chrome/android/jav...
chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillPopup.java:105:
setOnItemClickListener(new AdapterView.OnItemClickListener() {
On 2012/11/13 19:29:55, Ted C wrote:
> As a bit of cleanup, you might want to make this class implement
> AdapterView.OnItemClickListener, then you avoid an additional generated class
> definition.
> 
> Then it would just be setOnItemClickListener(this);

Done.

https://chromiumcodereview.appspot.com/11364179/diff/10002/chrome/android/jav...
chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillPopup.java:200:
public void setAnchorRect(float x, float y, float width, float height) {
On 2012/11/13 19:29:55, Ted C wrote:
> javadoc all public methods

Done.

https://chromiumcodereview.appspot.com/11364179/diff/10002/chrome/android/jav...
File
chrome/android/javatests/src/org/chromium/chrome/browser/test/AutofillTest.java
(right):

https://chromiumcodereview.appspot.com/11364179/diff/10002/chrome/android/jav...
chrome/android/javatests/src/org/chromium/chrome/browser/test/AutofillTest.java:40:
* Tests the Autofill's java code for creating the AutofillExternalDelegate,
opening and closing
On 2012/11/13 19:29:55, Ted C wrote:
> AutofillExternalDelegate doesn't exist anymore

Done.

https://chromiumcodereview.appspot.com/11364179/diff/10002/chrome/android/tes...
File
chrome/android/testshell/java/src/org/chromium/chrome/testshell/ChromiumTestShellActivity.java
(right):

https://chromiumcodereview.appspot.com/11364179/diff/10002/chrome/android/tes...
chrome/android/testshell/java/src/org/chromium/chrome/testshell/ChromiumTestShellActivity.java:126:
* @return
On 2012/11/13 19:29:55, Ted C wrote:
> return what?  The suspense is killing me!!!!

Done.

https://chromiumcodereview.appspot.com/11364179/diff/10002/chrome/browser/aut...
File chrome/browser/autofill/autofill_popup_view.cc (right):

https://chromiumcodereview.appspot.com/11364179/diff/10002/chrome/browser/aut...
chrome/browser/autofill/autofill_popup_view.cc:72: label_font_ =
value_font_.DeriveFont(kLabelFontSizeDelta);
On 2012/11/13 19:29:55, Ted C wrote:
> should label_font_ be ifdefed out in the header?

Should I ifdef all the uses of label_font_ then? Even in the code that we don't
call?

https://chromiumcodereview.appspot.com/11364179/diff/10002/chrome/browser/ui/...
File chrome/browser/ui/android/autofill/autofill_external_delegate.h (right):

https://chromiumcodereview.appspot.com/11364179/diff/10002/chrome/browser/ui/...
chrome/browser/ui/android/autofill/autofill_external_delegate.h:10: #include
"ui/gfx/native_widget_types.h"
On 2012/11/13 19:29:55, Ted C wrote:
> Where is this needed?

Done.

https://chromiumcodereview.appspot.com/11364179/diff/10002/chrome/browser/ui/...
File chrome/browser/ui/android/autofill/autofill_popup_view_android.h (right):

https://chromiumcodereview.appspot.com/11364179/diff/10002/chrome/browser/ui/...
chrome/browser/ui/android/autofill/autofill_popup_view_android.h:37: jobject
obj);
On 2012/11/13 19:29:55, Ted C wrote:
> these can fit on the same line, so no need to have this on the second.

Done.

https://chromiumcodereview.appspot.com/11364179/diff/10002/content/public/tes...
File
content/public/test/android/javatests/src/org/chromium/content/browser/test/util/TouchCommon.java
(right):

https://chromiumcodereview.appspot.com/11364179/diff/10002/content/public/tes...
content/public/test/android/javatests/src/org/chromium/content/browser/test/util/TouchCommon.java:189:
private void dispatchTouchEvent(final MotionEvent event) {
On 2012/11/13 19:29:55, Ted C wrote:
> have this method call your new method like:
> 
>
dispatchTouchEvent(mActivityTestCase.getActivity().findViewById(android.R.id.content).getRootView()),
> event);

Done.

[Ted C, 2012-11-14 00:38:02]

lgtm

https://chromiumcodereview.appspot.com/11364179/diff/10002/chrome/browser/aut...
File chrome/browser/autofill/autofill_popup_view.cc (right):

https://chromiumcodereview.appspot.com/11364179/diff/10002/chrome/browser/aut...
chrome/browser/autofill/autofill_popup_view.cc:72: label_font_ =
value_font_.DeriveFont(kLabelFontSizeDelta);
On 2012/11/13 22:13:13, aurimas wrote:
> On 2012/11/13 19:29:55, Ted C wrote:
> > should label_font_ be ifdefed out in the header?
> 
> Should I ifdef all the uses of label_font_ then? Even in the code that we
don't
> call?

Personally, I would.  But I can defer to the OWNERS of this code to see if it's
compliant with the rest of it.  I just prefer to not give other engineers the
chance to try and use this only to find out it doesn't work on Android.

[aurimas (slooooooooow), 2012-11-14 01:17:22]

Hey Chris,

Ted brought a good point about my changes to autofill_popup_view.cc. Can you
take a look at my comment?

Aurimas

https://chromiumcodereview.appspot.com/11364179/diff/7009/chrome/browser/auto...
File chrome/browser/autofill/autofill_popup_view.cc (right):

https://chromiumcodereview.appspot.com/11364179/diff/7009/chrome/browser/auto...
chrome/browser/autofill/autofill_popup_view.cc:72: label_font_ =
value_font_.DeriveFont(kLabelFontSizeDelta);
This does not work on Android since we do this java side. Should I ifdef all the
use of label_font_ and value_font_ or should we create platform specific methods
for dealing with fonts?

[aurimas (slooooooooow), 2012-11-14 01:22:06]

Hey Jay,

Could you take a look at the content/public/test/android/ changes? I added a new
test and removed DummyIntegrationTest.java since it will be covered by
AutofillTest.java.

Thanks,
Aurimas

[Jay Civelli, 2012-11-14 17:44:23]

lgtm

[aurimas (slooooooooow), 2012-11-14 17:57:54]

Hello David,

Could you take a look at this CL?

Thanks!
Aurimas

[csharp, 2012-11-14 18:03:08]

https://chromiumcodereview.appspot.com/11364179/diff/7009/chrome/browser/auto...
File chrome/browser/autofill/autofill_popup_view.cc (right):

https://chromiumcodereview.appspot.com/11364179/diff/7009/chrome/browser/auto...
chrome/browser/autofill/autofill_popup_view.cc:72: label_font_ =
value_font_.DeriveFont(kLabelFontSizeDelta);
On 2012/11/14 01:17:22, aurimas wrote:
> This does not work on Android since we do this java side. Should I ifdef all
the
> use of label_font_ and value_font_ or should we create platform specific
methods
> for dealing with fonts?

The fonts are also used to determine the size of the popup, and probably assist
in determining which characters to show for long autofill results.

I would think that ifdefing the code out for android seems like the right idea,
since all the other platform will be working with the same code most of the
time, but I don't have a strong opinion either way.

[aurimas (slooooooooow), 2012-11-14 23:06:19]

Hey Chris,

I added the ifdefs for Android in autofill_popup_view. Does it look good?

Aurimas

[csharp, 2012-11-15 15:17:12]

https://chromiumcodereview.appspot.com/11364179/diff/15001/chrome/browser/aut...
File chrome/browser/autofill/autofill_popup_view.cc (right):

https://chromiumcodereview.appspot.com/11364179/diff/15001/chrome/browser/aut...
chrome/browser/autofill/autofill_popup_view.cc:333: #if !defined(OS_ANDROID)
Why does this need to be idef'ed as well? (And it still seems to be enabled in
the header file)

https://chromiumcodereview.appspot.com/11364179/diff/15001/chrome/browser/aut...
File chrome/browser/autofill/autofill_popup_view.h (right):

https://chromiumcodereview.appspot.com/11364179/diff/15001/chrome/browser/aut...
chrome/browser/autofill/autofill_popup_view.h:175: // The fonts for the popup
text.
Nit: Move the comment inside the ifdef

[aurimas (slooooooooow), 2012-11-15 21:23:11]

Hey Chris,

I fixed your nits.

Aurimas

https://chromiumcodereview.appspot.com/11364179/diff/15001/chrome/browser/aut...
File chrome/browser/autofill/autofill_popup_view.cc (right):

https://chromiumcodereview.appspot.com/11364179/diff/15001/chrome/browser/aut...
chrome/browser/autofill/autofill_popup_view.cc:333: #if !defined(OS_ANDROID)
On 2012/11/15 15:17:12, csharp wrote:
> Why does this need to be idef'ed as well? (And it still seems to be enabled in
> the header file)

It is using GetPopupRequiredWidth() method. I will ifdef the header file too.

https://chromiumcodereview.appspot.com/11364179/diff/15001/chrome/browser/aut...
File chrome/browser/autofill/autofill_popup_view.h (right):

https://chromiumcodereview.appspot.com/11364179/diff/15001/chrome/browser/aut...
chrome/browser/autofill/autofill_popup_view.h:175: // The fonts for the popup
text.
On 2012/11/15 15:17:12, csharp wrote:
> Nit: Move the comment inside the ifdef

Done.

[csharp, 2012-11-15 21:24:13]

lgtm

[aurimas (slooooooooow), 2012-11-16 16:35:13]

Hello David,

I've received LGTMs from a few people already. Could you take a look at the
changes in /chrome/browser/autofill/ ? 

Thanks!
Aurimas

[dhollowa, 2012-11-16 16:58:19]

lgtm

[aurimas (slooooooooow), 2012-11-16 17:05:07]

Hey Nico,

Could you take a look at chrome/ changes? I've changed a few lines in
chrome_browser.gypi and chrome_browser_ui.gypi

Aurimas

[Nico, 2012-11-16 23:13:08]

chrome gypi lgtm

[commit-bot: I haz the power, 2012-11-16 23:14:48]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/11364179/28020

[commit-bot: I haz the power, 2012-11-16 23:15:03]

Presubmit check for 11364179-28020 failed and returned exit status 1.


Running presubmit commit checks ...

** Presubmit Warnings **
Your #include order seems to be broken. Send mail to
[email protected] if this is not the case.
      chrome/browser/ui/android/autofill/autofill_popup_view_android.cc:9

Presubmit checks took 2.9s to calculate.

Was the presubmit check useful? Please send feedback & hate mail to
[email protected]!

[commit-bot: I haz the power, 2012-11-16 23:26:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/11364179/29002

[commit-bot: I haz the power, 2012-11-17 12:24:35]

Change committed as 168408